From 8938869780bc6a37be1478b58dd69cc99846e09b Mon Sep 17 00:00:00 2001 From: Louis Bouchard Date: Mon, 22 Apr 2013 16:26:23 +0200 Subject: landscape.py : fix old format in cmd --- sos/plugins/landscape.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sos/plugins/landscape.py b/sos/plugins/landscape.py index c31dea70..9861281f 100644 --- a/sos/plugins/landscape.py +++ b/sos/plugins/landscape.py @@ -60,10 +60,10 @@ class Landscape(Plugin, UbuntuPlugin): packages = ('landscape-client',) def setup(self): - self.addCopySpec("/etc/landscape/client.conf") + self.add_copy_spec("/etc/landscape/client.conf") def postproc(self): - self.doFileSub("/etc/landscape/client.conf", + self.do_file_sub("/etc/landscape/client.conf", r"registration_password(.*)", r"registration_password[***]" ) -- cgit From fafe3fc1b29b88a6cb2647a7accd7c5caf0308e2 Mon Sep 17 00:00:00 2001 From: Louis Bouchard Date: Mon, 22 Apr 2013 16:27:52 +0200 Subject: ldap.py : remove unneeded def setup --- sos/plugins/ldap.py | 1 - 1 file changed, 1 deletion(-) diff --git a/sos/plugins/ldap.py b/sos/plugins/ldap.py index 3fce4278..0c1dc622 100644 --- a/sos/plugins/ldap.py +++ b/sos/plugins/ldap.py @@ -61,6 +61,5 @@ class DebianLdap(Ldap, DebianPlugin, UbuntuPlugin): def setup(self): super(DebianLdap, self).setup() - def setup(self): self.add_copy_specs(["/etc/ldap/ldap.conf", "/etc/ldap/slapd.d"]) -- cgit From d045d85075b5d947b5d2cf32878162cc03e02e05 Mon Sep 17 00:00:00 2001 From: Louis Bouchard Date: Mon, 22 Apr 2013 16:29:36 +0200 Subject: fix small misses following refactoring --- sos/plugins/named.py | 4 +++- sos/plugins/networking.py | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/sos/plugins/named.py b/sos/plugins/named.py index 8a347f8e..a3f6b003 100644 --- a/sos/plugins/named.py +++ b/sos/plugins/named.py @@ -13,7 +13,9 @@ ## Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. from sos.plugins import Plugin, RedHatPlugin, DebianPlugin, UbuntuPlugin +from os.path import exists, join, normpath import commands +import pdb class Named(Plugin): """named related information @@ -24,7 +26,7 @@ class Named(Plugin): config_files = named_conf def setup(self): - for cfg in config_files: + for cfg in self.config_files: if exists(cfg): self.add_copy_spec(cfg) self.add_copy_spec(self.get_dns_dir(cfg)) diff --git a/sos/plugins/networking.py b/sos/plugins/networking.py index a7e07a80..90b740ca 100644 --- a/sos/plugins/networking.py +++ b/sos/plugins/networking.py @@ -116,7 +116,7 @@ class Networking(Plugin): self.add_cmd_output("brctl showstp "+br_name) if self.get_option("traceroute"): - self.add_cmd_output("/bin/traceroute -n %s" % trace_host) + self.add_cmd_output("/bin/traceroute -n %s" % self.trace_host) return @@ -148,5 +148,5 @@ class UbuntuNetworking(Networking, UbuntuPlugin): self.add_cmd_output("/usr/sbin/ufw status") self.add_cmd_output("/usr/sbin/ufw app list") if self.get_option("traceroute"): - self.add_cmd_output("/usr/sbin/traceroute -n %s" % trace_host) + self.add_cmd_output("/usr/sbin/traceroute -n %s" % self.trace_host) -- cgit