| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The 'history' file includes one line for every cmdline
invocation of TripleO. The file includes useful information
to troubleshoot TripleO based OpenStack deployments, as it
includes timestamps for operations, so the troubleshooter
will now be able to know when the last operation happened.
Resolves: #1765
Signed-off-by: Assaf Muller <amuller@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the release of openvswitch 2.10, the Red Hat Fast Datapath channel
maintains multiple versions of openvswitch.
Update the list of packages using a wildcard to catch all openvswitch2.*
packages.
Resolves: #1768
Signed-off-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The correct package name for Debian/Ubuntu is 'octavia-common' rather
than 'openstack-octavia-common' (which was from RedHat).
Resolves: #1751
Signed-off-by: Trent Lloyd <trent@lloyd.id.au>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for Ubuntu and drops the depends
on distutils replacing with the sos utility.
I believe the functionality should be the same, and
appears to work on Ubuntu.
Closes: #1656
Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
As XML reports were removed from sos, manpages should not refer to
them further.
Resolves: #1669
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Collect Berkely DB config file important for scaled environments
with many durable queues.
Resolves: #1721
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
| |
Resolves: #1724
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Stop collecting duplicate data that apache and squid plugin are responsible for.
Resolves: #1766
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Updates predicate usage within the networking plugin to now require all
kmods needed for 'ss' output to be present.
Additionally, removes the extra check for --allow-system-changes since
that is handled directly in predicate evaluation.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expands predicate evaluation to be able to evaluate True or False
depending on if any of the passed items are present (previous behavior)
or if _all_ the passed items need to be present. This is handled by
optionally passing a dict via the 'required' argument to SoSPredicate.
The keys in this dict are items supported by SoSPredicate (currently
'kmods' and 'services'), with values being either 'any' or 'all'.
Both kmods and services can be passed to the same predicate to allow
fine-grained control over if a command should be collected.
The default behavior remains the same, meaning that both 'kmods' and
'services' are set to 'any' for the required dict. For example,
creating a predicate like the following:
SoSPredicate(self, kmods=['foo', 'bar'], services=['oof', 'rab'])
implies "required={'kmods': 'any', 'services': 'any'}" and thus as long
as either kmods _and_ either of the services exist, the predicate
evaluates True. If, for example, neither of the kmods are present, the
predicate will evaluate False.
Providing a predicate like the following however, will require _both_
kmods to be present and either of the services to evaluate True. If
either kmods are not present, and --allow-system-changes is not set by
the end user, this predicate will evaluate False:
SoSPredicate(self, kmods=['foo', 'bar'], services=['oof', 'rab'],
required={'kmods': 'all'})
Further, --allow-system-changes is handled directly in predicate
evaluation for kmods, meaning individual plugins (like networking) do
not need to separately check for if this flag is set or not. However,
they will still need to specify 'changes=True' to the add_cmd_ouput()
call if the intent is for the warning message that gets logged to
include a mention about using --allow-system-changes.
Fixes: #1755
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During review process of [1] it was suggested to replace '/bin/sh' with
just 'sh', but unfortunately this change caused an error to not include
information about VDSM mount points as described in [2]. This fix
restores previous state and add full path to shell executions.
[1] https://github.com/sosreport/sos/pull/1205
[2] https://bugzilla.redhat.com/1743304
Resolves: #1761
Signed-off-by: Martin Perina <mperina@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expands qemu log collection to included rotated logs.
Additionally, removes the 5MB limit for each path collection as sos now
has implicit size limiting in place, and 5MB would be too small of a
limit for systems running a large number of VMs (such as OSP or oVirt
nodes).
Resolves: #1758
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If no predicate was passed to add_cmd_output() calls, then a predicate
set by set_cmd_predicate() was not being applied to those calls, thus
leading to a 'None' predicate being evaluated and potentially causing an
exception in plugins such as docker where the bulk of command collection
is gated by the service running.
Now if no predicate is handed to add_cmd_output(), and a cmd_predicate
has been set, then the cmd_predicate is applied before being handed off
to the _add_cmd_output() helper.
Fixes: #1756
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
Resolves: #1748
Signed-off-by: Gobinda Das <godas@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Adds the downstream leapp plugin directly into sos. Additionally fixing
an issue where the leapp database may be truncated, rendering the
collected database file unusable.
Resolves: #1753
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
| |
Relevant to: #1749
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Also prevent overwriting os.environ["PGPASSWORD"] by other plugins.
Resolves: #1749
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apply sizelimit separately to individual logfile types to esnure
newest logfile of each type is always collected.
Further, collect also logrotated version fo those files
(up to sizelimit).
Resolves: #1747
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Collect whole /etc/dnf and logrotated /var/log/dnf{,librepo,rpm}.log*
Resolves: #1746
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Collect /sys/kernel/kexec_crash_[size|loaded] on both RedHat
and Debian distributions.
Resolves: #1742
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current HTML report generation is slow and its implementation is full
of scattered html code. We shall utilize Report class instead.
Additionally, add JSON report format for easy automated parsing.
Further, fixed decoding of unicode content of a report.
Fixed report_tests suite including some pycodestyle errors.
Resolves: #1713
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updates the plugin to write container/image/pod output from crictl to
subdirs.
Additionally, fixes an issue where an exception could be raised when a
crictl command has no output at all.
Resolves: #1706
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Collecting /etc/pki/ovirt-engine/ helps to identify expired host certs.
Resolves: #1704
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Collecting /etc/pki/vdsm/certs/ helps to identify expired host certs.
Resolves: #1703
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Collect custom scripts from /etc/NetworkManager/dispatcher.d directory
Resolves: #1701
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Adds collections of path related env vars.
Resolves: #1679
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Adds a new plugin for Qt. Currently, this plugin only collects relevant
environment variables and activates/verifies on the 'qt' package on Red
Hat family distributions.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
Adds collection of the DBUS_SESSION_BUS_ADDRESS env var.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Adds collection of XDG environment variables, as well as DISPLAY and
DESKTOP_SESSION.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Adds collection of common environment variables relevant to support
cases surrounding shell issues.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
Adds collection of proxy environment variables.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
Adds collection of proxy environment variables.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
Adds collection of proxy environment variables.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
Adds collection of proxy environment variables.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a --since switch that takes a date as an argument. This switch
will skip the archive files with a mtime older than the date.
Also, --since affects journalctl execution for --all.
Resolves: #1678
Signed-off-by: David Vallee Delisle <dvd@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Adds collection of mokutil to show is SecureBoot is enabled on the
system or not.
Fixes: #1574
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
To get the WWID sd device combination in a single command.
Resolves: #1626
Signed-off-by: Nitin U. Yewale <nyewale@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
- "ip -s macsec show" requires "macsec" kmod loaded
- "ss -peaonmi" requires 6 *_diag kernel modules
Execute the commands only when the modules are loaded, or when explicitly
requested via --allow-system-changes option.
Resolves: #1435
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Automatically log the reason that a command was skipped by
predicate, and optionally include a message indicating that it may
alter system configuration and that collection can be enabled by
specifying --allow-system-changes.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a generic method to Plugin to log the reason that a command
was skipped during predicate evaluation. The method accepts bool
arguments indicating whether the command relies on kmod or service
presence checks, and a 'change' argument that indicates that it
may alter system configuration (adn so can be collected if the
user supplies --allow-system-changes).
Related: #1678
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
If the --allow-system-changes option is in effect, bypass checking
of kernel modules and allow commands to attempt to auto-load any
missing modules when run.
Related: #1678
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The predicate values used to evaluate a SoSPredicate are useful
to code outside the class and can be safely read and set by plugin
code: make these members public to allow details of predicate state
to be more easily reported by generic Plugin code.
Related: #1678
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
warning and lower priority logs should be logged to stdout
error or higher logs should be logged to stderr
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Running some commands can change the system e.g. by loading a kernel
modules. That disqualifies the commands from being called by default.
Add an option that overrides this default behaviour.
Related to: #1435
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Command filenames collisions must be tested tested against absolute path, not
relative. Otherwise false positive results about no collisions are returned.
- If collision happens for long filenames, ensure that appending ".1" or similar
does not exceed the max filename length.
Resolves: #1684
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds collection of 'gluster volume get $vol all' output for all volume
names as well as the generate dumpfile from 'gluster get-state' when the
'dump' option is used. Note that this file will be under
/var/run/gluster in the archive.
Adds 'glusterd' to the list of processes sent signal USR1 when the
'dump' option is used. Removed the prep work previously done to redirect
where the statedump files are written to, as it has been reported that
those attempts do not function as intended. Statedumps are now collected
from /var/run/gluster.
Finally, some re-organization to ease future maintenance and updating
the size-limiting logic to use the implicit limiting in add_copy_spec().
Resolves: #1664
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
kdump allows to configure to which filesystem and what path it will
write contents of '/proc/vmcore'. kdump plugin currently only checks against
a hardcoded path '/var/crash/*/vmcore-dmesg.txt'.
With this change it will check the 'path' variable and also
filesystems type ext2, ext3, ext4 or xfs against fstab. This will make
the plugin check in the correct path in the system.
Resolves: #1546
Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
Collect /etc/nvme/discovery.conf every time, outside any for-loop block.
Resolves: #1740
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
When a plugin timeouts, it must stop collecting further data. Otherwise
a race issues with archive.finalize() can happen.
So any data collection must be skipped if _timeout_hit is True.
Resolves: #1736
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|