| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Commit d5d8c21 reordered files in the archive, such that the first
member is not the archive root directory further more. Let change the
get_archive_root method accordingly to prevent self.archive_root being
empty.
Resolves: #3616
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
* W4903: deprecated-argument
* W4902: deprecated-method
Signed-off-by: Arif Ali <arif.ali@canonical.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When initializing _packages, a distinction must be made between not
having any package and not being initialized at all.
Otherwise, if a package manager returns no package, the query command
will execute hundreds of times.
This can reproduce with 'flatpak' on RHEL when no package is returned:
# flatpak list
--> no output
# strace -fttTvyy -s 128 -e execve -o sos.strace -- ./bin/sos report
[...]
Press ENTER to continue, or CTRL-C to quit.
^C
# grep -c ' execve("/usr/sbin/flatpak"' sos.strace
350
Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit resolves the remaining 'Empty except' alerts from CodeQL
scanning.
Most of these involve logging something during exception handling when
we were previously simply `pass`ing. Others, either when logging is
unavailable or it makes no sense to log something for, are resolved by
placing comments within the except block as the CodeQL alerts should be
suppressed if the 'empty except' (`pass`ing) has an explanatory note.
Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
|
|
|
|
| |
Signed-off-by: Thom Carlin <tcarlin@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
`pipes` is deprecated and being removed from Python in 3.13. Our usage
is exclusively `pipes.quote()`, which has actually been calling
`shlex.quote()` behind the scenes for some time (at least since 3.6).
Update our usage of `quote` to directly import from `shlex`.
Resolves: #3310
Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
|
|
|
|
| |
Signed-off-by: Arif Ali <arif.ali@canonical.com>
|
|
|
|
| |
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change collects kdump information for Azure Linux.
With this change, we will check the 'path' variable in /etc/kdump.conf
to check where information is being dumped.
If get_vm_core is set to true, collect the latest vm core created
in the last 24 hours that is <= 2GB
Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
|
|
|
|
| |
Signed-off-by: Thom Carlin <tcarlin@redhat.com>
|
|
|
|
| |
Signed-off-by: Thom Carlin <tcarlin@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Extra changes required due to module and function changes in new
avocado
* CentOS Stream is now seen as centos-stream in avocado instead of
centos
* Fine tune tox for stage tests
Closes: #3588
Resolves: #3594
Co-authored-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
Signed-off-by: Arif Ali <arif.ali@canonical.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Consolidate testing, so that things can be run from CLI, CI and
various other means in a consistent way by using tox.
* Updated all the flake8 tests in the tests folder.
* Added pylint as a neutral test so that we can work on this in stages
and have some collaboration on what we test and don't
* The tox tests for unit, stageone, stagetwo testing makes is easier
for users to know how to run tests, and not have to do things
manually
* Using tox for CI doesn't make sense, as that will create virtual
envs and will disregard system/snap based python modules so may not
work
Signed-off-by: Arif Ali <arif.ali@canonical.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Adding a plugin to collect:
- Kafka logs and config files
- basic installation info for debugging purposes
Resolves: SET-96
Signed-off-by: Alejandro Santoyo <alejandro.santoyo@canonical.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the issues reported by the tests on the new version of ubuntu
Resolves: #3587
Closes: #3588
Related: SET-594,SET-595
Co-authored-by: David Negreira <david.negreira@canonical.com>
Signed-off-by: Arif Ali <arif.ali@canonical.com>
Signed-off-by: David Negreira <david.negreira@canonical.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a new preset for `aap_controller`, or Ansible Automation Controller.
This preset will set the `containers_common` plugin to collect output
for the `awx` user.
Related: #3561
Signed-off-by: Rudnei Bertol Junior <rudnei@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Adding the line to collect the nginx log files for the AAP EDA
sos report used for troubleshooting issues at
Ansible Automation Platform Event Driven Controller
Related: RH AAP-12898
Signed-off-by: Rudnei Bertol Junior <rudnei@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Adding the file 'aap_receptor.py' for the sos report collects
the files used for troubleshooting issues at
Ansible Automation Platform Controller/Execution Nodes
Related: RH AAP-19657
Signed-off-by: Rudnei Bertol Junior <rudnei@redhat.com>
|
|
|
|
| |
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Add more resources to output when kubernetes.all option is true.
Remove openshift specific resources from base class.
Output json format if kubernetes.all option is true.
Export pod logs to an individual file for each container, so
the plugin can export logs if there are multiple containers in
a pod.
Signed-off-by: Shunde Zhang <shunde.zhang@canonical.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Capturing this command output can help find the domain status,
specially in these cases where having multiple domains in the same
forest/cross forest, or in cases where there is sssd and samba_winbind.
This output complements that of 'net ads testjoin'.
Related: RH: RHEL-30958
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
| |
Signed-off-by: Marcin Wilk <marcin.wilk@canonical.com>
|
|
|
|
|
|
|
|
|
| |
This patch adds a new line to the github PR
template so users can assess that they have
obfuscated any password or similar from the
code they are submitting.
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
| |
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
|
|
|
| |
Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
|
|
|
|
|
|
|
|
|
| |
Added some missing files from /proc/fs/cifs and blacklist
some files that we don't need to capture.
Related: RH: RHEL-29707
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
|
|
|
|
| |
Add a note to the entries for --upload-user and --upload-pass
clarifying that these options have been deprecated
in RHEL systems.
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the file 'aap_controller.py' for the sos report collects
The files used for troubleshooting issues at
Ansible Automation Platform Automation Controller
Related: RH AAP-18409
Closes: #3561
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
|
|
|
|
|
|
| |
Update the check function
Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
|
|
|
|
|
|
|
|
|
|
| |
This commit is a first pass at addressing a number of the `Empty Except`
warnings flagged by CodeQL. These are for try/except blocks whose except
statement simply contains a `pass`, and to address these we add a log
message in almost all cases. Where we don't log, there is an added
comment for context as to why we're passing without further action.
Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
|
|
|
|
|
|
|
|
| |
Collect also processor ID assigned to the process (psr).
Resolves: #3575
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reduce_mac_match should strip all characters that cant appear in a MAC
address string. Currently it forgets to strip e.g. from
"mac:01:02:03:04:05" anything.
We should strip at least the 'm'. Ideally whole "mac" but that would be
programatically difficult to describe proper condition for that.
Resolves: #3574
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
Continuation of #3530.
Likewise excludes C0114, C0115, and C0209.
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
|
|
|
| |
Signed-off-by: Jorge Rodríguez <jorge.rodriguez@canonical.com>
|
|
|
|
|
|
| |
when --all-logs is specified
Signed-off-by: Jorge Rodríguez <jorge.rodriguez@canonical.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SCL is not used in RHEL past RHEL 7, and sos has not directly supported
RHEL 7 for some years now due to the switch to python3 that came along
with sos-4.0.
Drop SCLPlugin, as it will never be used in modern sos. Cleanup any
references to it in existing plugins as well.
Resolves: #3559
Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Obfuscate OIDC client secret inside
/var/lib/config-data/puppet-generated/keystone/
etc/httpd/conf.d/10-keystone_wsgi.conf
The secret looks like this:
OIDCClientSecret "Password"
And after obfuscation, it will look like this:
OIDCClientSecret *********
Related: RH: RHEL-26720
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
| |
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the file 'aap_hub.py' for the sos report collects
the files used for troubleshooting issues at
Ansible Automation Platform Automation Hub
Related: RH AAP-19782
Closes: #3562
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently Ceph plugins do not take the `all-logs` flag
into account which means that even if this flag is set
compressed log files are not collected
This patch fixes that.
Resolves: SET-480
Signed-off-by: Alejandro Santoyo <alejandro.santoyo@canonical.com>
|
|
|
|
|
|
|
|
|
|
| |
convert2rhel now generates a post-conversion report as well as the
pre-conversion report. We want to be able to collect both reports during
sosreport execution. To make sure we are not missing them (or any other
future report we may introduce), the copy spec string was changed to use
a `*` instead of the names of the reports.
Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
|
|
|
|
|
|
|
|
|
| |
This will ensure that we have the right python version dependancy
for deb packages.
Resolves: SET-543
Signed-off-by: Arif Ali <arif.ali@canonical.com>
|
|
|
|
| |
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Currently we capture the output of 'ceph health detail'
in json format only, but we need plain text output
as well.
Related: RH RHEL-27525
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
|
|
| |
Closes: #3469
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A new option --skip-cleaning-files / --skip-masking-files allows cleaner
to skip cleaning files where the user is certain no sensitive information
is present.
The option supports globs / wildcards.
Relevant: #3469
Closes: #3520
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
| |
Signed-off-by: Drien Breton <drien.breton@orness.com>
|
|
|
|
|
|
|
|
|
| |
Automatically run foreman integration tests when their install script is
updated.
Relevant: #3555
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
A puppet regression in version 7.29.0 prevents foreman-installer to run.
Let prevent installing the buggy puppet-agent-7.29.0* .
Resolves: #3542
Closes: #3555
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are couple of instances (both on pacemaker) of
`parse_version` being used to compare the package
versions. In cases, notably on Ubuntu, where the version
comform to PEP440, this fails. So we now convert those
to PEP440 format before comparing.
Fixes #3548.
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|