| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
| |
Call "cryptsetup luksDump /dev/sd*" for all encrypted devices
Resolves: #1390
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
gssproxy stores its configuration in /etc/gssproxy. Also capture the
mech configuration so that we can tell if gssproxy is enabled and any
other GSS mechs in use.
Resolves: #1386
Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add files for KDC configuration and logging, including kadmin files
and a klist of the K/M stash.
Gather any additional configuration snippet files in
/etc/krb5.conf.d (which is configured by default on Fedora- and
RHEL-like systems, and hopefully on Debian systems in the future).
The sssd plugin already takes care of
/var/lib/sss/pubconf/krb5.include.d/, so don't include that.
Resolves: #1385
Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Adds collection of 'oc adm top' output for images and imagestreams.
Resolves: #1165
Closes: #1383
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
| |
Versions of kubernetes after 1.5 use --kubeconfig instead of --config to
specify a configuration file to use for kubectl commands. Update the
kubernetes plugin to use the proper syntax.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
The 3.10 version of OCP changes the deployment configurations for etcd
and kubernetes components, and additionally changes the way the etcdctl
command is called when running in a static pod. Update these plugins to
support this new deployment style.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
| |
Resolves: #1395
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Make lsof calls on OSP systems disabled by default.
Relevant to: #1395
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Make calling of lsof command optional (but enabled by default).
Also remove "collect lsof-threads when --all-logs" as all-logs
has nothing in common.
Resolves: #1394
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
similarly like we sanitize case id, we should sanitize report label
to e.g. exclude spaces from final tarball name.
Resolves: #1389
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
| |
Closes: #1380.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
This commit adds the plugin rhv-log-collector-analyzer, it will
collect:
- Output of rhv-log-collector-analyer --json
- Generated HTML file from --live
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
|
|
|
|
|
|
|
|
| |
commit 29a40b7 removed leading '/' from two forbidden paths
Resolves: #1388
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Detection of CDS node on RHUI 3 cant rely on deprecated pulp-cds package
but rather on rhui-mirrorlist one.
Resolves: #1375
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
They're just missing the S_ in front of them so if that code gets
reached it fails.
Fixes: #1373
Resolves: #1374
Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds an option to encrypt the resulting archive that sos generates.
There are two methods for doing so:
--encrypt-key Uses a key-pair for asymmetric encryption
--encrypt-pass Uses a password for symmetric encryption
For key-pair encryption, the key-to-be-used must be imported into the
root user's keyring, as gpg does not allow for the use of keyfiles.
If the encryption process fails, sos will not abort as the unencrypted
archive will have already been created. The assumption being that the
archive is still of use and/or the user has another means of encrypting
it.
Resolves: #1320
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
Always output the tarball or build tree location, regardless of
the value of -q/--quiet.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A change in the handling of add_string() operations in the archive
class causes the Plugin string substitution methods to fail (since
the archive was enforcing a check that the path did not already
exist - for substitutions this is always the case).
Maintain the check for content that is being copied into the
archive anew, but make the add_string() method override this and
disable the existence checks.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
Collect a 'list' and 'print --allregions' (do not generate a
report as this will re-set region counters in the kernel).
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
| |
Resolves: #1365
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since setting sizelimit to be equal to the log_size option unless
explicitly set otherwise, there is no longer a need for plugins to do
something like:
self.limit = self.get_option('log_size')
self.add_copy_spec('/foo/bar', sizelimit=self.limit)
As such, update plugins that were just using the log_size setting to no
longer set this sizelimit value unnecessarily.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The RHELPolicy dist_version() was always returning False due to an
invalid call to all_pkgs_by_name_regex(). Correct this call and use the
discovered redhat-release package to determine version.
Resolves: #216
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Allows commands that set their own environment variables to also filter
out variables that are undesired for the given command. Plugins that
need to do this should set the environment variable in question None
when setting 'env' for an add_cmd_output() call.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
| |
Removes the LC_ALL environment variable from the collection of 'locale'
which would cause all locale output to show a setting of 'C' which was
set earlier to get consistent output across sos commands collected.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
on older kernels, bpftool can return error
"can't get next program: Function not implemented"
that lacks "id" we search for in the dict.
Resolves: #1363
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
In the all_files_system() function there's the possibility to
pass a list of directories to be excluded. This wasn't working properly.
It should now exclude the list of dirs.
Signed-off-by: Pierguido Lambri <plambri@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Some packages in post-UsrMove Red Hat systems still install files
to /bin or /sbin: the RPM and mailx packages are known examples.
Treat these paths specially and ensure both the UsrMove and old
path are present in the list of package managed files.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This plugin will collect a list of all binary files that are
available in the standard $PATH and that are not managed by the
distribution package manager.
For now this works only for the distributions that use the
RedHatPolicy (RHEL and Fedora): other policies may add support by
implementing the 'files_command' policy initialiser callback, and
adding the relevant tagging class to the plugin.
Resolves: #1066
Signed-off-by: Pierguido Lambri <plambri@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
This adds two new methods to the class RedHatPolicy.
These two methods helps to handle an UsrMove system.
In particular mangle_package_path() can be used to
substitute the usual /[s]bin references with the
real target /usr/[s]bin.
Signed-off-by: Pierguido Lambri <plambri@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a 'files' member to the PackageManager class, and a new
'files_command' kwarg to the initialiser. If the 'files_command'
is defined it is used to obtain a list of all package managed
files present on the system.
The list may be retrieved by calling PackageManager.all_files().
An implementation of 'files_command' is added to the Red Hat
policy classes.
Signed-off-by: Pierguido Lambri <plambri@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
| |
'steup' for 'setup'.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The threads option was missing from the _arg_names list which meant it
could not actually be changed by the command line option. Add threads to
this list so the number of threads is user-controllable.
Resolves: #1359
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
| |
Resolves: #1358
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
With python3, the 'slots' calculation returns a decimal number which
deque() will not accept, thus throwing an exception. Always make sure
slots is an integer value.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The 'devs' list comprehension generates a list of present FC sysfs
paths by filtering a list of possible directory paths with isdir().
The isdir() test must be on the outer ('for d in dirs') scope
rather than the inner: otherwise listdir() may be called with a
non-existent directory.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the detection of syslog logs in RedHatLogs.setup() by storing
the absolute path ("/var/log/messages"), and using this to detect
the presence of the path with os.path.exists() and append the "*"
in-place when making the add_copy_spec() call.
Also improve the readability of the method and use an explicit
variable, "have_messages", to indicate pressence of syslog style
logs.
Resolves: #1312
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 5d25dd3 "fixed" a longstanding problem with the RedHatLogs
plugin, in that the normal --all-logs behaviour (only collect the
current log unless the option is given) is not respected for the
messages and secure files.
Based on feedback from contributors and support engineers this
has now been reversed and all copies of these logs will now be
included in reports by default again.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
Use string-string comparison when testing option values against
defaults in order to filter out default valued arguments from
display listings.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
| |
In the refactoring of the limit setting in add_journal(), the
variable used to store the final setting was changed from the
'sizelimit' arg to a new 'log_size' local variable. Make sure
the correct 'log_size' is passed on to _add_cmd_output().
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
Instead of using the "name=value" pretty printer to format the
preset options for logging, use the SoSOptions.to_args() method
to convert them to a list of command line style arguments.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
If we encounter a JSON error while loading a preset skip that
file and continue to load any other valid preset files.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The XmlReport class in sos.sosreport traverses the list of plugins
and prepares a report including each collected file.
The access to the file is wrapped in an except block but the recent
change to pycodestyle modified this from a 'naked' except into a
'except IOError' block.
Attempting to open a non-existent path yields an IOError, however
attempting to stat a non-existent path (or a dangling symlink
without lstat()) yields OSError:
# ln -s foo qux
# cat qux
cat: qux: No such file or directory
>>> os.stat("/foo/qux")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
OSError: [Errno 2] No such file or directory: '/foo/qux'
Catch both exception classes in this method.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
When switching a Python string to a raw string escape sequences
like "\\n" must have the first `\` stripped or the literal value
will be taken when the string is used.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|