aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | [ipa] Collect 'getcert list' only if service certmonger is runningJan Jansky2020-01-271-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During collection of 'getcert list' is started certmonger service. That is not wanted behavior, as result should be 'getcert list' collected only if certmonger is running. Resolves: #1920 Signed-off-by: Jan Jansky <jjansky@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | | [firewalld] put "nft list ruleset" under kmods predicatePavel Moravec2020-01-271-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Executing "nft list ruleset" loads kernel modules nf_tables and nfnetlink. Sosreport should call it only under the kmods=[nf_tables,nfnetlink] predicate. Resolves: #1919 Signed-off-by: Pavel Moravec <pmoravec@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | | [openstack_tripleo] Fetch all installer related contentCédric Jeanneret2020-01-271-0/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This plugin allows to fetch the installation-related content, precisely the configuration being launched at some point by the OpenStack installer, known as "TripleO" or "Director". Content of this plugin: - paunch.log containers container configuration and startup information - tripleo-config contains per-step configuration - container-puppet contains per-step puppet related configuration, as well as puppet facts cache. - hierdata contains all the relevant configurations being applied by puppet Resolves: #1918 Signed-off-by: Cédric Jeanneret <cjeanner@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | | [convert2rhel] New plugin for convert2rhel toolJose Castillo2020-01-271-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This plugin gathers logfiles that were created in /var/log/conver2rhel/ after running the convert2rhel tool. Resolves: #1915 Related: RHBZ#1594308 Signed-off-by: Jose Castillo <jose.mfcastillo@gmail.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | | [collectd] grab collectd.log whenever it is presentPavel Moravec2020-01-141-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The plugin should be enabled also in a Super Privileged Container that does not have the collectd package installed, but it has access and logs to the host's collectd.log. This logfile should be grabbed, alongside with config-data dir to ensure the right configs were properly copied to /etc during deployment. Resolves: #1917 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | | [subscription_manager] Collect release infoPavel Moravec2020-01-101-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Collect subscription-manager release [--show|list] that helps identifying yum/dnf issues with inaccessible repositories. Resolves: #1912 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | | [sapnw] implement collect_cmd_output API changePavel Moravec2020-01-091-6/+4
|/ / | | | | | | | | | | | | | | | | Since e8bb94c, collect_cmd_output returns a dict instead of filename. Reflect the change in testing command output. Resolves: #1859 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [Plugin] Align service check method names with other checksJake Hunsaker2020-01-086-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | The historic name pattern for `Plugin` checks is `is_$thing()`, such as `is_executable`, `is_installed`, etc... The service checks for a loaded `InitSystem` exposed via the `Plugin` API however did not follow this convention. Re-name the `service_is_*` methods to `is_service_*` to better align with the rest of the API. Resolves: #1891 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [ctdb] Improve CTDB pluginAnoop C S2020-01-081-1/+4
| | | | | | | | | | | | | | | | | | | | * Include main CTDB configuration and additional files * Include list of enabled legacy event scripts Resolves: #1894 Signed-off-by: Anoop C S <anoopcs@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [foreman] Fix invalid yaml filesRohan Arora2020-01-081-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | Foreman plugin replaces sensitive data with ***** which is not a yalid yaml value. Hence the yaml files collected by sos are not valid yaml files. This change replaces the sensitive data with quoted stars "*****" instead to presrve yaml syntax. Closes #1876 Resolves: #1877 Signed-off-by: Rohan Arora <roarora@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [pulp] Fix invalid syntax in collected json filesRohan Arora2020-01-081-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Plugin replaces sensitive data in etc/pulp/server/plugins.conf.d/*json with ******* which is an invalid json value. Also it takes away a "," and collected file is no longer a valid json. This change modifies the regex used to get a valid json file. Also Fixed Regex above it which was consuming any file having "conf" even in middle of file path. Closes #1878 Signed-off-by: Rohan Arora <roarora@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [sosreport] Fix noreport to be available in sos.confKeigo Noha2020-01-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | In _opt_to_args(), no_value had noreport. However, the list is used for converting option name in sos.conf to command-line option. It means that noreport needs to be no-report for aligning command-line option. Resolves: #1904 Signed-off-by: Keigo Noha <knoha@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [ovirt_hosted_engine] Collect rotated HA logs by defaultJake Hunsaker2020-01-011-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updates the plugin to collect the rotated agent and broker HA logs by default. These logs are small and can be rotated faster than other ovirt components, leading to cases where HA logs do not go back far enough even though we capture a lot of historical data from VDSM and other components. Now we will collect the rotated logs up until the `--log-size` threshold is reached. Users may use `--all-logs` to remove this size restriction as usual. Related: RHBZ#1787119 Resolves: #1906 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [process] Update pstree to display PIDs and not truncateJake Hunsaker2019-12-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | By default pstree will truncate long lines, which can make it difficult to identify processes a support representative is chasing - this is especially true for container process names. First, don't truncate long lines anymore. Second, add PID numbers to the pstree output to allow more accurate analysis of pstree output. Resolves: #1905 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [powerpc] Add "ppc64_cpu --info" to the list of commandsMurilo Opsfelder Araujo2019-12-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The command "ppc64_cpu --info" produces a handy output to easily determine which threads are online and which ones are offline. For example: $ ppc64_cpu --info Core 0: 0* 1* 2 3 Core 1: 4* 5* 6 7 Core 2: 8* 9* 10 11 Core 3: 12* 13* 14 15 Core 4: 16* 17* 18 19 Core 5: 20* 21* 22 23 Core 6: 24 25 26 27 Core 7: 28 29 30 31 Core 8: 32* 33* 34 35 Core 9: 36* 37* 38 39 Core 10: 40* 41* 42 43 Core 11: 44* 45* 46 47 Core 12: 48* 49* 50 51 Core 13: 52* 53* 54 55 Core 14: 56 57 58 59 Core 15: 60 61 62 63 Core 16: 64* 65* 66 67 Core 17: 68* 69* 70 71 Core 18: 72* 73* 74 75 Core 19: 76* 77* 78 79 Core 20: 80* 81* 82 83 Core 21: 84* 85* 86 87 Core 22: 88* 89* 90 91 Core 23: 92* 93* 94 95 Core 24: 96* 97* 98 99 Core 25: 100* 101* 102 103 Core 26: 104* 105* 106 107 Core 27: 108* 109* 110 111 Core 28: 112* 113* 114 115 Core 29: 116* 117* 118 119 Core 30: 120* 121* 122 123 Core 31: 124* 125* 126 127 Resolves: #1903 Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [foreman] increase sizelimit for tasks exportPavel Moravec2019-12-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | When foreman stores tens to hundreds of thousands of tasks, default sizelimit causes the dynflow* or foreman_tasks_tasks files are truncated. Let increase the sizelimit to 100MB. Resolves: #1899 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [kernel,networking] collect bpftool net list for each namespacePavel Moravec2019-12-162-5/+6
| | | | | | | | | | | | | | | | | | | | | | - move "bpftool net list" command execution from kernel to networking plugin as it belongs rather to networking. - collect that output per each net name space as well Resolves: #1874 Signed-off-by: Pavel Moravec <pmoravec@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [ceph] Add 'ceph insights' command outputBrad Hubbard2019-12-121-0/+1
| | | | | | | | | | | | | | | | | | | | This change adds the output of the recently added 'ceph insights' command. Resolves: #1888 Signed-off-by: Brad Hubbard <bhubbard@redhat.com> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [Plugin] Detect copy operations without the adequate access rightsEric Desrochers2019-12-121-0/+4
| | | | | | | | | | | | | | | | | | | | (e.g. apparmor restriction for '/proc/sys/fs/binfmt' inside a LXD container) Fix: #1662 Resolves: #1867 Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [ceph] collect ceph-volume lvm listTrent Lloyd2019-12-121-1/+2
| | | | | | | | | | | | | | | | | | | | Ceph is moving from managing disks with ceph-disk to using ceph-volume which uses LVM. So now collect the 'ceph-volume lvm list' output. Resolves: #1889 Signed-off-by: Trent Lloyd <trent@lloyd.id.au> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [dnf] Collect dnf module listPavel Moravec2019-12-111-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Adds collection of `dnf module list` to the plugin, to show a list of all modules available to the system, instead of just those that are currently installed. Related: RHBZ#1781819 Resolves: #1887 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [dnf] Use output from command instead of reading filePavel Moravec2019-12-111-16/+12
| | | | | | | | | | | | | | | | | | As the installed module loop uses `collect_cmd_output`, we can just iterate over the output directly, rather than re-reading the contents into memory a second time via the saved file. Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [plugins] improve heuristic for applying --since to logarchivesPavel Moravec2019-12-112-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | logarchive_pattern treats some configs (e.g. /etc/dbus-1) as log archives, causing --since option will skip collecting them. This patch just improves the heuristic by claiming nothing under /etc is a logarchive, and adds a warning to sosreport help. Improves: #1847 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [logs] Substancial rewrite ending RH/U/D differencesBryan Quigley2019-12-112-82/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | --all-logs totally broke due to extra s in get_options, this resulted in me trying to fix it, but it's simply grown too complicated IMHO. We're duplicating functionality differently in the RH and Ubuntu/Debian sections. Logs.py changes: Dropped the log_days option as it's confusing with since. Use journal if persistant, otherwise don't collect it. If all-logs collect full raw journal insteaf of verbose as it's the same size but collects more info and is easier to parse. Still collecting catalog for this/last boot ignoring since. RH request. Collect message/secure no matter what. Rh specific. Collect first 3 syslog/kern/auth only if not-journal. Default to just stop at 100mb limit jounral limit (which is enforced outside of plugin). Also implement some basic "did it error" travis checks for the above. Resolves: #1822 Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [policies] fix missing tmpdir for RedHat distroPavel Moravec2019-12-101-0/+1
| | | | | | | | | | | | | | | | | | | | a0e0a52 removed setting 'tmpdir' from Policy get_msg while RedHatPolicy refers on it. Resolves: #1881 Signed-off-by: Pavel Moravec <pmoravec@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [policies] Fix human readable filesizes functionBryan Quigley2019-12-091-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | We should have been using MiB instead of MB. And as MiB is what ls -alh uses I think that makes sense. Also got rid of CapitalNaming. Discussed in #887 Resolved: #1884 Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [foreman] cast dynflow_execution_plans.uuid as varcharPavel Moravec2019-12-091-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | Due to a change in foreman DB scheme, we must explicitly cast dynflow_execution_plans.uuid as a varchar since foreman-tasks 0.15.5 . The explicit casting works well on older versions as well. Resolves: #1882 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [numa] Add node hugepages informationJorge Niedbalski2019-12-071-1/+2
| | | | | | | | | | | | | | | | | | | | Add the sysfs hugepages information for each numa node. Resolves: #1868 Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [sosreport] Change text format, add username, filesize and chksumBryan Quigley2019-12-072-12/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changes the format of the end text making the output information more consistent. We now mention the username that owns the archive the filesize in a human readable format, and the checksum. New format: Your sosreport has been generated and saved in: /tmp/sosreport-desktop-20180313115538.tar.xz Size 63.55KB Owner root sha256 d0ae51b7e57a6f6f8b336cc0d5a9b5bcc3fd1f6796cfc0df2e74bb98590b82dc We remove the tmpdir from the pretext. We also enable saying if configuration changes should be expected or not, given options selected. Closes: #631 Resolves: #887 Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [canonical-livepatch] No longer need to hardcode absolute pathEric Desrochers2019-12-071-3/+3
| | | | | | | | | | | | | | Resolves: #1864 Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [ovn_central] call podman exec without a timeoutPavel Moravec2019-12-051-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a workaround fix of a podman bug (see rhbz1732525) where "podman ps" can hang when "podman exec .." is invoked in detached mode under "timeout". Calling it without timeout works fine. This commit can be reverted once the podman bug is fixed. Resolves: #1875 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [container_log] fix unscoped 'logdir' variablePavel Moravec2019-12-041-1/+1
|/ | | | | | | "sosreport -o container_log --all-logs" fails on global name 'logdir' is not defined. Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [ovn_central] catch ovn2.*-central packagesDaniel Alvarez2019-11-141-1/+1
| | | | | | | | After splitting OVN from OVS, new packages exist for ovn which should be taken into account by the relevant plugins. Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [ovn_host] catch ovn2.*-host packagesDaniel Alvarez2019-11-141-1/+1
| | | | | | | | After splitting OVN from OVS, new packages exist for ovn which should be taken into account by the relevant plugins. Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [python] Add hashes option, refactor Python vs. RedHatPythonBissenbay2019-11-141-8/+55
| | | | | | | | | | | | | | | | Adds a new `hashes` option to the `python` plugin. When specified, this option will generate a hash for every python file discovered in the `/usr/lib*` and `/usr/local/lib*` canonical paths. This information is then written to the archive as `digests.json` Additionally, refactors the differences between the base `Python` and `RedHatPython` classes when dealing with the system-default python installation. Resolves: #1801 Signed-off-by: Bissenbay Dauletbayev <bissenbay@gmail.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [crio] Gate crictl commands by package predicateJake Hunsaker2019-11-141-4/+9
| | | | | | | | The `crictl` utility is provided by cri-tools, which is not required for a base crio installation. If the -tools package is not installed, skip attmepting to collect crictl output. Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [openstack_keystone] implement exec_cmd API changePavel Moravec2019-11-141-2/+3
| | | | | | | | | | Since e8bb94c, exec_cmd returns a dict instead of command output. Reflect the change in testing the return value and using the output. Resolves: #1860 Signed-off-by: Pavel Moravec <pmoravec@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [redhat] Update cantboot preset to use profilesJake Hunsaker2019-11-141-4/+6
| | | | | | | | | | | | | Updates the 'cantboot' preset to use existing profiles, rather than specifying each plugin and having to maintain that list in the policy. Now 'cantboot' enables the boot, storage, and system profiles - it also will now enable the boot.all-images, rpm.rpmva, and rpm.rpmdb plugin options. Resolves: #1818 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [ssh] Add plugin to 'system' profileJake Hunsaker2019-11-141-1/+1
| | | | | | Related: #1818 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [apport] List var crash recursivelyEric Desrochers2019-11-131-1/+1
| | | | | | | | | | | | | | | Listing /var/crash recursively will provide not only the root of /var/crash as current state, but also data found in subdirectories if any as follow: $ ls /var/crash/201911131119/ dmesg.201911131119 dump.201911131119 Resolves: #1861 Signed-by-off: Eric Desrochers <eric.desrochers@canonical.com> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* [lxd] Add detection when lxd is installed as a snap.Eric Desrochers2019-11-131-0/+1
| | | | | | | | | | | | | | | | | Conventional deb package extracts lxd binary in /usr/bin/lxd, while snap extracts lxd binary in /snap/bin/lxd. More and more Ubuntu integrates mechanisms to convert DEB to SNAP (especially for Canonical products such as juju, lxd, canonical-livepatch) during release upgrade. Meaning sosreport should be capable to detect both installation types. Resolves: 1855 Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* [kubernetes] no longer need to hardcode snap pathEric Desrochers2019-11-131-1/+1
| | | | | | | '/snap/bin' has been added into the Ubuntu policy PATH environment. Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>
* [policies] Add PATH for UbuntuEric Desrochers2019-11-131-0/+2
| | | | | | | | Add PATH for Ubuntu policies and integrate /snap/bin, preventing to hardcode the patch inside the plugins if installed as a snap. Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>
* [foreman,katello] move relicts of katello plugin to foremanPavel Moravec2019-11-132-66/+4
| | | | | | | | | | | | | Katello plugin does not further collect any katello-related data. qpid-stat was moved to pulp, (foreman) table sizes to foreman and /var/log/httpd/katello-reverse-proxy* belong to foreman-proxy. Move the latest bit to foreman and drop katello plugin. Resolves: #1843 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [virsh] add new path collection of virt-manager logsMORISHIMA Shigeki2019-11-131-4/+4
| | | | | | | | | | | The path of virt-manager logs was changed from "/root/.virt-manager/" to "/root/.cache/virt-manager". New path collection is added to virsh plugin. Resolves: #1851 Signed-off-by: MORISHIMA Shigeki <s.morishima@fujitsu.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [pcp] Fix FileNotFoundError exceptionJose Castillo2019-11-131-1/+1
| | | | | | | | | | | | | After API command consolidation via commit e8bb94c and commit e51d3e6, pcp started throwing a FileNotFound exception since the plugin treats the command output as the name of a path to open. Remove the open and just use the content of the 'output' entry directly. Resolves: #1852 Signed-off-by: Jose Castillo <jose.mfcastillo@gmail.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [kubernetes] Set plugin_namePavel Moravec2019-11-131-0/+1
| | | | | | | | | | | | | Without setting plugin_name in parent class, "sosreport --list-plugins" prints plugin name based on the child class name (redhatkubernetes, ubuntukubernetes). Trying to refer that plugin name fails. Setting plugin_name to "kubernetes" in the parent Kubernetes class prevents this confusion. Resolves: #1858 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [man] describe --allow-system-changes (#1850)Pavel Moravec2019-11-121-0/+4
| | | | | | | | | In #1435, --allow-system-changes option was added that is documented in sosreport --help but not in manpages. Resolves: #1850 Signed-off-by: Pavel Moravec <pmoravec@redhat.com> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* [Plugin|Policy] Only call lsmod once and standardize kmod checksPavel Moravec2019-11-122-13/+8
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit makes two changes to how sos deals with kernel modules and their state during a run of sosreport. First, no longer call `lsmod` for every individual plugin during its enablement check. Instead, call `lsmod` only once during `Policy` initialization, and cache the output for later checks. Second, have `Plugin.is_module_loaded()` check for kmod presence in the saved policy class attr for kernel_mods, rather than checking through `/proc/modules`. Have the plugin enablement checks now also use `is_module_loaded()` to standardize with how `SoSPredicate`s are checked. Note that this change results in a significant performance increase for sos initialization times in a RHEL 7 container. Resolves: #1854 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
| * [Plugin|Policy] Only call lsmod once and standardize kmod checksJake Hunsaker2019-11-112-13/+8
|/ | | | | | | | | | | | | | | | | | | | | | This commit makes two changes to how sos deals with kernel modules and their state during a run of sosreport. First, no longer call `lsmod` for every individual plugin during its enablement check. Instead, call `lsmod` only once during `Policy` initialization, and cache the output for later checks. Second, have `Plugin.is_module_loaded()` check for kmod presence in the saved policy class attr for kernel_mods, rather than checking through `/proc/modules`. Have the plugin enablement checks now also use `is_module_loaded()` to standardize with how `SoSPredicate`s are checked. Note that this change results in a significant performance increase for sos initialization times in a RHEL 7 container. Resolves: #1854 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
generated by cgit (git 2.34.1) at 2024-11-08 14:56:58 +0000