aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [composer] New plugin for lorax-composerPavel Moravec2018-12-131-0/+39
| | | | | | | | | | lorax-composer is an API server for building disk images using Blueprints. The plugin collects composer config and logs and few composer-cli command outputs. Resolves: #1477 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [Plugin] clean up Plugin.get_option()Bryn M. Reeves2018-12-123-29/+5
| | | | | | | | | | | | | There's a lot of ancient junk in this method (and associated code strewn around sos.sosreport and tests). Remove the ability to pass a list of options to the method since nothing uses this, and also delete the incomplete implementation of global plugin options via the commons dictionary (this work was already completed some time ago by mapping these options directly to the command line args). Resolves: #1498 Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [networking] Replace "brctl: by "bridge" commandsPavel Moravec2018-12-122-31/+9
| | | | | | | | | | | | As bridge-utils containing brctl command are being deprecated, sosreport should call bridge command instead. Although the mapping of the commands is not 1:1, the data collected (together with few "ip .." commands) will remain the same. Resolves: #1472 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [firewalld] collect nftables rulesetPavel Moravec2018-12-121-0/+3
| | | | | | | | Collect "nft list ruleset". Resolves: #1470 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [crypto] collect more configs and commandsPavel Moravec2018-12-121-1/+9
| | | | | | | | | | | | | | | Commands: fips-mode-setup --check update-crypto-policies --show update-crypto-policies --is-applied Files: /etc/system-fips /etc/crypto-policies/* Resolves: #1448 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [podman] allow the plugin for RedHatPlugin and UbuntuPluginPavel Moravec2018-12-121-6/+5
| | | | | | | | | | | | Until Podman inherits RedHatPlugin and/or UbuntuPlugin, the plugin can not be executed on underlying distros. Further, remove one redundant test as "for container in insp" will work properly also for empty "insp". Resolves: #1473 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [plugins] fix 6db459e for SCL servicesPavel Moravec2018-12-121-8/+10
| | | | | | | | | | | | Calling _files_pkgs_or_cmds_present for SCLs lacks "services" argument that was added in 6db459e commit. Also it is worth renaming the method to more generic _check_plugin_triggers . Resolves: #1416 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [postgresql] Do not limit dump sizeYedidyah Bar David2018-12-121-1/+1
| | | | | | | | | | | | | | In principle, this might be risky - if a database is huge, we might not want to collect all of it. But there is no sense in collecting only its tail. If this turns out problematic, a future patch might check db size and do not collect it at all if it's too large. Bug-Url: https://bugzilla.redhat.com/1654068 Resolves: #1497 Signed-off-by: Yedidyah Bar David <didi@redhat.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [Plugin] Obey sizelimit=0Yedidyah Bar David2018-12-041-2/+4
| | | | | | | If sizelimit is 0, do not limit. Only use the default if it's None. Bug-Url: https://bugzilla.redhat.com/1654068 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
* [powerpc] Add support to collect DLPAR and LPM related logsSourabh Jain2018-10-091-2/+6
| | | | | | | | | | | | | This patch updates powerpc plugin to collect Dynamic Resource Manager (drmgr) log files i.e. /var/log/drmgr and /var/log/drmgr.0. In addition, it also adds ctsanp command to collect the information about the Reliable Scalable Cluster Technology (RSCT) components. Resolves: #1443 Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [kernel] dont collect some tracing instance filesPavel Moravec2018-10-081-1/+4
| | | | | | | | As copying of them hangs. Resolves: #1445 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [openstack_*] relax enabling of OSP RedHat pluginsPavel Moravec2018-10-0316-131/+26
| | | | | | | | | | Allow automatic enabling of OSP packages also on containerized environment. Relevant to: #1411 Signed-off-by: Pavel Moravec <pmoravec@redhat.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [openstack_nova] remove too restrictive check_enabledPavel Moravec2018-10-031-8/+0
| | | | | | | | Enable the plugin just based on package presence. Resolves: #1411 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [archive] fix and simplify directory destination rewritingPavel Moravec2018-09-141-5/+3
| | | | | | | | | | | | | | | | | | | | Rewriting of the destination path by _make_leading_paths() only applies when creating intermediate path components that are a symbolic link. The final level of path creation must always be a directory, and the destination is always the absolute path to that directory. Always return the directory path when creating a new directory, and do not attempt to rewrite the destination at the top level in FileCacheArchive._check_path() since all intermediate links have already been handled inside _make_leading_paths() (i.e. the returned/rewritten destination is always equal to the path that was passed into the function). Resolves: #1432 Signed-off-by: Pavel Moravec <pmoravec@redhat.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive, plugin] avoid recursing on symbolic link loopsBryn M. Reeves2018-09-132-5/+42
| | | | | | | | | | | | | | | | | | | It's possible that symlink loops exist in the host file system, either 'simple' ('a'->'a'), or indirect ('a'->'b'->'a'). We need to avoid recursing on these loops, to avoid exceeding the maximum link or recursion depths, but we should still represent these inodes as accurately as possible in the resulting archive. Detect loops in both the Plugin link handling code and in the new Archive link follow-up code by creating the first requested level of loop, and then skipping the recursive follow-up. This means that the looping links are still created in the archive so long as they are referenced in a copy spec but that we do not attempt to indefinitely recurse while collecting them. Resolves: #1430 Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] canonicalise paths for link follow upBryn M. Reeves2018-09-121-1/+1
| | | | | | | | | Ensure that the canonical path is used when processing link follow up actions: the actual link path may contain one or more levels of symbolic links, leading to broken links if the link target path is assumed to be relative to the containing directory. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] canonicalize link target path in Plugin._copy_symlink()Bryn M. Reeves2018-09-121-1/+4
| | | | | | | | | | | | Since we may be dealing with paths that contain intermediate symlinked directories, it is necessary to canonicalize the path for the link target in order to eliminate additional levels of symbolic links, and to calculate the correct relative path to use within the archive. Related: #1404 Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [utilities] use correct comparison-to-None styleBryn M. Reeves2018-09-111-1/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] fix link rewriting logic in FileCacheArchive.add_link()Bryn M. Reeves2018-09-111-11/+19
| | | | | | | | | | | | | | | When processing link follow up for an original symbolic link, the add_link() logic incorrectly used the _original_ host link name, rather than the to-be-created name when calculating relative path structures. If the prior link is at a greater or lesser level of directory nesting this will lead to broken relative links in the archive (one level too high or too low). In some cases (systemd) this behaviour was masked due to the fact that identically named links exist at multiple levels of the path hierarchy. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] fix local variable name in FileCacheArchive.add_link()Bryn M. Reeves2018-09-111-1/+1
| | | | | | | The 'link_path' local was renamed to 'link_name' to better match other uses in the code. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [utilities] wait until AsyncReader p.poll() returns NoneBryn M. Reeves2018-09-101-1/+2
| | | | | | | | | | | | | | On some systems the pipe used by the AsyncReader() class and the sos_get_command_output() function may still be open at the time the p.poll() call returns. At this time the command exit status is undefined, leading to errors and collection failures for code that tests the command's exit code. Wait explicitly until poll() returns None to avoid this. Resolves: #1417 Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [atomic] Define valid preset for RHEL AtomicJake Hunsaker2018-09-101-1/+14
| | | | | | | | | | | Defines an 'atomic' preset for use with the RedHatAtomic policy for RHEL Atomic Host. Fixes sos being unable to run due to the preset probe returning a string rather than a preset. Resolves: #1418 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] remove unused 'copy' arg from FileCacheArchive.add_dir()Bryn M. Reeves2018-09-101-2/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] add link follow-up to FileCacheArchive.add_link()Bryn M. Reeves2018-09-101-3/+35
| | | | | | | | | | | | | | | | | | Creating a link may trigger further actions in the archive: if the link target is a regular file, we must copy that file into the archive, and if the target is a symbolic link, then we must create that link, and copy in the link target. Handle this by calling add_file() or (recursively) add_link() in order to create the missing pieces of the symlink chain. These operations must take place outside of the path lock since they do not modify the archive namespace and will call methods of the Archive object that will attempt to re-acquire this lock. Resolves: #1404 Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] fix leading path creationBryn M. Reeves2018-09-101-7/+34
| | | | | | | | | | | | | | | | Fix the creation of leading path components for both paths that contain intermediate components that are symbolic links (with both absolute and relative targets), and those that contain only directory components. Since symlinks may link to other files, and other symlinks, it is necessary to handle these paths recursively and to include any intermediate symlinked directories, or symlink targets in the set of paths added to the archive. Related: #1404 Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [Plugin] fix exception raise in Plugin._copy_dir()Bryn M. Reeves2018-09-101-1/+1
| | | | | | | | Use a naked 'raise' statement rather than raising the already caught exception in _copy_dir(), so that the original stack and backtrace are avaialable. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [sosreport] trap directly to PDB in handle_exception()Bryn M. Reeves2018-09-101-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | Now that plugins are run in a threadpool, it is not possible to defer the call to pdb.post_mortem() to the top-level exception handler in the main thread: this is due to the fact that in a pool, exceptions are caught and saved to be re-raised to thread calling the pool when results are returned. When the saved exception is raised to the top-level handler the execution context it relates to is gone: the backtrace and stack frame have been torn down and only very limited information is available from the exception frame. Instead, catch these exceptions _inside_ the thread pool context, and directly trap to the Python debugger. This allows plugin code to be debugged interactively with the full backtrace and with all access to local variables and the execution stack. In addition, this means that after the debugger has handled the exception it is possible to return to the run and continue until report completion. One side effect of this change is that the *-plugin-errors.txt file containng the backtrace is now written into the archive whether or not --debug is given. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [sosreport] ensure ThreadPool exceptions are raisedBryn M. Reeves2018-09-101-2/+6
| | | | | | | | | | | | | | The ThreadPoolExecutor does not raise exceptions to the parent thread immediately: it stores them in-line in the pool's results list, and raises them to the caller on acccess to that slot in the results iterator. Make sure that these exceptions are handled by iterating over all results and asserting that they are non-None (in practice, this code is never executed since the resulting raise will trap to an exception handler, but it is less confusing than a bare 'pass'). Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [openstack-nova] Add missing placement api wsgi logsMikel Olasagasti Uranga2018-09-041-0/+10
| | | | | | | Resolves: #1409 Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugins] Add Support for podman as well as docker.Daniel J Walsh2018-09-034-28/+44
| | | | | | | | | | | | OpenStack daemons can now run in OCI containers launched by both podman and docker. Need to check both locations. Resolves: #1408 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [podman] Add support for gathering information on podman containersDaniel J Walsh2018-09-031-0/+79
| | | | | | | Resolves: #1407. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [docker] combine docker 'inspect' and 'logs' loopsBryn M. Reeves2018-09-031-3/+1
| | | | | | | | | We're iterating over all the containers: might as well only do it one time. Related: #1406, #1407 Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [crio] Add support for gathering information on cri-o containersDaniel J Walsh2018-09-031-0/+74
| | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* [buildah] collect information about container configurationDaniel J Walsh2018-09-031-0/+7
| | | | | | | | | These configuration files can effect the way that buildah works. Resolves: #1405 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [sudo] new pluginPavel Moravec2018-09-031-0/+29
| | | | | | | | Collect /etc/sudo* and scrub bindpw in /etc/sudo-ldap.conf Resolves: #1402 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [megacli] Correct MegaCli commands and enablementJake Hunsaker2018-09-031-13/+9
| | | | | | | | | | | | | | The MegaCli64 command needs to be called using the full path to the binary. Also, correct the -ShowSummary adapter argument. Additionally, use the builtin 'files' check to enable the plugin only if the binary exists. Closes: #403 Resolves: #1392 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [lvm] Add columns to lvs collectionJake Hunsaker2018-09-031-1/+2
| | | | | | | | | | | Adds the lv_(kernel)_read_ahead, stripes, and stripsize columns to lvs output. Closes: #800 Resolves: #1391 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [Policies|Plugins] Add services memberJake Hunsaker2018-09-033-5/+142
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a services member to facilitate plugin enablement. This is tied to a new InitSystem class that gets attached to policies. The InitSystem class is used to determine services that are present on the system and what those service statuses currently are (e.g. enabled/disable). Plugins can now specify a set of services to enable the plugin on if that service exists on the system, similar to the file, command, and package checks. Additionally, the Plugin class now has methods to check on service states, and make decisions based off of. For example: def setup(self): if self.is_service('foobar'): self.add_cmd_output('barfoo') Currently, only systemd has actual functionality for this. The base InitSystem inherited by policies by default will always return False for service checks, thus resulting in the same behavior as before this change. The Red Hat family of distributions has been set to systemd, as all current versions of those distributions use systemd. Closes: #83 Resolves: #1387 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [ovirt_node] New plugin for oVirt NodeNijin Ashok2018-09-031-0/+41
| | | | | | | | | | | oVirt Node is a small scaled down version used for hosting virtual machines. The plugin collects node specific information like upgrade log, the layer structure etc. Resolves: #1381 Signed-off-by: Nijin Ashok nashok@redhat.com Signed-off-by: Bryn M. Reeves bmr@redhat.com
* [multipath] add multipath -t outputJohn Pittman2018-09-031-0/+1
| | | | | | | | | | | | | | | | | | | | | The 'multipath -t' command prints the internal hardware table of device-mapper-multipath. These are the true, hard-coded defaults that multipath will follow if no other configuration is set. The hardware table is specific to the device-mapper-multipath version that is in use, so it is subject to change across release, making it difficult to track. Prior to the -t flag creation, the user would have to check the source package or /usr/share/doc/device-mapper-multipath for the table. The output is needed as a piece of the puzzle in how the 'multipathd show config' command presents the current, running configuration (it uses the .conf and the hardware table). This makes it very useful in troubleshooting activities. Resolves: #1379 Signed-off-by: John Pittman <jpittman@redhat.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [multipath] use -ll for path checker and prio inclusionJohn Pittman2018-09-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'multipath -l' command, per the man page, shows the topology as 'fetched in sysfs and the device mapper' and 'multipath -ll' shows the topology from 'all available information'. The '-ll' option, among other things, includes useful items such as prio values and path checkers, without adding much more verbosity. For example, prio value ommission seen below: |-+- policy='service-time 0' prio=0 status=active | |- 2:0:1:2 sdh 8:112 active undef unknown | `- 5:0:1:2 sdal 66:80 active undef unknown `-+- policy='service-time 0' prio=0 status=enabled |- 2:0:0:2 sdc 8:32 active undef unknown `- 5:0:0:2 sdag 66:0 active undef unknown |-+- policy='service-time 0' prio=50 status=active | |- 2:0:1:2 sdh 8:112 active ready running | `- 5:0:1:2 sdal 66:80 active ready running `-+- policy='service-time 0' prio=10 status=enabled |- 2:0:0:2 sdc 8:32 active ready running `- 5:0:0:2 sdag 66:0 active ready running Gather 'multipath -ll' instead of 'multipath -l' as the additional information adds value without additional verbosity. Signed-off-by: John Pittman <jpittman@redhat.com>
* [plugins] Add transport_url to protected keysPaul Peereboom2018-09-0313-12/+16
| | | | Signed-off-by: Paul Peereboom <paul.peereboom@duo.nl>
* [pacemaker] Collect stonith and quorum statusJake Hunsaker2018-09-031-0/+5
| | | | | | | | | Adds collection of stonith and quorum states within the cluster to the pacemaker plugin. If either of these are not used in a given cluster, these commands simply report that the resource is not in use so this is safe to run on all clusters. Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [grafana] all_logs to collect all log filesPavel Moravec2018-09-031-1/+1
| | | | | | | | not only *.log ones Resolves: #1371 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [archive] replace FileCacheArchive._makedirs()Bryn M. Reeves2018-09-031-8/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Python os.makedirs() implementation is inadequate for sos's needs: it will create leading directories given an intended path destination, but it is not able to reflect cases where some of the intermediate paths are actually symbolic links. Replace the use of os.makedirs() with a method that walks over the path, and either creates directories, or symbolic links (and their directory target) to better correspond with the content of the host file system. This fixes a situation where two plugins can race in the archive, leading to an exception in the plugin that runs last: - /foo/bar exists and is a link to /foo/bar.qux - One plugin attempts to collect /foo/bar - Another plugin attempts to collect a link /foo/qux -> /foo/bar/baz If the 2nd plugin happens to run first it will create the path "/foo/bar" as a _directory_ (via _makedirs()). Since the archive now checks for matching object types when a path collision occurs, the first plugin will arrive at add_dir(), note that "/foo/bar" is present and is not a symbolic link, and will raise an exception. Correct this by ensuring that whichever plugin executes first, the correct link/directory path structure will be set up. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] normalise dest_dir in FileCacheArchive._check_path()Bryn M. Reeves2018-08-311-1/+4
| | | | | | | | Always set a valid dest_dir in _check_path() and do not assume that it can be obtained by splitting the path: in the case of a directory it is the unmodified 'dest' value. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] simplify FileCacheArchive.makedirs()Bryn M. Reeves2018-08-311-4/+4
| | | | | | | | | | | | | Simplify the makedirs() method of FileCacheArchive and have it bypass _check_path() and directly call os.makedirs(): a subsequent patch will restrict the use of the method to setting up the sos_* directories in the archive root. File, directory and other object type add_* methods will use a new method that correctly handles symbolic links in intermediate path components. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [sosreport] properly raise exceptions when --debug is givenBryn M. Reeves2018-08-311-1/+4
| | | | | | | | OSError and IOError exceptions were not raised to the terminal when --debug is in effect since they were silently caught in the generic exception handler. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] Dont copystat /sys and /proc pathsPavel Moravec2018-08-231-6/+7
| | | | | | | | | Stop copying extended attributes of files under /sys and /proc that can raise SELinux denials on that attempt. Resolves: #1399 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [block] collect luksDump for all encrypted devicesPavel Moravec2018-08-231-0/+22
| | | | | | | | Call "cryptsetup luksDump /dev/sd*" for all encrypted devices Resolves: #1390 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
generated by cgit (git 2.34.1) at 2024-11-16 21:15:12 +0000