aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* [sar] Fix the parameter specified in add_copy_spec() to wildcardMIZUTA Takeshi2020-01-281-3/+3
| | | | | | | | | | | | | "/var/log/sa" is specified in add_copy_spec() in sar.py. However, if a directory is specified in the parameter of add_copy_spec(), --log-size does not work properly. Therefore, fix "/var/log/sa" to wildcard so that --log-size works correctly. Resolves: #1863 Signed-off-by: MIZUTA Takeshi <mizuta.takeshi@fujitsu.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [Plugin] Allow selectively disabling postprocessingJake Hunsaker2020-01-285-11/+63
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds two mechanisms by which users can choose to disable postprocessing of collected information. First, is a global method exposed via the `--no-postproc` option. Using this option will skip postprocessing for all plugins. Second, is a per-plugin option exposed via a new 'postproc' plugin option. This is set to _True_ by default (meaning yes, perform postprocessing), which users can set to False or off to disable postprocessing for that plugin only; e.g. `-k podman.postproc=off` Closes: #286 Resolves: #1862 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
| * [Plugin] Allow selectively disabling postprocessingJake Hunsaker2019-11-195-11/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds two mechanisms by which users can choose to disable postprocessing of collected information. First, is a global method exposed via the `--no-postproc` option. Using this option will skip postprocessing for all plugins. Second, is a per-plugin option exposed via a new 'postproc' plugin option. This is set to _True_ by default (meaning yes, perform postprocessing), which users can set to False or off to disable postprocessing for that plugin only; e.g. `-k podman.postproc=off` Closes: #286 Resolves: #1862 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [memory] Collect slabtop infoJake Hunsaker2020-01-281-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds collection of `slabtop -o` to show the top consumers of SLAB. Note that currently there is an issue with this command that will cause it to hang if stdin does not receive a tty - which is exactly what happens when commands are run via `timeout` without the `foreground` option. As such, this command for now will use `foreground=True` parameter for `add_cmd_output()`. Once/if this slaptop bug is fixed, this plugin will be updated to no longer use that parameter. Resolves: #1895 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [Plugin] Improve predicate failure messageJake Hunsaker2020-01-281-9/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the logged warning message when a predicate evaluation fails would be a string that contained all elements passed to the predicate, and include an empty list for checks that were not run by the predicate. This meant that it was not immediately clear _which_ element(s) caused the predicate evaluation to fail. Now, during evaluation of the predicate checks, any failures are recorded and the new failure message is generated based on these failures. Thus, only the missing elements are presented to the user, allowing for easier identification of what caused a particular collection to be skipped. Resolves: #1910 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [ovn_central] Remove timeout=None from container ps callsJake Hunsaker2020-01-281-4/+2
| | | | | | | | | | | | | | | | | | | | | | Replaces the `timeout=None` parameter in the container-centric commands that was being used as a workaround for a disconnected TTY causing the commands to hang when run via sos. Now use the `foreground=True` option to not disconnect the TTY. Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [utilities] Add --foreground to timeout commands optionallyJake Hunsaker2020-01-282-8/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A small number of recent issues have been identified that revolved around certain commands hanging when run by sos unless `timeout=None` was specified for those commands. This patch adds `--foreground` to the `timeout` command that we use to wrap any collected commands, so as to not disconnect the TTY which was resulting in the hanging behavior. This addition is controlled by the use of the new `foreground` parameter in any `add_cmd_output()` or `collect_cmd_output()` call. Resolves: #1909 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [Policy] Wrap json.load() in with clauseJake Hunsaker2020-01-281-4/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Wraps `json.load()` from preset loading in a `with` statement to ensure that file objects are properly closed. Closes: #1322 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
| * | [Policy] Wrap json.load() in with clauseJake Hunsaker2020-01-091-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | Wraps `json.load()` from preset loading in a `with` statement to ensure that file objects are properly closed. Closes: #1322 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | | [global] PEP 257 docstring fixesJake Hunsaker2020-01-2723-77/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PEP 257 specifies docstrings should always use triple double quotes, rather than triple single quotes. This commit corrects the places where triple single quotes are used incorrectly, most of which were done by yours truly. Resolves: #1914 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | | [snappy] Check for presence of the snapd pkg instead of its binaryEric Desrochers2020-01-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To perform snap command, 'snapd' debian package must be installed: https://snapcraft.io/docs/installing-snap-on-ubuntu https://launchpad.net/ubuntu/+source/snapd $ apt-file search /usr/bin/snap snapd: /usr/bin/snap $ dpkg -S /usr/bin/snap snapd: /usr/bin/snap Resolves: #1922 Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | | [ipa] Collect 'getcert list' only if service certmonger is runningJan Jansky2020-01-271-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During collection of 'getcert list' is started certmonger service. That is not wanted behavior, as result should be 'getcert list' collected only if certmonger is running. Resolves: #1920 Signed-off-by: Jan Jansky <jjansky@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | | [firewalld] put "nft list ruleset" under kmods predicatePavel Moravec2020-01-271-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Executing "nft list ruleset" loads kernel modules nf_tables and nfnetlink. Sosreport should call it only under the kmods=[nf_tables,nfnetlink] predicate. Resolves: #1919 Signed-off-by: Pavel Moravec <pmoravec@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | | [openstack_tripleo] Fetch all installer related contentCédric Jeanneret2020-01-271-0/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This plugin allows to fetch the installation-related content, precisely the configuration being launched at some point by the OpenStack installer, known as "TripleO" or "Director". Content of this plugin: - paunch.log containers container configuration and startup information - tripleo-config contains per-step configuration - container-puppet contains per-step puppet related configuration, as well as puppet facts cache. - hierdata contains all the relevant configurations being applied by puppet Resolves: #1918 Signed-off-by: Cédric Jeanneret <cjeanner@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | | [convert2rhel] New plugin for convert2rhel toolJose Castillo2020-01-271-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This plugin gathers logfiles that were created in /var/log/conver2rhel/ after running the convert2rhel tool. Resolves: #1915 Related: RHBZ#1594308 Signed-off-by: Jose Castillo <jose.mfcastillo@gmail.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | | [collectd] grab collectd.log whenever it is presentPavel Moravec2020-01-141-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The plugin should be enabled also in a Super Privileged Container that does not have the collectd package installed, but it has access and logs to the host's collectd.log. This logfile should be grabbed, alongside with config-data dir to ensure the right configs were properly copied to /etc during deployment. Resolves: #1917 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | | [subscription_manager] Collect release infoPavel Moravec2020-01-101-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Collect subscription-manager release [--show|list] that helps identifying yum/dnf issues with inaccessible repositories. Resolves: #1912 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | | [sapnw] implement collect_cmd_output API changePavel Moravec2020-01-091-6/+4
|/ / | | | | | | | | | | | | | | | | Since e8bb94c, collect_cmd_output returns a dict instead of filename. Reflect the change in testing command output. Resolves: #1859 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [Plugin] Align service check method names with other checksJake Hunsaker2020-01-086-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | The historic name pattern for `Plugin` checks is `is_$thing()`, such as `is_executable`, `is_installed`, etc... The service checks for a loaded `InitSystem` exposed via the `Plugin` API however did not follow this convention. Re-name the `service_is_*` methods to `is_service_*` to better align with the rest of the API. Resolves: #1891 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [ctdb] Improve CTDB pluginAnoop C S2020-01-081-1/+4
| | | | | | | | | | | | | | | | | | | | * Include main CTDB configuration and additional files * Include list of enabled legacy event scripts Resolves: #1894 Signed-off-by: Anoop C S <anoopcs@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [foreman] Fix invalid yaml filesRohan Arora2020-01-081-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | Foreman plugin replaces sensitive data with ***** which is not a yalid yaml value. Hence the yaml files collected by sos are not valid yaml files. This change replaces the sensitive data with quoted stars "*****" instead to presrve yaml syntax. Closes #1876 Resolves: #1877 Signed-off-by: Rohan Arora <roarora@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [pulp] Fix invalid syntax in collected json filesRohan Arora2020-01-081-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Plugin replaces sensitive data in etc/pulp/server/plugins.conf.d/*json with ******* which is an invalid json value. Also it takes away a "," and collected file is no longer a valid json. This change modifies the regex used to get a valid json file. Also Fixed Regex above it which was consuming any file having "conf" even in middle of file path. Closes #1878 Signed-off-by: Rohan Arora <roarora@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [sosreport] Fix noreport to be available in sos.confKeigo Noha2020-01-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | In _opt_to_args(), no_value had noreport. However, the list is used for converting option name in sos.conf to command-line option. It means that noreport needs to be no-report for aligning command-line option. Resolves: #1904 Signed-off-by: Keigo Noha <knoha@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [ovirt_hosted_engine] Collect rotated HA logs by defaultJake Hunsaker2020-01-011-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updates the plugin to collect the rotated agent and broker HA logs by default. These logs are small and can be rotated faster than other ovirt components, leading to cases where HA logs do not go back far enough even though we capture a lot of historical data from VDSM and other components. Now we will collect the rotated logs up until the `--log-size` threshold is reached. Users may use `--all-logs` to remove this size restriction as usual. Related: RHBZ#1787119 Resolves: #1906 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [process] Update pstree to display PIDs and not truncateJake Hunsaker2019-12-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | By default pstree will truncate long lines, which can make it difficult to identify processes a support representative is chasing - this is especially true for container process names. First, don't truncate long lines anymore. Second, add PID numbers to the pstree output to allow more accurate analysis of pstree output. Resolves: #1905 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [powerpc] Add "ppc64_cpu --info" to the list of commandsMurilo Opsfelder Araujo2019-12-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The command "ppc64_cpu --info" produces a handy output to easily determine which threads are online and which ones are offline. For example: $ ppc64_cpu --info Core 0: 0* 1* 2 3 Core 1: 4* 5* 6 7 Core 2: 8* 9* 10 11 Core 3: 12* 13* 14 15 Core 4: 16* 17* 18 19 Core 5: 20* 21* 22 23 Core 6: 24 25 26 27 Core 7: 28 29 30 31 Core 8: 32* 33* 34 35 Core 9: 36* 37* 38 39 Core 10: 40* 41* 42 43 Core 11: 44* 45* 46 47 Core 12: 48* 49* 50 51 Core 13: 52* 53* 54 55 Core 14: 56 57 58 59 Core 15: 60 61 62 63 Core 16: 64* 65* 66 67 Core 17: 68* 69* 70 71 Core 18: 72* 73* 74 75 Core 19: 76* 77* 78 79 Core 20: 80* 81* 82 83 Core 21: 84* 85* 86 87 Core 22: 88* 89* 90 91 Core 23: 92* 93* 94 95 Core 24: 96* 97* 98 99 Core 25: 100* 101* 102 103 Core 26: 104* 105* 106 107 Core 27: 108* 109* 110 111 Core 28: 112* 113* 114 115 Core 29: 116* 117* 118 119 Core 30: 120* 121* 122 123 Core 31: 124* 125* 126 127 Resolves: #1903 Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [foreman] increase sizelimit for tasks exportPavel Moravec2019-12-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | When foreman stores tens to hundreds of thousands of tasks, default sizelimit causes the dynflow* or foreman_tasks_tasks files are truncated. Let increase the sizelimit to 100MB. Resolves: #1899 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [kernel,networking] collect bpftool net list for each namespacePavel Moravec2019-12-162-5/+6
| | | | | | | | | | | | | | | | | | | | | | - move "bpftool net list" command execution from kernel to networking plugin as it belongs rather to networking. - collect that output per each net name space as well Resolves: #1874 Signed-off-by: Pavel Moravec <pmoravec@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [ceph] Add 'ceph insights' command outputBrad Hubbard2019-12-121-0/+1
| | | | | | | | | | | | | | | | | | | | This change adds the output of the recently added 'ceph insights' command. Resolves: #1888 Signed-off-by: Brad Hubbard <bhubbard@redhat.com> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [Plugin] Detect copy operations without the adequate access rightsEric Desrochers2019-12-121-0/+4
| | | | | | | | | | | | | | | | | | | | (e.g. apparmor restriction for '/proc/sys/fs/binfmt' inside a LXD container) Fix: #1662 Resolves: #1867 Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [ceph] collect ceph-volume lvm listTrent Lloyd2019-12-121-1/+2
| | | | | | | | | | | | | | | | | | | | Ceph is moving from managing disks with ceph-disk to using ceph-volume which uses LVM. So now collect the 'ceph-volume lvm list' output. Resolves: #1889 Signed-off-by: Trent Lloyd <trent@lloyd.id.au> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [dnf] Collect dnf module listPavel Moravec2019-12-111-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Adds collection of `dnf module list` to the plugin, to show a list of all modules available to the system, instead of just those that are currently installed. Related: RHBZ#1781819 Resolves: #1887 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [dnf] Use output from command instead of reading filePavel Moravec2019-12-111-16/+12
| | | | | | | | | | | | | | | | | | As the installed module loop uses `collect_cmd_output`, we can just iterate over the output directly, rather than re-reading the contents into memory a second time via the saved file. Signed-off-by: Jake Hunsaker <jhunsake@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [plugins] improve heuristic for applying --since to logarchivesPavel Moravec2019-12-112-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | logarchive_pattern treats some configs (e.g. /etc/dbus-1) as log archives, causing --since option will skip collecting them. This patch just improves the heuristic by claiming nothing under /etc is a logarchive, and adds a warning to sosreport help. Improves: #1847 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [logs] Substancial rewrite ending RH/U/D differencesBryan Quigley2019-12-112-82/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | --all-logs totally broke due to extra s in get_options, this resulted in me trying to fix it, but it's simply grown too complicated IMHO. We're duplicating functionality differently in the RH and Ubuntu/Debian sections. Logs.py changes: Dropped the log_days option as it's confusing with since. Use journal if persistant, otherwise don't collect it. If all-logs collect full raw journal insteaf of verbose as it's the same size but collects more info and is easier to parse. Still collecting catalog for this/last boot ignoring since. RH request. Collect message/secure no matter what. Rh specific. Collect first 3 syslog/kern/auth only if not-journal. Default to just stop at 100mb limit jounral limit (which is enforced outside of plugin). Also implement some basic "did it error" travis checks for the above. Resolves: #1822 Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [policies] fix missing tmpdir for RedHat distroPavel Moravec2019-12-101-0/+1
| | | | | | | | | | | | | | | | | | | | a0e0a52 removed setting 'tmpdir' from Policy get_msg while RedHatPolicy refers on it. Resolves: #1881 Signed-off-by: Pavel Moravec <pmoravec@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* | [policies] Fix human readable filesizes functionBryan Quigley2019-12-091-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | We should have been using MiB instead of MB. And as MiB is what ls -alh uses I think that makes sense. Also got rid of CapitalNaming. Discussed in #887 Resolved: #1884 Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [foreman] cast dynflow_execution_plans.uuid as varcharPavel Moravec2019-12-091-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | Due to a change in foreman DB scheme, we must explicitly cast dynflow_execution_plans.uuid as a varchar since foreman-tasks 0.15.5 . The explicit casting works well on older versions as well. Resolves: #1882 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [numa] Add node hugepages informationJorge Niedbalski2019-12-071-1/+2
| | | | | | | | | | | | | | | | | | | | Add the sysfs hugepages information for each numa node. Resolves: #1868 Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [sosreport] Change text format, add username, filesize and chksumBryan Quigley2019-12-072-12/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changes the format of the end text making the output information more consistent. We now mention the username that owns the archive the filesize in a human readable format, and the checksum. New format: Your sosreport has been generated and saved in: /tmp/sosreport-desktop-20180313115538.tar.xz Size 63.55KB Owner root sha256 d0ae51b7e57a6f6f8b336cc0d5a9b5bcc3fd1f6796cfc0df2e74bb98590b82dc We remove the tmpdir from the pretext. We also enable saying if configuration changes should be expected or not, given options selected. Closes: #631 Resolves: #887 Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [canonical-livepatch] No longer need to hardcode absolute pathEric Desrochers2019-12-071-3/+3
| | | | | | | | | | | | | | Resolves: #1864 Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com> Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
* | [ovn_central] call podman exec without a timeoutPavel Moravec2019-12-051-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a workaround fix of a podman bug (see rhbz1732525) where "podman ps" can hang when "podman exec .." is invoked in detached mode under "timeout". Calling it without timeout works fine. This commit can be reverted once the podman bug is fixed. Resolves: #1875 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* | [container_log] fix unscoped 'logdir' variablePavel Moravec2019-12-041-1/+1
|/ | | | | | | "sosreport -o container_log --all-logs" fails on global name 'logdir' is not defined. Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [ovn_central] catch ovn2.*-central packagesDaniel Alvarez2019-11-141-1/+1
| | | | | | | | After splitting OVN from OVS, new packages exist for ovn which should be taken into account by the relevant plugins. Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [ovn_host] catch ovn2.*-host packagesDaniel Alvarez2019-11-141-1/+1
| | | | | | | | After splitting OVN from OVS, new packages exist for ovn which should be taken into account by the relevant plugins. Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [python] Add hashes option, refactor Python vs. RedHatPythonBissenbay2019-11-141-8/+55
| | | | | | | | | | | | | | | | Adds a new `hashes` option to the `python` plugin. When specified, this option will generate a hash for every python file discovered in the `/usr/lib*` and `/usr/local/lib*` canonical paths. This information is then written to the archive as `digests.json` Additionally, refactors the differences between the base `Python` and `RedHatPython` classes when dealing with the system-default python installation. Resolves: #1801 Signed-off-by: Bissenbay Dauletbayev <bissenbay@gmail.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [crio] Gate crictl commands by package predicateJake Hunsaker2019-11-141-4/+9
| | | | | | | | The `crictl` utility is provided by cri-tools, which is not required for a base crio installation. If the -tools package is not installed, skip attmepting to collect crictl output. Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [openstack_keystone] implement exec_cmd API changePavel Moravec2019-11-141-2/+3
| | | | | | | | | | Since e8bb94c, exec_cmd returns a dict instead of command output. Reflect the change in testing the return value and using the output. Resolves: #1860 Signed-off-by: Pavel Moravec <pmoravec@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [redhat] Update cantboot preset to use profilesJake Hunsaker2019-11-141-4/+6
| | | | | | | | | | | | | Updates the 'cantboot' preset to use existing profiles, rather than specifying each plugin and having to maintain that list in the policy. Now 'cantboot' enables the boot, storage, and system profiles - it also will now enable the boot.all-images, rpm.rpmva, and rpm.rpmdb plugin options. Resolves: #1818 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
* [ssh] Add plugin to 'system' profileJake Hunsaker2019-11-141-1/+1
| | | | | | Related: #1818 Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>