| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
| |
Adds a new plugin for cloud-init.
Fixes: #1584
Resolves: #1630
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the addition of predicates, there is the very real possibility that
plugins can end up gating multiple add_cmd_output() or similar calls
around the same predicate, such as service enablement.
Previously, this meant every single check of the predicate resulted in a
new InitSystem._query_service() call was made. Now, we only call
_query_service() once and save the results, since status is unlikely to
change during the course of plugin execution.
Resolves: #1629
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to this patch, ovn_host was disabled on containerized
setups due to the fact that ovn-controller package is not
installed in the host.
This patch fixes it by checking if the ovn-controller process
is running.
Resolves: #1767
Signed-off-by: Daniel Alvarez <dalvarez@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is adding support in ovn_central plugin to containerized
setups.
Now it's detecting if the OVN central services are running in
container and execute the relevant commands inside it. The support
covers both podman and docker runtimes.
Signed-off-by: Daniel Alvarez <dalvarez@redhat.com>
|
|
|
|
|
| |
Signed-off-by: Daniel Alvarez <dalvarez@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
This patch is adding 'show' commands for both OVN
NorthBound and SouthBound databases.
Signed-off-by: Daniel Alvarez <dalvarez@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
| |
And make sos.spec up to date.
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
| |
Fix pep8 issues from increasing indentation.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Until now, we didn't have a central plugin for collecting
service container logs. Each service was managing its own
things, and this lead to missing log files in the past.
Ensuring we fetch the content of /var/log/containers on its
own ensures we won't forget to add possible new directories,
like the "stdouts" we recently added in OpenStack in order
to get the container STDOUT written on the disk.
Therefore, this commit does 2 main things:
- cleanup all the /var/logs/containers custom copy
- create a central plugin that takes care of this location on
its own. It's active by default and ensure the location
actually exists.
Resolves: #1668
Signed-off-by: Cédric Jeanneret <cjeanner@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Running any ipvsadm command can cause the kernel to autoload the
ip_vs module. So only run ipvsadm commands if the ip_vs kernel module
is found to already be loaded on the system.
Resolves: #1634
Signed-off-by: Patrick Talbert <ptalbert@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
Resolves: #1686
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Add addtional commands to ceph plugin.
Resolves: #1694
Signed-off-by: Ashish Singh <assingh@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A number of openstack plugins were calling 'rpm -V' against their own
package lists as part of their setup() method when the --verify option
is given to sos. This is already done in normal plugin execution, so
there is no need to duplicate the calls.
This change removes these calls from the openstack plugins.
Resolves: #1696
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Sosreport should log when skipping files due to sizelimit.
That gives users valuable information about remaining files on
the system.
Resolves: #1719
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During undercloud and overcloud deploy preparation steps, a task is
fetching container images and pushing them to a local registry
(usually on the undercloud directly).
Since this task might fail at some point, we need this log in order to
properly debug the issue and provide better support.
The task itself doesn't produce any other output than this log, and only
exists on the undercloud.
Resolves: #1730
Signed-off-by: Cédric Jeanneret <cjeanner@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
This change adds the quorum_status and
mon_status output to the ceph plugin.
Resolves: #1738
Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a command (lsinitrd) to extract the content of
kdump initramfs.
Resolves: #1744
Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the get_cmd_output_now() function does not pass
'suggest_filename' and 'root_symlink' parameters to
_get_cmd_output_now() function, so the parameters passed
from plugins are ignored. Let's fix this.
Resolves: #1745
Signed-off-by: Kazuhito Hagio <k-hagio@ab.jp.nec.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
When troubleshooting containerized OOO Deployments,
it can help a lot to have the tripleo-config files
on the overcloud nodes.
Resolves #1760
Signed-off-by: David Vallee Delisle dvd@redhat.com
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Catch use cases when /etc/os-release is missing by returning
Amazon policy as disabled.
Resolves: #1763
Signed-off-by: pmoravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The 'history' file includes one line for every cmdline
invocation of TripleO. The file includes useful information
to troubleshoot TripleO based OpenStack deployments, as it
includes timestamps for operations, so the troubleshooter
will now be able to know when the last operation happened.
Resolves: #1765
Signed-off-by: Assaf Muller <amuller@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the release of openvswitch 2.10, the Red Hat Fast Datapath channel
maintains multiple versions of openvswitch.
Update the list of packages using a wildcard to catch all openvswitch2.*
packages.
Resolves: #1768
Signed-off-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The correct package name for Debian/Ubuntu is 'octavia-common' rather
than 'openstack-octavia-common' (which was from RedHat).
Resolves: #1751
Signed-off-by: Trent Lloyd <trent@lloyd.id.au>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for Ubuntu and drops the depends
on distutils replacing with the sos utility.
I believe the functionality should be the same, and
appears to work on Ubuntu.
Closes: #1656
Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
As XML reports were removed from sos, manpages should not refer to
them further.
Resolves: #1669
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Collect Berkely DB config file important for scaled environments
with many durable queues.
Resolves: #1721
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
| |
Resolves: #1724
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Stop collecting duplicate data that apache and squid plugin are responsible for.
Resolves: #1766
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Updates predicate usage within the networking plugin to now require all
kmods needed for 'ss' output to be present.
Additionally, removes the extra check for --allow-system-changes since
that is handled directly in predicate evaluation.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expands predicate evaluation to be able to evaluate True or False
depending on if any of the passed items are present (previous behavior)
or if _all_ the passed items need to be present. This is handled by
optionally passing a dict via the 'required' argument to SoSPredicate.
The keys in this dict are items supported by SoSPredicate (currently
'kmods' and 'services'), with values being either 'any' or 'all'.
Both kmods and services can be passed to the same predicate to allow
fine-grained control over if a command should be collected.
The default behavior remains the same, meaning that both 'kmods' and
'services' are set to 'any' for the required dict. For example,
creating a predicate like the following:
SoSPredicate(self, kmods=['foo', 'bar'], services=['oof', 'rab'])
implies "required={'kmods': 'any', 'services': 'any'}" and thus as long
as either kmods _and_ either of the services exist, the predicate
evaluates True. If, for example, neither of the kmods are present, the
predicate will evaluate False.
Providing a predicate like the following however, will require _both_
kmods to be present and either of the services to evaluate True. If
either kmods are not present, and --allow-system-changes is not set by
the end user, this predicate will evaluate False:
SoSPredicate(self, kmods=['foo', 'bar'], services=['oof', 'rab'],
required={'kmods': 'all'})
Further, --allow-system-changes is handled directly in predicate
evaluation for kmods, meaning individual plugins (like networking) do
not need to separately check for if this flag is set or not. However,
they will still need to specify 'changes=True' to the add_cmd_ouput()
call if the intent is for the warning message that gets logged to
include a mention about using --allow-system-changes.
Fixes: #1755
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During review process of [1] it was suggested to replace '/bin/sh' with
just 'sh', but unfortunately this change caused an error to not include
information about VDSM mount points as described in [2]. This fix
restores previous state and add full path to shell executions.
[1] https://github.com/sosreport/sos/pull/1205
[2] https://bugzilla.redhat.com/1743304
Resolves: #1761
Signed-off-by: Martin Perina <mperina@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expands qemu log collection to included rotated logs.
Additionally, removes the 5MB limit for each path collection as sos now
has implicit size limiting in place, and 5MB would be too small of a
limit for systems running a large number of VMs (such as OSP or oVirt
nodes).
Resolves: #1758
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If no predicate was passed to add_cmd_output() calls, then a predicate
set by set_cmd_predicate() was not being applied to those calls, thus
leading to a 'None' predicate being evaluated and potentially causing an
exception in plugins such as docker where the bulk of command collection
is gated by the service running.
Now if no predicate is handed to add_cmd_output(), and a cmd_predicate
has been set, then the cmd_predicate is applied before being handed off
to the _add_cmd_output() helper.
Fixes: #1756
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
Resolves: #1748
Signed-off-by: Gobinda Das <godas@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Adds the downstream leapp plugin directly into sos. Additionally fixing
an issue where the leapp database may be truncated, rendering the
collected database file unusable.
Resolves: #1753
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
| |
Relevant to: #1749
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Also prevent overwriting os.environ["PGPASSWORD"] by other plugins.
Resolves: #1749
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apply sizelimit separately to individual logfile types to esnure
newest logfile of each type is always collected.
Further, collect also logrotated version fo those files
(up to sizelimit).
Resolves: #1747
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Collect whole /etc/dnf and logrotated /var/log/dnf{,librepo,rpm}.log*
Resolves: #1746
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Collect /sys/kernel/kexec_crash_[size|loaded] on both RedHat
and Debian distributions.
Resolves: #1742
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current HTML report generation is slow and its implementation is full
of scattered html code. We shall utilize Report class instead.
Additionally, add JSON report format for easy automated parsing.
Further, fixed decoding of unicode content of a report.
Fixed report_tests suite including some pycodestyle errors.
Resolves: #1713
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updates the plugin to write container/image/pod output from crictl to
subdirs.
Additionally, fixes an issue where an exception could be raised when a
crictl command has no output at all.
Resolves: #1706
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Collecting /etc/pki/ovirt-engine/ helps to identify expired host certs.
Resolves: #1704
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Collecting /etc/pki/vdsm/certs/ helps to identify expired host certs.
Resolves: #1703
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Collect custom scripts from /etc/NetworkManager/dispatcher.d directory
Resolves: #1701
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Adds collections of path related env vars.
Resolves: #1679
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Adds a new plugin for Qt. Currently, this plugin only collects relevant
environment variables and activates/verifies on the 'qt' package on Red
Hat family distributions.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
Adds collection of the DBUS_SESSION_BUS_ADDRESS env var.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Adds collection of XDG environment variables, as well as DISPLAY and
DESKTOP_SESSION.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Adds collection of common environment variables relevant to support
cases surrounding shell issues.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|