| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
During the re-organisation of sosreport.py the code to apply all
boolean options to plug-ins was factored out into its own
function, _set_all_options() however this was never called from
the main execute() method. Fix this to allow the option to work
as previously.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
A user may override the sos temporary directory via --tmp-dir to
a non-existent or unwritable location. Check for this before
initialising temporary files and exit with an error message.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
Current distributions do not include the legac package versions
that the plug-in was checking for.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
By default the general module will scoop up all files under the
/var/log/sa directory. With some configurations this path could
contain many GB of data.
Use add_copy_spec_limit() by default for sar data and add a new
option sar.all_sar=False to allow the user to override this.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Historically the general plug-in collected the content of the
/var/log/sa directory while a separate sar plug-in handles the text
formatted summary files.
This makes little sense and adds to the bloat in the "general"
module; move the collection to the sar plug-in itself.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
| |
Following the reorganisation of the OpenStack plug-ins the
dashboard module now duplicates functionality provided by the
horizon plug-in. Remove it and keep all the horizon and dashboard
support in a single module.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
The keystone plug-in used a command line option to enable password
removal. This should be the default behaviour - remove the option
and always apply the password replacement rules.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Xavier Queralt <xqueralt@redhat.com>
|
|
|
|
| |
Signed-off-by: Xavier Queralt <xqueralt@redhat.com>
|
|
|
|
|
|
|
|
| |
Split out support for the OpenStack Cinder, Dashboard, Nova and
Quantum components from the single OpenStack plug-in.
Signed-off-by: Jeremy Agee <jagee@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
|
|\
| |
| |
| | |
Addition of plugins for procenv and upstart.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
| |
| |
| |
| | |
Signed-off-by: James Hunt <james.hunt@ubuntu.com>
|
|/
|
|
| |
Signed-off-by: James Hunt <james.hunt@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|\
| |
| |
| |
| |
| |
| |
| | |
Closes: #204
Added Lukas to AUTHORS file for his contribution of katello/foreman
Signed-off-by: Louis Bouchard <louis.bouchard@ubuntu.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
| |
| |
| |
| | |
Closes: #204
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since CloudForms 1.0 has been renamed to Satellite 6.0, I am deleting this
plugin and providing two other plugins. Both projects Katello and Foreman
are upstream projects for Satellite 6.0 Red Hat products. Since both
projects support deployment on non-redhat systems, they both deliver own
reporting script that collects information from target system. Both scripts
have options not to create tarball and to provide output to desired
directory. This has been tested on RHEL 6.4.
Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since CloudForms 1.0 has been renamed to Satellite 6.0, I am deleting this
plugin and providing two other plugins. Both projects Katello and Foreman
are upstream projects for Satellite 6.0 Red Hat products. Since both
projects support deployment on non-redhat systems, they both deliver own
reporting script that collects information from target system. Both scripts
have options not to create tarball and to provide output to desired
directory. This has been tested on RHEL 6.4.
Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Since fix for 0ed431a went in we revert our unittests to the old (working) behavior.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Removed quantum specific collection commands from the openstack plugin
and put them into a separate module. The plugin is also neutron/quantum
agnostic and should work for basic collection in grizzly and havana
based OpenStack installs. Open vSwitch and network namespace collection
also added.
Conflicts:
sos/plugins/openstack.py
Signed-off-by: Brent Eagles <beagles@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |/
|/|
| |
| |
| |
| |
| |
| | |
The current default set of packages to verify includes debuginfo
and devel subpackages. Filter these out to reduce the time spent
running rpm -V.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Split out the Keystone and Horizon support from the main OpenStack
plug-in and put them in their own modules.
Signed-off-by: Jeremy Agee <jagee@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Older versions of the python runtime would add a newline to output
obtained via pipe.communicate(). Current versions do not leading
to output being stored in reports without a trailing newline
character.
Remove the workaround to ensure that stored content matches that
obtained via simple shell redirection ("/some/command > file").
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|/
|
|
|
|
|
|
|
|
|
| |
The networking module previously checked that its hard-coded path
for the brctl command existed before collecting output. This was
missed in the conversion to using policy defined PATH search for
external commands in commit e0d132e.
Similar problems were fixed in commits 8b10cb0, 374da99, 8883155.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an attempt is made to apply command output substitution via
Plugin.do_cmd_output_sub() and no output has been collected (i.e.
called['file'] == None) an exception is thrown by os.path.join().
The exception is also not logged properly due to an attempt in
the do_cmd_output_sub() exception handler to access an unbound
local variable (path - the exception occurs before it is
assigned).
Fix both of these by checking for an empty file entry and avoiding
access to the path variable from the exception handler.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the default policy object will exit without logging any
errors if an exception (e.g. EOF while reading line) is caught
during reads for interactive mode prompts.
Instead re-set the report name to a sane value (localname) and
attempt to continue.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 6ea48cbb introduced an isatty() check on stdin and
automatically sets batch mode if we're not attached to a TTY.
Although the logic of this seems simple enough the combination of
this and commit 4b46e04 breaks valid uses that have worked since
sos-1.x, e.g.:
Traceback (most recent call last):
File "/usr/sbin/sosreport", line 23, in <module>
main(sys.argv[1:])
File "/usr/lib/python2.7/site-packages/sos/sosreport.py", line 1171, in main
sos.execute()
File "/usr/lib/python2.7/site-packages/sos/sosreport.py", line 1133, in execute
self._setup_logging()
File "/usr/lib/python2.7/site-packages/sos/sosreport.py", line 630, in _setup_logging
self.opts.batch = True
File "/usr/lib/python2.7/site-packages/sos/sosreport.py", line 324, in batch
self._check_options_initialized()
File "/usr/lib/python2.7/site-packages/sos/sosreport.py", line 229, in _check_options_initialized
+ "from command line")
ValueError: SoSOptions object already initialized from command line
Given the actual semantics of --batch (do not prompt for or read
user input from stdin) there is no need to enable it if stdin is
a pipe or other non-TTY file descriptor.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|\
| |
| |
| |
| | |
Add new plugin for apt
Signed-off by: Adam Stokes <adam.stokes@ubuntu.com>
|
|/
|
|
| |
Closes #201
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Note: Changed original filename from openstack-heat.py to openstack_heat.py as
the plugin would fail to load with the original filename.
Closes #190
Signed-off-by: Jeff Peeler <jpeeler@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Closes #199
Signed-off-by: Eoghan Glynn <eglynn@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
| |
| |
| |
| | |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
| |
| |
| | |
Replace travis-ci status image with that of this upstream repo.
|
| |
| |
| |
| |
| | |
Signed-off-by: Flavio Percoco <fpercoco@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|\ \
| | |
| | | |
Split Swift out of openstack's plugin. #184
|
| |/
| |
| |
| | |
Signed-off-by: Flavio Percoco <flaper87@gmail.com>
|
|\ \
| | |
| | | |
Split Glance out of openstack's plugin
|
| |/
| |
| |
| | |
Signed-off-by: Flavio Percoco <flaper87@gmail.com>
|
|\ \
| |/
|/| |
import sys - Module sys is used but it is not imported.
|
|/
|
|
| |
Module sys is used but not imported.
|
|
|
|
|
|
|
|
|
|
| |
The semanage tool fails to write to a path within the temporary
report tree on some distributions due to an SELinux AVC denial.
Force the command to write data to stdout instead by passing
'-o -'.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a convenience method to construct an absolute path for
command output from a relative path or file name. This can be
used for e.g. to pass an output path to an external program that
produces output at a named path rather than on stdout and can be
used internally by the Plugin.make_cmd_dirs() method.
Convert the SELinux plug-in to use the new method when passing
output paths to the semanage command.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some plug-ins want to store command output in subdirectories of
their 'sos_commands/<plugin>/' directory. Currently there are
various hand-rolled methods to build this in different plug-ins.
Add a single method to the base Plugin class that builds the
correct path string and recursively creates the directories via
os.makedirs() in a single step.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The method to retrieve the path into which a plug-in's collected
command output returns a path as a string rather than a directory
object.
Make this clear by renaming the method to 'get_cmd_path()'.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|