| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
| |
This patch adds a new line to the github PR
template so users can assess that they have
obfuscated any password or similar from the
code they are submitting.
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
| |
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
|
|
|
| |
Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
|
|
|
|
|
|
|
|
|
| |
Added some missing files from /proc/fs/cifs and blacklist
some files that we don't need to capture.
Related: RH: RHEL-29707
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
|
|
|
|
| |
Add a note to the entries for --upload-user and --upload-pass
clarifying that these options have been deprecated
in RHEL systems.
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the file 'aap_controller.py' for the sos report collects
The files used for troubleshooting issues at
Ansible Automation Platform Automation Controller
Related: RH AAP-18409
Closes: #3561
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
|
|
|
|
|
|
| |
Update the check function
Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
|
|
|
|
|
|
|
|
|
|
| |
This commit is a first pass at addressing a number of the `Empty Except`
warnings flagged by CodeQL. These are for try/except blocks whose except
statement simply contains a `pass`, and to address these we add a log
message in almost all cases. Where we don't log, there is an added
comment for context as to why we're passing without further action.
Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
|
|
|
|
|
|
|
|
| |
Collect also processor ID assigned to the process (psr).
Resolves: #3575
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reduce_mac_match should strip all characters that cant appear in a MAC
address string. Currently it forgets to strip e.g. from
"mac:01:02:03:04:05" anything.
We should strip at least the 'm'. Ideally whole "mac" but that would be
programatically difficult to describe proper condition for that.
Resolves: #3574
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
| |
Continuation of #3530.
Likewise excludes C0114, C0115, and C0209.
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
|
|
|
| |
Signed-off-by: Jorge Rodríguez <jorge.rodriguez@canonical.com>
|
|
|
|
|
|
| |
when --all-logs is specified
Signed-off-by: Jorge Rodríguez <jorge.rodriguez@canonical.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SCL is not used in RHEL past RHEL 7, and sos has not directly supported
RHEL 7 for some years now due to the switch to python3 that came along
with sos-4.0.
Drop SCLPlugin, as it will never be used in modern sos. Cleanup any
references to it in existing plugins as well.
Resolves: #3559
Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Obfuscate OIDC client secret inside
/var/lib/config-data/puppet-generated/keystone/
etc/httpd/conf.d/10-keystone_wsgi.conf
The secret looks like this:
OIDCClientSecret "Password"
And after obfuscation, it will look like this:
OIDCClientSecret *********
Related: RH: RHEL-26720
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
| |
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the file 'aap_hub.py' for the sos report collects
the files used for troubleshooting issues at
Ansible Automation Platform Automation Hub
Related: RH AAP-19782
Closes: #3562
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently Ceph plugins do not take the `all-logs` flag
into account which means that even if this flag is set
compressed log files are not collected
This patch fixes that.
Resolves: SET-480
Signed-off-by: Alejandro Santoyo <alejandro.santoyo@canonical.com>
|
|
|
|
|
|
|
|
|
|
| |
convert2rhel now generates a post-conversion report as well as the
pre-conversion report. We want to be able to collect both reports during
sosreport execution. To make sure we are not missing them (or any other
future report we may introduce), the copy spec string was changed to use
a `*` instead of the names of the reports.
Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
|
|
|
|
|
|
|
|
|
| |
This will ensure that we have the right python version dependancy
for deb packages.
Resolves: SET-543
Signed-off-by: Arif Ali <arif.ali@canonical.com>
|
|
|
|
| |
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Currently we capture the output of 'ceph health detail'
in json format only, but we need plain text output
as well.
Related: RH RHEL-27525
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
|
|
| |
Closes: #3469
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A new option --skip-cleaning-files / --skip-masking-files allows cleaner
to skip cleaning files where the user is certain no sensitive information
is present.
The option supports globs / wildcards.
Relevant: #3469
Closes: #3520
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
| |
Signed-off-by: Drien Breton <drien.breton@orness.com>
|
|
|
|
|
|
|
|
|
| |
Automatically run foreman integration tests when their install script is
updated.
Relevant: #3555
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
A puppet regression in version 7.29.0 prevents foreman-installer to run.
Let prevent installing the buggy puppet-agent-7.29.0* .
Resolves: #3542
Closes: #3555
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are couple of instances (both on pacemaker) of
`parse_version` being used to compare the package
versions. In cases, notably on Ubuntu, where the version
comform to PEP440, this fails. So we now convert those
to PEP440 format before comparing.
Fixes #3548.
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
|
|
|
|
|
| |
Continuation of #3530.
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
|
|
|
|
|
|
| |
Prevously the lsblk would return single FSTYPE multiple times as I
forgot to add -s to it. Quick fix for this.
Signed-off-by: Lukas Herbolt <lukas@herbolt.com>
|
|
|
|
|
|
|
|
|
| |
Closes: #3552
Signed-off-by: Pablo Fernández Rodríguez <pafernan@redhat.com>
use f-strings
Signed-off-by: Pablo Fernández Rodríguez <pafernan@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Add new section fstype section under hardware devices which lists
devices by filesystem, based on lsbl -nrpo output. Devices with no
filesystem are placed into unknown section and Ext2/3/4 are put into
section called ext4.
Signed-off-by: Lukas Herbolt <lukas@herbolt.com>
|
|
|
|
|
|
|
|
|
| |
The sapconf command is not distributed in RHEL 8 and 9,
so the code is never executed, and its safe to remove.
Related: RH: RHEL-27830 and RHEL-27831
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ensure that we format the package versions to the pep440 standard.
This is necessary as we are using `parse_version()` from the `packaging`
package to verify that the sos collector node version is equal or bigger
than the versions we are collecting from the nodes. If we pass the wrong
format to `parse_version()`, we are unable to do the comparison and
unable to run `sos report` on those nodes.
This addresses the issue of the Ubuntu packaging version naming with `+`
and `~` signals as well as generic versioning schemes.
Resolves: #3544
Signed-off-by: David Negreira <david.negreira@canonical.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If no API url is specified, it will use
localhost always. In some cases, specially
when using Ansible, we'll want to specify
another API URL.
Related: RH: RHEL-24523
Closes: #3517
Co-authored-by: Alberto Losada Grande <alberto.losada@redhat.com>
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
| |
Continuation of #3530.
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
|
|
|
| |
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
|
|
|
|
|
|
|
|
|
| |
Collect useful info by executing some more commands in nfs-utils
package:
- nfsconf for the current configuration.
- mountstats for various NFS client statistics.
- rpcctl for SunRPC connection information.
Signed-off-by: Seiichi Ikarashi <s.ikarashi@fujitsu.com>
|
|
|
|
| |
Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
|
|
|
|
|
|
| |
Related: Discussion #3513
Signed-off-by: Arif Ali <arif.ali@canonical.com>
|
|
|
|
| |
Signed-off-by: David Negreira <david.negreira@canonical.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the project's effort to modernize on f-strings, this commit
replaces all usage of .format() with f-string equivalents. The vast
majority of these are in-place syntax changes, but a limited number
change the order of list items or some formatting tricks in order to
appease PEP8.
None of these conversions change the underlying logic of the flows they
appear in.
Related: #3472 discussion
Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
|
|
|
|
| |
Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
|
|
|
|
|
|
|
|
|
| |
Some parsers should skip strings <=3 length and some mappings should
obfuscate just full words.
Relevant: #3403
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As obfuscation of substrings of words is redundant and can lead to
leaking the secure string from the obfuscated word (e.g.
enobfuscateduser1ment), cleaner should match whole words only, in
relevant parsers/mappings.
Related: RHEL-2399
Resolves: #3403
Closes: #3496
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Obfuscation of entries like "map" or "po" is redundant and rather causes
user confusion and longer cleaner run.
Stop obfuscating those strings in relevant mappings (only).
Relevant: #3403
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Running various flatpak commands can start gvfs mount, which is
undesirable outcome of sos. Calling the commands with
GVFS_REMOTE_VOLUME_MONITOR_IGNORE=1 env.variable prevents that
behaviour.
Relevant: RHEL-14328
Closes: #3528
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
| |
Resolves: SET-463
Signed-off-by: Arif Ali <arif.ali@canonical.com>
|
|
|
|
| |
Signed-off-by: David Negreira <david.negreira@canonical.com>
|
|
|
|
| |
Signed-off-by: David Negreira <david.negreira@canonical.com>
|