aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* [github] Add check for data obfuscationJose Castillo2024-03-251-1/+2
| | | | | | | | | This patch adds a new line to the github PR template so users can assess that they have obfuscated any password or similar from the code they are submitting. Signed-off-by: Jose Castillo <jcastillo@redhat.com>
* [ceph_common] Collect info on microceph snapPonnuvel Palaniyappan2024-03-251-0/+7
| | | | Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
* [kernel] Copy the kernel configAadhar Agarwal2024-03-221-2/+3
| | | | Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
* [cifs] Capture missing files from /proc/fs/cifsJose Castillo2024-03-211-4/+6
| | | | | | | | | Added some missing files from /proc/fs/cifs and blacklist some files that we don't need to capture. Related: RH: RHEL-29707 Signed-off-by: Jose Castillo <jcastillo@redhat.com>
* [manpages] Add note about deprecation of options for RHELJose Castillo2024-03-201-0/+2
| | | | | | | | Add a note to the entries for --upload-user and --upload-pass clarifying that these options have been deprecated in RHEL systems. Signed-off-by: Jose Castillo <jcastillo@redhat.com>
* Implementing AAP Automation Controller PluginLucas Benedito2024-03-201-0/+88
| | | | | | | | | | | Adding the file 'aap_controller.py' for the sos report collects The files used for troubleshooting issues at Ansible Automation Platform Automation Controller Related: RH AAP-18409 Closes: #3561 Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
* [Plugin,Policy] Make an AzurePlugin class, Update the vendor url,Aadhar Agarwal2024-03-202-1/+10
| | | | | | Update the check function Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
* [global] Remove empty except warnings highlighted by CodeQLJake Hunsaker2024-03-195-11/+21
| | | | | | | | | | This commit is a first pass at addressing a number of the `Empty Except` warnings flagged by CodeQL. These are for try/except blocks whose except statement simply contains a `pass`, and to address these we add a log message in almost all cases. Where we don't log, there is an added comment for context as to why we're passing without further action. Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
* [process] ps output to collect also psr columnPavel Moravec2024-03-191-2/+2
| | | | | | | | Collect also processor ID assigned to the process (psr). Resolves: #3575 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [cleaner] Improve stripping raw MAC addressPavel Moravec2024-03-191-2/+2
| | | | | | | | | | | | | reduce_mac_match should strip all characters that cant appear in a MAC address string. Currently it forgets to strip e.g. from "mac:01:02:03:04:05" anything. We should strip at least the 'm'. Ideally whole "mac" but that would be programatically difficult to describe proper condition for that. Resolves: #3574 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [plugins] Fix Pylint and PEP8 issues - part4Ponnuvel Palaniyappan2024-03-1854-298/+301
| | | | | | | Continuation of #3530. Likewise excludes C0114, C0115, and C0209. Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
* [openstack_nova] Fixed the use of f-string reported by flake8Jorge Rodríguez2024-03-181-1/+1
| | | | Signed-off-by: Jorge Rodríguez <jorge.rodriguez@canonical.com>
* [openstack_nova] Added the collection of console.log from Nova instancesJorge Rodríguez2024-03-181-0/+1
| | | | | | when --all-logs is specified Signed-off-by: Jorge Rodríguez <jorge.rodriguez@canonical.com>
* [SCLPlugin] Drop SCLPlugin supportJake Hunsaker2024-03-177-137/+12
| | | | | | | | | | | | | SCL is not used in RHEL past RHEL 7, and sos has not directly supported RHEL 7 for some years now due to the switch to python3 that came along with sos-4.0. Drop SCLPlugin, as it will never be used in modern sos. Cleanup any references to it in existing plugins as well. Resolves: #3559 Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
* [openstack_keystone] Obfuscate OIDC client secretJose Castillo2024-03-161-2/+7
| | | | | | | | | | | | | | | | | | Obfuscate OIDC client secret inside /var/lib/config-data/puppet-generated/keystone/ etc/httpd/conf.d/10-keystone_wsgi.conf  The secret looks like this:   OIDCClientSecret "Password" And after obfuscation, it will look like this: OIDCClientSecret ********* Related: RH: RHEL-26720 Signed-off-by: Jose Castillo <jcastillo@redhat.com>
* [ceph/plugins] Add Microceph support for RGW and MDSPonnuvel Palaniyappan2024-03-164-69/+101
| | | | Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
* [aap_hub] Implementing AAP Automation Hub PluginLucas Benedito2024-03-131-0/+37
| | | | | | | | | | | Adding the file 'aap_hub.py' for the sos report collects the files used for troubleshooting issues at Ansible Automation Platform Automation Hub Related: RH AAP-19782 Closes: #3562 Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
* [ceph] Ensure `all-logs` is enforced for Ceph pluginsAlejandro Santoyo2024-03-137-26/+106
| | | | | | | | | | | | Currently Ceph plugins do not take the `all-logs` flag into account which means that even if this flag is set compressed log files are not collected This patch fixes that. Resolves: SET-480 Signed-off-by: Alejandro Santoyo <alejandro.santoyo@canonical.com>
* [convert2rhel] Update copy spec to include * reportRodolfo Olivieri2024-03-121-1/+3
| | | | | | | | | | convert2rhel now generates a post-conversion report as well as the pre-conversion report. We want to be able to collect both reports during sosreport execution. To make sure we are not missing them (or any other future report we may introduce), the copy spec string was changed to use a `*` instead of the names of the reports. Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
* [pkg][debian] Add python version dependancyArif Ali2024-03-121-0/+1
| | | | | | | | | This will ensure that we have the right python version dependancy for deb packages. Resolves: SET-543 Signed-off-by: Arif Ali <arif.ali@canonical.com>
* [nginx] Implementing files exclusions from AAP for nginxLucas Benedito2024-03-121-0/+12
| | | | Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
* [ceph_mon] Capture ceph health detail in plain textJose Castillo2024-03-121-0/+1
| | | | | | | | | | Currently we capture the output of 'ceph health detail' in json format only, but we need plain text output as well. Related: RH RHEL-27525 Signed-off-by: Jose Castillo <jcastillo@redhat.com>
* [tests] Add tests for cleaner's --skip-cleaning-filesPavel Moravec2024-03-111-3/+11
| | | | | | Closes: #3469 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [cleaner] Add option to skip cleaning filesPavel Moravec2024-03-1112-33/+67
| | | | | | | | | | | | | A new option --skip-cleaning-files / --skip-masking-files allows cleaner to skip cleaning files where the user is certain no sensitive information is present. The option supports globs / wildcards. Relevant: #3469 Closes: #3520 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [proxmox] Add new plugin for Proxmox Virtualization EnvironmentDrien Breton2024-03-091-0/+101
| | | | Signed-off-by: Drien Breton <drien.breton@orness.com>
* [cirrus] Run foreman tests on foreman_setup.sh changePavel Moravec2024-03-071-1/+1
| | | | | | | | | Automatically run foreman integration tests when their install script is updated. Relevant: #3555 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [tests] workaround puppet bug in foreman-installerPavel Moravec2024-03-071-0/+8
| | | | | | | | | | | A puppet regression in version 7.29.0 prevents foreman-installer to run. Let prevent installing the buggy puppet-agent-7.29.0* . Resolves: #3542 Closes: #3555 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [pacemaker] Use pep440 formatted version on comparisonPonnuvel Palaniyappan2024-03-075-32/+37
| | | | | | | | | | | | There are couple of instances (both on pacemaker) of `parse_version` being used to compare the package versions. In cases, notably on Ubuntu, where the version comform to PEP440, this fails. So we now convert those to PEP440 format before comparing. Fixes #3548. Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
* [plugins] Fix Pylint and PEP8 issuesPonnuvel Palaniyappan2024-03-0743-395/+424
| | | | | | Continuation of #3530. Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
* [report] Fix duplicate records returned by lsblk.Lukas Herbolt2024-03-071-1/+1
| | | | | | | Prevously the lsblk would return single FSTYPE multiple times as I forgot to add -s to it. Quick fix for this. Signed-off-by: Lukas Herbolt <lukas@herbolt.com>
* foreman plugin: Sort by started_at foreman_tasks_tasks tablePablo Fernández Rodríguez2024-03-051-9/+11
| | | | | | | | | Closes: #3552 Signed-off-by: Pablo Fernández Rodríguez <pafernan@redhat.com> use f-strings Signed-off-by: Pablo Fernández Rodríguez <pafernan@redhat.com>
* [report] Add new section fstype section under hardware devicesLukas Herbolt2024-03-051-1/+17
| | | | | | | | | Add new section fstype section under hardware devices which lists devices by filesystem, based on lsbl -nrpo output. Devices with no filesystem are placed into unknown section and Ext2/3/4 are put into section called ext4. Signed-off-by: Lukas Herbolt <lukas@herbolt.com>
* [sapnw] Remove capture of deprecated sapconf commandJose Castillo2024-03-051-9/+0
| | | | | | | | | The sapconf command is not distributed in RHEL 8 and 9, so the code is never executed, and its safe to remove. Related: RH: RHEL-27830 and RHEL-27831 Signed-off-by: Jose Castillo <jcastillo@redhat.com>
* [collect] refactor _format_versionDavid Negreira2024-03-041-13/+17
| | | | | | | | | | | | | | | Ensure that we format the package versions to the pep440 standard. This is necessary as we are using `parse_version()` from the `packaging` package to verify that the sos collector node version is equal or bigger than the versions we are collecting from the nodes. If we pass the wrong format to `parse_version()`, we are unable to do the comparison and unable to run `sos report` on those nodes. This addresses the issue of the Ubuntu packaging version naming with `+` and `~` signals as well as generic versioning schemes. Resolves: #3544 Signed-off-by: David Negreira <david.negreira@canonical.com>
* [collect|ocp] Add an option to specify API URLJose Castillo2024-03-041-3/+5
| | | | | | | | | | | | | | | If no API url is specified, it will use localhost always. In some cases, specially when using Ansible, we'll want to specify another API URL. Related: RH: RHEL-24523 Closes: #3517 Co-authored-by: Alberto Losada Grande <alberto.losada@redhat.com> Signed-off-by: Jose Castillo <jcastillo@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [plugins] Fix Pylint and PEP8 issuesPonnuvel Palaniyappan2024-03-0344-274/+277
| | | | | | Continuation of #3530. Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
* [plugins] Fix some PYLint and PEP8 issuesPonnuvel Palaniyappan2024-03-0138-118/+136
| | | | Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
* [nfs] Add nfsconf, mountstats, and rpcctl commandsSeiichi Ikarashi2024-03-011-0/+5
| | | | | | | | | | Collect useful info by executing some more commands in nfs-utils package: - nfsconf for the current configuration. - mountstats for various NFS client statistics. - rpcctl for SunRPC connection information. Signed-off-by: Seiichi Ikarashi <s.ikarashi@fujitsu.com>
* [docs] fix github urlCosta Shulyupin2024-02-251-1/+1
| | | | Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
* [pep8][tests] Update flake8 stylingArif Ali2024-02-237-48/+101
| | | | | | Related: Discussion #3513 Signed-off-by: Arif Ali <arif.ali@canonical.com>
* [libvirt] Capture virtlogd.confDavid Negreira2024-02-221-0/+1
| | | | Signed-off-by: David Negreira <david.negreira@canonical.com>
* [global] Replace use of `.format()` with f-stringsJake Hunsaker2024-02-2234-180/+143
| | | | | | | | | | | | | | | As part of the project's effort to modernize on f-strings, this commit replaces all usage of .format() with f-string equivalents. The vast majority of these are in-place syntax changes, but a limited number change the order of list items or some formatting tricks in order to appease PEP8. None of these conversions change the underlying logic of the flows they appear in. Related: #3472 discussion Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
* [build] Bump version to 4.7.0Jake Hunsaker2024-02-194-4/+13
| | | | Signed-off-by: Jake Hunsaker <jacob.r.hunsaker@gmail.com>
* [cleaner] add tests for short strings and incomplete wordsPavel Moravec2024-02-171-0/+11
| | | | | | | | | Some parsers should skip strings <=3 length and some mappings should obfuscate just full words. Relevant: #3403 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [cleaner] Skip obfuscation of substrings for some parsersPavel Moravec2024-02-175-2/+11
| | | | | | | | | | | | | As obfuscation of substrings of words is redundant and can lead to leaking the secure string from the obfuscated word (e.g. enobfuscateduser1ment), cleaner should match whole words only, in relevant parsers/mappings. Related: RHEL-2399 Resolves: #3403 Closes: #3496 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [cleaner] Skip obfuscation for short strings in some mappingsPavel Moravec2024-02-173-1/+5
| | | | | | | | | | | Obfuscation of entries like "map" or "po" is redundant and rather causes user confusion and longer cleaner run. Stop obfuscating those strings in relevant mappings (only). Relevant: #3403 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [flatpak] Prevent flatpak commands to mount gvfsPavel Moravec2024-02-161-2/+3
| | | | | | | | | | | | Running various flatpak commands can start gvfs mount, which is undesirable outcome of sos. Calling the commands with GVFS_REMOTE_VOLUME_MONITOR_IGNORE=1 env.variable prevents that behaviour. Relevant: RHEL-14328 Closes: #3528 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
* [microk8s] Add obfuscation for client.configArif Ali2024-02-151-0/+13
| | | | | Resolves: SET-463 Signed-off-by: Arif Ali <arif.ali@canonical.com>
* [Ubuntu] Change Ubuntu maintainerDavid Negreira2024-02-151-1/+1
| | | | Signed-off-by: David Negreira <david.negreira@canonical.com>
* [vectordev] Add new vectordev pluginDavid Negreira2024-02-151-0/+42
| | | | Signed-off-by: David Negreira <david.negreira@canonical.com>