| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two changes applied:
- drop printing IP address of a smart proxy
- add plugopt foreman.proxyfeatures that will trigger collecting features
of all smart proxies
Closes: #2424
Resolves: #2433
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes references to sosreport, to the
preferred 'sos report'. Also adds "SEE ALSO" consistently
for all man pages, and fixes a MAINTAINER line.
Resolves: #2432
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
"-l scterc" prints values and description of the SCT Error Recovery
Control settings.
Resolves: #2426
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The "/sys/block/sd*/device/timeout" and
"/sys/block/hd*/device/timeout" holds block device timeouts value in
seconds.
Resolves: #2425
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
| |
This commit represents the release of sos-4.1
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The candlepin plugin tries to read the PostgreSQL password from
/etc/candelpin/candlepin.conf, but will fallback to an empty string if one
isn't found.
This in turn causes psql to hang indefinitely (or at least until we hit
the plugin timeout).
Add `--no-password` to the psql command to not prompt for a password if
one isn't provided via another source.
Related: #2421
Resolves: #2422
Signed-off-by: Evgeni Golov <evgeni@golov.de>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The foreman plugin tries to read the PostgreSQL password from
/etc/foreman/database.yml, but will fallback to an empty string if one
isn't found.
This in turn causes psql to hang indefinitely (or at least until we hit
the plugin timeout).
Add `--no-password` to the psql command to not prompt for a password if
one isn't provided via another source.
Closes: #2421
Signed-off-by: Evgeni Golov <evgeni@golov.de>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The plugin didn't collect anything under /var/lib/rear,
it also didn't collect anything under /etc/rear/mappings.
Resolves: #2420
Signed-off-by: Ryan Blakley <rblakley@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
sbctl commands can only be run on a leader node, so gate the commands
from running on non-leader nodes with a SoSPredicate
Closes: #2418
Resolves: #2419
Signed-off-by: Edward Hope-Morley <edward.hope-morley@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'ubuntu-advantage' cli has been shorten to 'ua'
in version 19 and then symlink at package level
to make them both available for users as a
smooth transition.
While most stable Ubuntu releases are at version 19 and
onwards, others aren't yet. The idea is to prefer 'ua'
but fall back to the deprecated 'ubuntu-advantage' cli
as needed.
Resolves: #2417
Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, kerberos realms would not be obfuscated due to the
convention that those are written in all uppercase. While the parser
would match these, the hostname parser would not obfuscate them due to
the use of intermediary dicts that were case sensitive.
Now, match this convention and if it is found, obfuscate as a whole
domain rather than a potential FQDN with a hostname.
Closes: #2254
Resolves: #2416
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous commit bf622ae was to address an issue where the system's
hostname would not be obfuscated if the host plugin was not run for an
sos execution (provided that it was previously run at least once to
generate the initial obfuscation).
While this commit solved that particular problem, it injected the
domains into the "intermediary" dicts used by the mapping in a way that
meant after a certain number of further subsequent runs without the host
plugin, we'd end up duplicating our TLDs.
E.G. 'example.com' being obfuscated as 'obfuscatedomain0.com' would
eventually produce 'obfuscateddomain0.com.com'.
Correct this injection to ensure consistent obfuscation regardless of
the number of future executions without the host plugin.
Related: #2406
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The default timeout for all plugins is 300, but
the global timeout is set as -1 in the option list. This is
because this timeout is unset by default. This patch
attempts to clarify the -1 exposed to the user when using
commands like 'sos report -l', via the option description
as well as a note clarifying it in the man page.
Closes: #2003
Resolves: #2415
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Since these are collected in the pulp plugin directly.
Resolves: #2413
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch helps capture some missing files in the
gluster plugin, i.e.:
Files inside /var/lib/glusterd/glusterfind, like
*.status files, that store the required timestamps,
*.pem.pub files, that store ssh public keys.
We also need to omit the glusterfind_*_secret.pem,
which contains the openssh private key.
Files inside /var/lib/glusterd/.keys, that contains
*.pem.pub, the ssh public key.
Closes: RHBZ#1925035, RHBZ#1925419
Resolves: #2411
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit adds the ability for users to provide a text file with a
list of newline-delimited keywords that should be obfuscated, rather
than requiring all keywords be specified either by the `--keywords`
option or configuration file settings.
Files may be provided via the new `--keyword-file` option which is
available to `clean`, `collect`, and `report`.
Closes: #2401
Resolves: #2408
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
| |
Add list of packages enabling a plugin into plugins_overview.py .
Closes: #2404
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was discovered that if a report was generated without the host plugin
being run, then the hostname parser would not obfuscate the localhost
hostname or domain at all. This was due to the fact that while the
default_mapping values were being read into the parser's map's dataset
correctly, they weren't being loaded into the 'intermediary' dicts that
the parser uses to separate short names from domain names.
Fix this by reading the contents of the map's dataset dict (which is
populated by the map file) into those intermediary dicts that the parser
uses.
Additionally, safeguard against overloading domain and host obfuscation
numbers when loading this way by setting the respective counts to the
next-highest number after the map loading is complete.
Resolves: #2406
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Directory Server (389-ds-base), add the output from the DS's
healthcheck tool.
See https://bugzilla.redhat.com/show_bug.cgi?id=1688759
Resolves: #2403
Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The "mdadm -E" print contents of the metadata stored in devices. -E
applies to devices which are components of an array, where -D applies
to whole array.
Resolves: #2391
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extend the ovn-central and ovn-host plugins to include
logs from their respective applications. For ovn-central
extend to also include Load_Balancer, ACL and
Logical_Switch_Port nbdb tables.
Closes: #2409
Resolves: #2410
Signed-off-by: Edward Hope-Morley <edward.hope-morley@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
This patch updates scsi plugin to collect
additional logs for SCSI devices
Resolves: #2379
Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
This patch is to update powerpc plugin to collect
Hyper-V Network Virtualization information.
Resolves: #2379
Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
- add CSV output format to the script
- add distros and profiles info
- fix some formatting issues
Resolves: #2405
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move cleaner to ignore both sha256/md5s
Move collector to use sha256 as well.
Move to get hash from stdout
Resolves: #2351
Closes: #1204
Signed-off-by: Bryan Quigley <code@bryanquigley.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was found that if a system has `scl` available to it, and has a
non-scl package installed for a plugin that subclasses `SCLPlugin`, but
the scl packages are not installed, then the plugin will not be enabled
even for the non-scl collections.
This was due to a too-restrictive check if the plugin subclasses
`SCLPlugins` that prevented the normal plugin triggers from being
checked.
The future of Software Collections is uncertain to the sos project at
this time, but our current use of it is only 3 plugins; foreman,
postgresql, and redis.
As such, rather than splitting out `SCLPlugin` further into a distinct
separate subclass of a plugin and then having to deal with how to
determine which plugin class should be instantiated if both the scl and
non-scl plugin would otherwise be enabled, make the `SCLPlugin`
enablement conditions not prevent normal plugin enablement, and add
gates to the `_scl` methods provided by `SCLPlugin` to abort any
collection attempt if the specified scl is not detected.
If, at a later date, the project sees further (new) use of the
`SCLPlugin` then we can/will review this approach at that time.
Closes: #2407
Resolves: #2412
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The option 'cleaner' was not implemented
as an alias. This patch enables it for both
'sos report' and 'sos collect'.
Resolves: #2405
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When /etc/sos/cleaner directory is missing, cleaner fails to store
new default_mapping file due to:
[cleaner] Could not update mapping config file:
[Errno 2] No such file or directory: '/etc/sos/cleaner/default_mapping'
This patch adds the code to check the existence of the directory
and create it if necessary.
Resolves: RHBZ#1923937
Closes: #2393
Resolves: #2397
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When presets were split out from policies, they were not added to
`setup.py` in the list of packages. As such they would not be included
in any builds that relied upon using `setup.py` to generate a source
tarball.
Add those packages to the list so that they may be included.
Closes: #2390
Resolves: #2402
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The "/var/run/ovirt-hosted-engine-ha/vm.conf" is used as hosted-engine
configuration.
Resolves: #2399
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit alters several option long-form names or destination names
to align those values in a sensible way. This serves to not only remove
some abiguity in option naming in code, but also to make it so that the
"effective options" line logged in every sos execution can be direction
copy-pasted as a working command.
Closes: #2288
Resolves: #2398
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes sure that all passwords specified
in the opcion proxy_password in any file inside
/etc/yum.repos.d/ ends up masked in the sosreport.
Closes: #2394
Resolves: #2396
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Let's have a script that generates an overview of each plugin's
activity. I.e. for each plugin, print list of items the plugin collects
in add_copy_spec or add_cmd_output and other similar methods.
Resolves: #2392
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous change to package managers removed SuSE's manual settings
without actually having it use the new `RpmPackageManager` abstraction.
This in turn made almost any sos execution fail on SuSE.
Fix that, by instantiating the package manager.
Credit to fluxcap1 on GitHub for identifying this flaw and the
resolution.
Related: #2389
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This request adds the output of --showrc to sos
so we can verify the default values of options set
via rpmrc and macros config files.
Resolves: RHBZ#1921496
Resolves: #2388
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
It's useful to collect the `.registered` file as well to see if the Insights
client is actually registered (and if so, when).
Closes: #2372
Resolves: #2373
Signed-off-by: Paul Wayper <paulway@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
In Ubuntu CDK when the deployed with Keystone authentication the
service cdk.master.auth-webhook is deployed to handle that integration
this change includes this unit to collect its journal.
Resolves: #2387
Signed-off-by: Felipe Reyes <felipe.reyes@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The `files` property is used to determined if it's the kubernetes
master node is where the plugin is runnig since it's the only node
capable of running kubectl. In Ubuntu CDK environments the file that's
only available in the master is /root/cdk/cdk_addons_kubectl_config
while /root/cdk/kubeproxyconfig is also available in the workers.
Signed-off-by: Felipe Reyes <felipe.reyes@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The latter is a deprecated compat symlink.
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=979264
Resolves: #2385
Signed-off-by: Michael Biebl <biebl@debian.org>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
bcache is used as a caching device (typically an SSD) for
HDDs; bcache stats are useful to identify performance problems.
Closes: #2378
Resolves: #2384
Signed-off-by: Ponnuvel Palaniyappan <ponnuvel.palaniyappan@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved the file name from kexec-kdump.log to
the right one, kexec-dmesg.log and
added it to the list of files to gather via
add_copy_spec as per #1546.
Resolves: RHBZ#1817042
Resolves: #2386
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The plugin now collects information from certificates
that were generated by oVirt on the host(s)/node(s).
Related: RHBZ#1845877
Resolves: #2364
Signed-off-by: Lev Veyde <lveyde@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The plugin now collects information from certificates
that were generated by oVirt.
Related: RHBZ#1845877
Signed-off-by: Lev Veyde <lveyde@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Collect "tc -s filter show dev <DEV>" for each device.
Resolves: #2383
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Collect both devlink info and params, as well as details per each device.
Related to: #2383
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Enhancement to include details for the ovs ipsec monitor
daemon.
Resolves: #2382
Signed-off-by: Aaron Conole <aconole@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
From RHBZ:
The /etc/dasd.conf is the common configuration file for the dasd portion of s390,
similar to how /etc/multipath.conf is to multipath. It has settings like
failover timings, readonly settings, diag settings, etc. It's very useful to see
what the customer has set in this file when doing an initial analysis of s390 and
more specifically dasd (s390 storage) issues. It's also useful to have when
suggesting dasd tuning changes to the customer.
Related: RHBZ#1919277
Resolves: #2381
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Recent distros redirecting opal-prd logs to /var/log/opal-prd.log file.
Resolves: #2377
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
EEPROM dump collection might hang on specific types of devices, or
negatively impact the system otherwise. As a safe option, sos report
should collect the command when explicitly asked via a plugopt only.
Resolves: #2376
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleaning up references of --ticket-number, as it was fully replaced
by --case-id.
The credit goes to @mamatha4 .
Resolves: #2375
Relates to: #2374
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|