| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
For Directory Server (389-ds-base), add the output from the DS's
healthcheck tool.
See https://bugzilla.redhat.com/show_bug.cgi?id=1688759
Resolves: #2403
Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The "mdadm -E" print contents of the metadata stored in devices. -E
applies to devices which are components of an array, where -D applies
to whole array.
Resolves: #2391
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extend the ovn-central and ovn-host plugins to include
logs from their respective applications. For ovn-central
extend to also include Load_Balancer, ACL and
Logical_Switch_Port nbdb tables.
Closes: #2409
Resolves: #2410
Signed-off-by: Edward Hope-Morley <edward.hope-morley@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
This patch updates scsi plugin to collect
additional logs for SCSI devices
Resolves: #2379
Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
This patch is to update powerpc plugin to collect
Hyper-V Network Virtualization information.
Resolves: #2379
Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
- add CSV output format to the script
- add distros and profiles info
- fix some formatting issues
Resolves: #2405
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move cleaner to ignore both sha256/md5s
Move collector to use sha256 as well.
Move to get hash from stdout
Resolves: #2351
Closes: #1204
Signed-off-by: Bryan Quigley <code@bryanquigley.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was found that if a system has `scl` available to it, and has a
non-scl package installed for a plugin that subclasses `SCLPlugin`, but
the scl packages are not installed, then the plugin will not be enabled
even for the non-scl collections.
This was due to a too-restrictive check if the plugin subclasses
`SCLPlugins` that prevented the normal plugin triggers from being
checked.
The future of Software Collections is uncertain to the sos project at
this time, but our current use of it is only 3 plugins; foreman,
postgresql, and redis.
As such, rather than splitting out `SCLPlugin` further into a distinct
separate subclass of a plugin and then having to deal with how to
determine which plugin class should be instantiated if both the scl and
non-scl plugin would otherwise be enabled, make the `SCLPlugin`
enablement conditions not prevent normal plugin enablement, and add
gates to the `_scl` methods provided by `SCLPlugin` to abort any
collection attempt if the specified scl is not detected.
If, at a later date, the project sees further (new) use of the
`SCLPlugin` then we can/will review this approach at that time.
Closes: #2407
Resolves: #2412
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The option 'cleaner' was not implemented
as an alias. This patch enables it for both
'sos report' and 'sos collect'.
Resolves: #2405
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When /etc/sos/cleaner directory is missing, cleaner fails to store
new default_mapping file due to:
[cleaner] Could not update mapping config file:
[Errno 2] No such file or directory: '/etc/sos/cleaner/default_mapping'
This patch adds the code to check the existence of the directory
and create it if necessary.
Resolves: RHBZ#1923937
Closes: #2393
Resolves: #2397
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When presets were split out from policies, they were not added to
`setup.py` in the list of packages. As such they would not be included
in any builds that relied upon using `setup.py` to generate a source
tarball.
Add those packages to the list so that they may be included.
Closes: #2390
Resolves: #2402
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The "/var/run/ovirt-hosted-engine-ha/vm.conf" is used as hosted-engine
configuration.
Resolves: #2399
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit alters several option long-form names or destination names
to align those values in a sensible way. This serves to not only remove
some abiguity in option naming in code, but also to make it so that the
"effective options" line logged in every sos execution can be direction
copy-pasted as a working command.
Closes: #2288
Resolves: #2398
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes sure that all passwords specified
in the opcion proxy_password in any file inside
/etc/yum.repos.d/ ends up masked in the sosreport.
Closes: #2394
Resolves: #2396
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Let's have a script that generates an overview of each plugin's
activity. I.e. for each plugin, print list of items the plugin collects
in add_copy_spec or add_cmd_output and other similar methods.
Resolves: #2392
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous change to package managers removed SuSE's manual settings
without actually having it use the new `RpmPackageManager` abstraction.
This in turn made almost any sos execution fail on SuSE.
Fix that, by instantiating the package manager.
Credit to fluxcap1 on GitHub for identifying this flaw and the
resolution.
Related: #2389
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This request adds the output of --showrc to sos
so we can verify the default values of options set
via rpmrc and macros config files.
Resolves: RHBZ#1921496
Resolves: #2388
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
It's useful to collect the `.registered` file as well to see if the Insights
client is actually registered (and if so, when).
Closes: #2372
Resolves: #2373
Signed-off-by: Paul Wayper <paulway@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
In Ubuntu CDK when the deployed with Keystone authentication the
service cdk.master.auth-webhook is deployed to handle that integration
this change includes this unit to collect its journal.
Resolves: #2387
Signed-off-by: Felipe Reyes <felipe.reyes@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The `files` property is used to determined if it's the kubernetes
master node is where the plugin is runnig since it's the only node
capable of running kubectl. In Ubuntu CDK environments the file that's
only available in the master is /root/cdk/cdk_addons_kubectl_config
while /root/cdk/kubeproxyconfig is also available in the workers.
Signed-off-by: Felipe Reyes <felipe.reyes@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The latter is a deprecated compat symlink.
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=979264
Resolves: #2385
Signed-off-by: Michael Biebl <biebl@debian.org>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
bcache is used as a caching device (typically an SSD) for
HDDs; bcache stats are useful to identify performance problems.
Closes: #2378
Resolves: #2384
Signed-off-by: Ponnuvel Palaniyappan <ponnuvel.palaniyappan@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved the file name from kexec-kdump.log to
the right one, kexec-dmesg.log and
added it to the list of files to gather via
add_copy_spec as per #1546.
Resolves: RHBZ#1817042
Resolves: #2386
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The plugin now collects information from certificates
that were generated by oVirt on the host(s)/node(s).
Related: RHBZ#1845877
Resolves: #2364
Signed-off-by: Lev Veyde <lveyde@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The plugin now collects information from certificates
that were generated by oVirt.
Related: RHBZ#1845877
Signed-off-by: Lev Veyde <lveyde@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Collect "tc -s filter show dev <DEV>" for each device.
Resolves: #2383
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Collect both devlink info and params, as well as details per each device.
Related to: #2383
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Enhancement to include details for the ovs ipsec monitor
daemon.
Resolves: #2382
Signed-off-by: Aaron Conole <aconole@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
From RHBZ:
The /etc/dasd.conf is the common configuration file for the dasd portion of s390,
similar to how /etc/multipath.conf is to multipath. It has settings like
failover timings, readonly settings, diag settings, etc. It's very useful to see
what the customer has set in this file when doing an initial analysis of s390 and
more specifically dasd (s390 storage) issues. It's also useful to have when
suggesting dasd tuning changes to the customer.
Related: RHBZ#1919277
Resolves: #2381
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Recent distros redirecting opal-prd logs to /var/log/opal-prd.log file.
Resolves: #2377
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
EEPROM dump collection might hang on specific types of devices, or
negatively impact the system otherwise. As a safe option, sos report
should collect the command when explicitly asked via a plugopt only.
Resolves: #2376
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleaning up references of --ticket-number, as it was fully replaced
by --case-id.
The credit goes to @mamatha4 .
Resolves: #2375
Relates to: #2374
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Adds a new plugin for the TigerVNC plugin
Closes: #2347
Resolves: #2371
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Collecting whole /etc/postfix, we might collect some SSL keys placed
to this directory. Traverse main.cf to identify all such potential
files we must add to forbidden paths.
Resolves: #2362
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
It was found that some implementations will return a 530 rather than a
503 as the more specific error for incorrect passwords. Handle this
error code explicitly, and then also add a catch-all for any other
ftplib errors that may get raised.
Resolves: #2368
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Drops the `ps auxwww` collection in favor of the memory-sorted and
otherwise duplicate `ps auxwwwm` call, and updates the `ps` root symlink
to the memory-sorted output.
Related: #1969
Resolves: #2370
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The `-b` option to `lsof` is used to avoid kernel calls that have the
potential to block. However, this in turn strips useful information from
this collection when processes are using network resources like NFS
shares.
As we now have several layers of timeout control, it should be safe to
remove the `-b` option and instead apply a timeout to the
`add_cmd_output()` call to protect against a potential blocked call.
Closes: #2352
Resolves: #2670
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
"lsblk -O -P" provides all available column output in key pair
format.
Resolves: #2367
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
First fixes an issue with an improperly scoped setting of the sos
command label. Second, addresses an issue where the final sos command
determined wasn't being written to the node's metadata.
Resolves: #2363
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
sapconf command creates /etc/security/limits.d/99-sap-limits.conf
on its own when missing, so calling the command must be gated
by a predicate testing the file presence.
Resolves: #2361
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds policy-controlled forbidden path checking, which
should be the final part of implementing "global" forbidden paths. With
this commit, policies may now add paths and glob matches for paths which
should never be collected in any plugin.
Combined with plugin-defined paths and user-defined paths already
available, plugins should now be able to be properly restricted from
sensitive collections.
Note that the way this is implemented is that policies that define the
`set_forbidden_paths()` classmethod *extend* this forbidden list as it
is built from the subclass(es) that also define one. This way,
"top-level" policies do not need to maintain independent copies of
entire trees of paths just to add a few specific additional ones that
are not forbidden within other policies.
This initial commit adds paths that are either very well-known to be
ones we should avoid, or are paths that have previously been part of
reported issues where these paths/files should not be collected.
Closes: #316
Closes: #796
Closes: #919
Closes: #1316
Resolves: #2360
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "pidstat" command prints CPU time breakdowns per CPU
and, it can also print useful information from other
subsystems {I/O, MM} in a single line.
Related: RHBZ#1898155
Resolves: #2310
Signed-off-by: Jose Castillo <jose.mfcastillo@gmail.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Starting with Dogtag 10.9 a new logging framework is used. As a result,
debug logfiles now have the format 'debug-<date>' rather than just 'debug'.
Resolves: #2355
Signed-off-by: Thorsten Scherf <tscherf@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 7f72a36 requires self.sysroot to exist for each component,
but it is not set for sos-collector. Let pre-fill self.sysroot
every time.
Resolves: #2358
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, config file plugopts are ignored as we overwrite it
in apply_options_from_cmdline by empty list default value from
cmdline.
Resolves: #2359
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Updates the import of `RHELPolicy` for setting the python version
checking command on RHEL systems.
Related: #2349
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
| |
Adds the new packages to `setup.py` that were created as a result of the
policy re-org from #2349
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
"ls /sys/firmware" command is useful to check if system boots with
UEFI or BIOS.
Resolves: #2353
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ceph mons might get into time sync problems if ntp/chrony
isn't installed or configured correctly. Since Luminous
release, upstream support 'time-sync-status' to detect this
more easily.
Closes: #2356
Resolves: #2357
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Adds a new `DpkgPackageManager` subclass for use with dpkg-based
distributions.
Closes: #2349
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
|