| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Some openstack installations split out the configuration files
via an "include conf.d/*.cfg" directive. Add the whole directory
in order to collect that as well.
Fixes: #674.
Signed-off-by: Michele Baldessari <michele@acksyn.org>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
| |
Resolves: #697.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To avoid file creation races in shared temporary directories like
/tmp and /var/tmp use a private (0700) subdirectory to build the
FileCacheArchive and subsequent archive and compressed archive
files: only create a file in the containing directory when it can
be done as a single atomic rename.
This prevents sos from writing to an arbitrary location under the
control of another user: a malicious user could steal data or over
write files in /etc resulting in a local privilege escalation.
There remains a further race since once the archive name is known
the checksum file name becomes predictable: as the checksum file
is also prepared in the subdirectory and moved into place the
result is always either success or an error that is reported to
the user.
The correct checksum value is still reported to the user via the
terminal.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although the digest algorithm is policy controlled the actual
mechanism to checksum the archive does not belong in the policies
module: historically this was done to keep the code that calculates
the checksum close to the UI code that reports it.
Move the calculation to the main SoSReport class's final_work()
method and add a 'checksum' argument to the display_results()
method so that the value can be reported.
In future it may make sense to push the checksum code directly into
the archive class.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Pass explicit archive and build directory arguments to the
Policy.display_results() method rather than a single path name
argument and a boolean to indicate whether it is an archive file
or a build directory path.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's crazy having the Policy classes call a function in the
utilities module only to have that function then load the Policy
module, call policy.get_preferred_hash_algorithm() and then test
the result.
Get rid of the get_hash_name() function in the utilities module
and simplify the calls in the policies module to obtain the
preferred hash name.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Collect the two directories without some forbidden paths.
Reorder self.add_forbidden_path(..) to have some logical ordering there.
Resolves: #693
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
| |
|
| |
|
|
|
|
|
|
| |
Closes: #663.
Signed-off-by: Jeremy Crafts <jcrafts@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test for a symlink already existing would fail if the symlink
target did not exist; this will be the case when a symlink points
to a directory (which is not copied).
Fix up to use os.lexists instead.
Closes: #660
Closes: #661
Signed-off-by: jan grant <jang@ioctl.org>
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Resolves #446
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Resolves #445
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Resolves #444
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Resolves #443
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Resolves #442
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Resolves #441
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Resolves #440
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Resolves #448
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
1699eabd partially renamed various OpenStack plugin classes but
was not complete when it was pulled in leading to various
openstack plugins failing during setup.
Resolves: #655
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Needed when investigating slab related issue to identify
how slabs are merged together. ls -lt shows symlink of
merged slabs.
Closes: #653, #654.
Signed-off-by: Louis Bouchard <louis.bouchard@canonical.com>
|
|
|
|
|
|
|
|
|
| |
Merged identical code into one loop iterating over
["ssl-certificate", "ssl-key", "ssl-trustfile"].
Added authorship.
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When content is coming from the output of the tail()
method, it is a bytes in python3 and a string in python2.
Force the bytes value to be decoded otherwise the later
write() function will fail and nothing will be written to
the file.
Conditional decoding is necessary as the strings in python3
do not have a decode method.
Closes #586
Signed-off-by: Louis Bouchard <louis.bouchard@canonical.com>
|
|
|
|
|
|
|
| |
When add_string receives output from tail() it fails in py3
since tail() returns a byte object. Mimic this behavior.
Signed-off-by: Louis Bouchard <louis.bouchard@canonical.com>
|
|
|
|
|
|
|
|
|
| |
Adding two services openstack-sahara-api and openstack-sahara-engine
with required "-api + -engine" RPM package.
Fixes: #641.
Signed-off-by: Poornima M. Kshirsagar pkshiras@redhat.com
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Four options added:
- port for specifying non-default listening port (sometimes necessary
also for SSL)
- ssl-certificate and ssl-key for SSL
- ssl as rather auxiliary option to force qpid-* tools to use SSL even
without ssl-* options specified
Resolves: #634, #635
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
|
|
| |
Commands "qpid-config exchanges" and "qpid-config queues" lack comma in
the list. That causes the commands are not collected by sosreport and
executed.
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
|
|
|
|
|
|
| |
Fixes: #609.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
Drop the '-r' when obtaining logs from journald to be consistent
with other plugins: users can sort log entries in whatever order
they prefer on the analysis system.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also introduce the global all_logs and log_size options within the
plugin. Allowing users to control when all logs are collected and
limit the overall size of the logs collected.
Resolves #447
Closes #647
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ignore files from plugins such as tuskar [1] that can also be
found in the `/etc/openstack-dashboard/` directory.
[1] https://github.com/openstack/tuskar-ui
Closes #645
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New plugin to collect valuable information for Qpid Dispatch
Collects /etc/qpid-dispatch/qdrouterd.conf and output of qdstat -[a|n|c|m].
Allows passing arguments for Dispatch listening port and SSL stuff.
Resolves: #623
Closes #624
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Collect monit status, action logs and configuration files.
Usernames (in addition to passwords and other secrets) are removed since
they may contain information such as email addresses considered
sensitive by users.
Closes #573
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
| |
Resolves #551
Closes #568
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
opts.report is True regardless of using --no-report option or not. That
means the test "if not self.opts.report:" to decide generation of
reports is evaluated to False every time and no report is generated any
time.
This commit renames opts.report and SoSOptions._report to noreport (to
get rid of the variable name confusion) and updates default value
accordingly.
Resolves #625
Closes #644
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
|
| |
There is currently no way to see the system timezone in text format on
a systemd system (eg: "America/New_York"). timedatectl provides this.
Closes #611
Signed-off-by: Jamie Bainbridge <jbainbri at redhat dot com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As more applications are beginning to use namespaces, notably OpenStack
and container-based platforms, capturing namespace data is becoming
essential.
This patch alters the networking plugin so that it is namespace aware,
collecting commands such as:
$ ip address show
$ ip route
$ iptables-save
For each individual namespace, along with per-device ethtool
information for any devices that exist in said namespaces.
Closes #642
Signed-off-by: Robb Manes <rmanes@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
| |
Closes #578
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
|
|
|
|
|
|
|
| |
Resolves #553
Closes #569
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
| |
Expand the test coverage for Python 3.5 and
nightly build runtimes.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This plugin is for Atomic Host systems.
By default it will capture host status and ostree configuration.
With the 'info' option it will collect 'atomic info' for unique images.
Closes #549
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we grep for "mangle", both ipv4 and ipv6 versions might come up.
This patch ensure that the right version is considered.
Also, do the same we do for ipv4, but for ipv6.
Filter, Mangle, NAT and exact counters.
Closes #630
Signed-off-by: Germano Veit Michel <germano@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
|
| |
The new commands added to gluster in the recent release were
missing. this commit is to add those commands to the plugin.
Closes #633
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|