aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [plugin] remove debug code from Plugin.get_description()Bryn M. Reeves2014-07-071-3/+2
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] make archive debug logging depend on --debugBryn M. Reeves2014-07-072-1/+8
| | | | | | | | | | This significantly reduces log noise at maximum verbosity. Users needing the interactive debugger can either use less verbosity (-v) or put up with the flood of messages. Fixes #319. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] Use superclass __doc__ if not defined in derived classBryn M. Reeves2014-07-071-3/+6
| | | | | | Fixes #320. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [openshift] remove cgroups collectionBryn M. Reeves2014-07-071-1/+0
| | | | | | | | The openshift plugin used an obsolete cgroups path ("/cgroups"). Since the cgroups plugin now collects full information on all configured cgroups remove this from the openshift plugin. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [global] clean up formatting and remove obsolete pylint pragmasBryn M. Reeves2014-07-075-59/+23
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] kill Plugin.option_enabled()Bryn M. Reeves2014-07-076-12/+8
| | | | | | | Has been deprecated for years. Kill it and replace the remaining uses with Plugin.get_option(). Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] add simple collect() profilingBryn M. Reeves2014-07-071-0/+3
| | | | | | | | | | | | | Similar to commit fd68a0c; add support for outputing messages indicating the time taken to call collect() for each plugin: [...] [plugin:systemtap] collected plugin 'systemtap' in 16.8759040833 [plugin:systemd] collected plugin 'systemd' in 19.5138418674 [plugin:block] collected plugin 'block' in 40.066119194 [plugin:yum] collected plugin 'yum' in 101.271748066 Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive, plugin] handle special file system nodesBryn M. Reeves2014-07-042-4/+36
| | | | | | | | | | Historically sos has ignored all types of file system node that are not regular files or directories. Add support for collecting block, character, fifo and socket special nodes by creating matching nodes in the archive and propagating permissions from the host file system. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] log directory contents added via Plugin.copy_dir()Bryn M. Reeves2014-07-021-2/+4
| | | | | | | | | | | | | | | | | We're currently very verbose about the copyspecs and path lists we process during setup() and collect() but right now we do not log the same level of information for artefacts that are included in the archive as a consequence of Plugin.do_copy_path() calling copy_dir() on the result of copyspec expansion. Log these explicitly and promote logging of copyspec expansion to match that used for command logging. This makes us very chatty at high verbosity but allows a clean view of exactly what the tree walking code is doing (which my sanity desperately needs). Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [megacli] new plugin for LSI MegaRAID based adaptersJon Magrini2014-07-021-0/+39
| | | | | | | | | | The MegaCLI utility is a proprietary utility provided by LSI which can perform reporting and management functions for MegaRAID SAS|SCSI adapters. If the MegaCLI is detected, the plugin will collect basic information such as adapter status, firmware rev, battery status, and raid config. Signed-off-by: Jon Magrini <jmagrini@redhat.com>
* [plugin] python3 exception lists must be tuplesBryn M. Reeves2014-07-021-1/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] handle lstat exceptions in do_copy_path()Bryn M. Reeves2014-07-011-1/+5
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [libvirt] add missing os importBryn M. Reeves2014-07-011-0/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Use lstat() in do_copy_path and check for char and block devicesBryn M. Reeves2014-07-011-15/+16
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [libvirt] restrict configuration and log collectionBryn M. Reeves2014-07-011-2/+31
| | | | | | | | Collect specific libvirt configuration and log files by glob instead of scoopting up whole directories from /etc and /var and add blacklisting for the libvirt SASL authentication databases. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [s390] remove "find /sys" from pluginBryn M. Reeves2014-07-011-1/+0
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [s390,kernel] move /proc/misc collection to kernel pluginBryn M. Reeves2014-07-012-1/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] fix unicode vs. byte array handling in string IOBryn M. Reeves2014-06-301-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Causes a nosetests failure on python3: ====================================================================== ERROR: test_glob_file_over_limit (plugin_tests.AddCopySpecTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/breeves/src/git/sos/tests/plugin_tests.py", line 269, in test_glob_file_over_limit self.mp.add_copy_spec_limit("/tmp/tmp*", 1) File "/home/breeves/src/git/sos/sos/plugins/__init__.py", line 414, in add_copy_spec_limit self.add_string_as_file(tail(_file, sizelimit), strfile) File "/home/breeves/src/git/sos/sos/plugins/__init__.py", line 520, in add_string_as_file content = "..." + content.splitlines()[0] TypeError: Can't convert 'bytes' object to str implicitly ====================================================================== ERROR: test_single_file_over_limit (plugin_tests.AddCopySpecTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/breeves/src/git/sos/tests/plugin_tests.py", line 253, in test_single_file_over_limit self.mp.add_copy_spec_limit(fn, 1) File "/home/breeves/src/git/sos/sos/plugins/__init__.py", line 414, in add_copy_spec_limit self.add_string_as_file(tail(_file, sizelimit), strfile) File "/home/breeves/src/git/sos/sos/plugins/__init__.py", line 520, in add_string_as_file content = "..." + content.splitlines()[0] TypeError: Can't convert 'bytes' object to str implicitly ---------------------------------------------------------------------- Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] only print a summary of strings added to the archiveBryn M. Reeves2014-06-301-1/+2
| | | | | | | | | | When we're using add_string_as_file() to add tailed file contents to the archive the string may contain many thousands of lines. Only print a summary snippet showing the last line to avoid spamming entire log files to the terminal in -vv mode. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [sar] fix directory list variable nameBryn M. Reeves2014-06-301-1/+1
| | | | | | | | | | | | | | | | One dirList was missed in commit d4ebd07: Traceback (most recent call last): File "/usr/sbin/sosreport", line 23, in <module> main(sys.argv[1:]) File "/usr/lib/python2.7/site-packages/sos/sosreport.py", line 1229, in main sos.execute() NameError: global name 'dirList' is not defined > /usr/lib/python2.7/site-packages/sos/plugins/sar.py(67)setup() -> if sar_filename not in dirList: Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [powerpc] collect selected file instead of entire directoryBryn M. Reeves2014-06-301-2/+3
| | | | | | | | | | | | | | | | We are collecting powerpc dir from debugfs which is causing some issues.. Also we don't need that dir data for debugging purpose... Hence removing that file. Also collecting selected files from /proc/ppc64 directory instead of collecting entire directory. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com> --- sos/plugins/powerpc.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
* [openshift] Get SELinux labels and add verbosityPep Turro Mauri2014-06-261-2/+2
| | | | Signed-off-by: Pep Turró Mauri <pep@redhat.com>
* [openshift] Remove 1.x-specific and add more filesPep Turro Mauri2014-06-261-3/+6
| | | | | | Collect websocket proxy logs and broker/console httpd conf Signed-off-by: Pep Turró Mauri <pep@redhat.com>
* [openshift] Remove more redundant data collectionPep Turro Mauri2014-06-261-3/+0
| | | | Signed-off-by: Pep Turró Mauri <pep@redhat.com>
* [openshift] Fix syntax errorPep Turro Mauri2014-06-261-2/+2
| | | | Signed-off-by: Pep Turró Mauri <pep@redhat.com>
* Add SSL logs to apache plugin and reduce log size limitsBryn M. Reeves2014-06-261-2/+4
| | | | | | | | Add the 'ssl_access_log' and 'ssl_error_log' files to the default apache log collection and reduce the sizelimit passed to add_copy_spec_limit() from 15M to 5M. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Add OpenShift node httpd logs to OpenShift pluginBryn M. Reeves2014-06-261-4/+5
| | | | | | | | | | The OpenShift node environment adds a new Apache log at: /var/log/httpd/openshift_log Capture it in the OpenShift plugin. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Use glob to match /etc/openshift-enterprise-{release,version}Bryn M. Reeves2014-06-261-1/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Remove bundler commands from OpenShiftBryn M. Reeves2014-06-261-3/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Default to collecting current logs in apache pluginBryn M. Reeves2014-06-261-0/+7
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Fix typo in ActiveMQ plugin commentBryn M. Reeves2014-06-261-1/+1
| | | | | | | ActiveMQ was cloned from MongoDB. Fix the comment to refer to the correct component. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Fix typo in mongodb pluginBryn M. Reeves2014-06-261-1/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Make OpenShift broker vs. node detection automaticBryn M. Reeves2014-06-261-3/+12
| | | | | | | | Enable broker and node data collection by detecting the respective configuration files and automatically collect files and command output for the components present. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Add MongoDB pluginBryn M. Reeves2014-06-262-1/+48
| | | | | | | | | | Add a plugin for the MongoDB document database: https://www.mongodb.org/ Remove MongoDB log collection from the OpenShift plugin. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Add ActiveMQ pluginBryn M. Reeves2014-06-262-1/+29
| | | | | | | | | | Add a plugin for the Apache ActiveMQ messaging server: http://activemq.apache.org/ Remove ActiveMQ log collection from the OpenShift plugin. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Make vendor and ruby version class variables in OpenShift pluginBryn M. Reeves2014-06-261-1/+4
| | | | | | | Allow the vendor path and ruby version to be overridden by subclasses without needing to duplicate code. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Remove redundant data collection from OpenShift pluginBryn M. Reeves2014-06-261-2/+0
| | | | | | | | OpenShift collects dhclient configuration and Apache httpd logs. These are already handled by their respective plugins; remove them from the OpenShift module. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [openshift] Fixing a no longer needed line.Eric Rich2014-06-261-1/+0
|
* [openshift] Adding 2.0 files and commands.Eric Rich2014-06-261-10/+13
|
* [tomcat] update for tomcat6 and add password filteringBryn M. Reeves2014-06-231-3/+10
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [filesys] collect dumpe2fs -h output by defaultBryn M. Reeves2014-06-231-4/+6
| | | | | | Fixes #297. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [rpm] reduce number of calls to rpmBryn M. Reeves2014-06-231-3/+4
| | | | | | Fixes #300. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [mysql] add all_logs optionBryn M. Reeves2014-06-231-1/+7
| | | | | | | Add an 'all_logs' option to the MySQL / MariaDB plugin to allow the old behaviour of collecting all logs files to be requested. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [mysql] make sure db credentials are not part of dump file nameBryn M. Reeves2014-06-231-1/+2
| | | | | | | | Since we pass --user and --password on the mysqldump command line we need to use suggest_filename to prevent those values appearing in report paths. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [mysql] add optional database dump supportBryn M. Reeves2014-06-231-0/+11
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [mysql] limit log collection and add support for MariaDBBryn M. Reeves2014-06-231-7/+16
| | | | | | | | | | Add support for the MariaDB fork of MySQL. Since a MySQL or MariaDB instance may have very large log files under /var/log/{mysql,mariadb}. For now restrict log collection to the main demon log. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [mysql] clean up plugin variable use and package listsBryn M. Reeves2014-06-231-6/+12
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [anaconda] elide passwords in kickstart user directivesBryn M. Reeves2014-06-211-3/+10
| | | | | | | | E.g.: useradd --password '$6$oIW3o2Mr$XbWZKaM7nA.cQqudfDJScupXOia5h1u517t6Htx/Q/MgXm82Pc/OcytatTeI4ULNWOMJzvpCigWiL4xKP9PX4.' test Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [distupgrade] elide passwords in /root/preupgradeBryn M. Reeves2014-06-211-1/+18
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [ipa] add ipa-replica-manage outputBryn M. Reeves2014-06-211-0/+5
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>