aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [gluster] tidy up add_copy_spec() usageBryn M. Reeves2014-07-311-15/+12
| | | | | | | | The gluster plugin has a pile of fragmented add_copy_spec() calls. Consolidate them into as few add_copy_specs() calls as possible and remove the cargo-cult positioning of logs at the end. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Collect local FirewallD XML configjbainbri2014-07-311-0/+3
| | | | FirewallD looks for config files for icmptypes, zones, and services in /etc/firewalld/ and if none are found, falls back to /usr/lib/firewalld/. This way, changes made on the system are stored under /etc which overrides the default.
* [sosreport] make pep8 happyAdam Stokes2014-07-311-184/+220
| | | | | | | | | There were a ton of violations as far as pep8 is concerned. Corrected all of these in this particular file. There were even a few incorrect comparison syntax within the checking of particular plugin options that were corrected as well. Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
* [sosreport] remove module commentAdam Stokes2014-07-311-1/+0
| | | | | | | This is part of an effort to cleanup syntax throughout the entire python codebase. Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
* [rpm] reduce verify timeout to 180sBryn M. Reeves2014-07-311-1/+1
| | | | | | | | | | | | | | The initial rpm verify timeout was set to 3600s (one hour). This is insane; if a verify has not completed in that time then it's unlikely that it ever will. With the current set of verify patterns the total time taken in rpm (including both the verify and all other runs, e.g. policy initialisation) is under 60s on all my test hosts (bare metal and virtual). Allow a factor of three over this figure and set the timeout to 180s. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [pcp] use socket.gethostname() instead of shelling outBryn M. Reeves2014-07-311-8/+2
| | | | | | | | | | There's no need to take a fork to retrieve the system host name. Use the socket.gethostname() function instead (plugins also have no businness importing things from sos.utilities directly - all the useful functions in there have wrapper methods in the Plugin class, e.g. call_ext_prog(), check_ext_prog() etc.). Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [ldap] add output of 'certutil -L'Bryn M. Reeves2014-07-181-0/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [ldap] add more forbidden paths and restrict file collectionBryn M. Reeves2014-07-181-2/+9
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [ds] add 'certutil -L' collection for slapd instancesBryn M. Reeves2014-07-181-0/+9
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [ds] exclude paths containing directory server secretsBryn M. Reeves2014-07-181-1/+14
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [docs] Improve README.md formattingBryn M. Reeves2014-07-151-4/+6
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [docs] update README.mdBryn M. Reeves2014-07-151-10/+37
| | | | | | | Update README.md for the new repository URL and add links to a couple of new wiki pages. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] remove python2 debug code from classBryn M. Reeves2014-07-151-1/+0
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [general] delete UbuntuGeneral and incorporate into GeneralBryn M. Reeves2014-07-151-9/+3
| | | | | | | | The UbuntuGeneral plugin just collects '/etc/os-release' which is not specific to Ubuntu distributions. Move it to the General class itself and delete the child class. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [docs] document -z, --compression-type in sosreport(1)Bryn M. Reeves2014-07-101-0/+5
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [sosreport,archive] fix command line compression method selectionBryn M. Reeves2014-07-102-5/+14
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [megacli] add new command and switch to add_copy_specsBryn M. Reeves2014-07-091-3/+9
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [logrotate] list style fixesBryn M. Reeves2014-07-081-1/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [libraries] option_list style fixesBryn M. Reeves2014-07-082-5/+8
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [ldap] list style fixesBryn M. Reeves2014-07-081-4/+10
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [infiniband] list style fixesBryn M. Reeves2014-07-081-1/+2
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [i18n] list style fixesBryn M. Reeves2014-07-081-1/+4
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [foreman] string building style fixesBryn M. Reeves2014-07-081-2/+3
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [emc] list style fixesBryn M. Reeves2014-07-081-3/+6
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [ds] list style fixesBryn M. Reeves2014-07-081-2/+4
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [dmraid] option_list style fixesBryn M. Reeves2014-07-081-3/+3
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [dhcp] style fixesBryn M. Reeves2014-07-081-1/+2
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [cs] list style fixesBryn M. Reeves2014-07-081-14/+20
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [cluster] list and function style fixesBryn M. Reeves2014-07-081-20/+36
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [ceph] option_list style fixesBryn M. Reeves2014-07-081-7/+11
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [boot] option_list style fixesBryn M. Reeves2014-07-081-3/+3
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [azure] list style fixesBryn M. Reeves2014-07-081-5/+7
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [autofs] make package verification depend on --verifyBryn M. Reeves2014-07-081-1/+2
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [auditd] style fixesBryn M. Reeves2014-07-081-0/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [apt] list style fixesBryn M. Reeves2014-07-081-1/+3
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [apache] option_list style fixesBryn M. Reeves2014-07-081-3/+7
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [anaconda] list style fixesBryn M. Reeves2014-07-081-6/+10
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [abrt] option_list style fixesBryn M. Reeves2014-07-081-2/+3
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [systemd] add journalctl --list-boots outputBryn M. Reeves2014-07-081-0/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [gluster] log killall failures at info levelBryn M. Reeves2014-07-081-1/+1
| | | | | | | | Failing to send a signal to the gluster daemons will happen on any system with gluster installed but not running; don't log it at warning level. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [openshift] Improve password obfuscationPep Turro Mauri2014-07-081-8/+19
| | | | | | | | | | | Rewrite MCollective passwords and be a bit more flexible with white space around =. Also provide examples of strings for the string substitutions. Related: #323. Signed-off-by: Pep Turró Mauri <pep@redhat.com>
* [openshift] Don't collect all of /etc/openshiftPep Turro Mauri2014-07-081-6/+10
| | | | | | Reduce glob based collection and aim at more specific paths. Signed-off-by: Pep Turró Mauri <pep@redhat.com>
* [sosreport] improve description of --buildBryn M. Reeves2014-07-081-1/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] implement global --log-size optionBryn M. Reeves2014-07-089-35/+28
| | | | | | | | | | | | | Implement a global '--log-size' option that causes all plugins implementing log size limiting (via add_copy_spec_limit()) to apply the specified value as the size limit. Convert the auditd, cups, logs, nscd, rabbitmq, squid, and upstart plugins to use the new option. Fixes #306. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] implement global --all-logs optionBryn M. Reeves2014-07-089-20/+32
| | | | | | | | | | | | | | | | | Implement a global '--all-logs' option that causes all active plugins to attempt to collect all logs present regardles of rotation or size limiting. This replaces the numerous per-plugin 'all_logs' options and avoids the need for clumsy command lines like: -k audit.all_logs,cron.all_logs,logs.all_logs,pcp.all_logs,... The audit, cron, cups, libvirt, logs, mysql, and pcp plugins have been converted to use the new option. Fixes #305. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [openswan] document that 'ipsec verify' is not costlyBryn M. Reeves2014-07-071-0/+3
| | | | | | | | | Although it's a 'verification' this is just a simple configuration test of the environment; it typically completes in <1s. Related: #304. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [rpm] do not perform rpm -V unless --verify is givenBryn M. Reeves2014-07-071-12/+14
| | | | | | Related: #304. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [systemd] do not verify journal unless --verify is givenBryn M. Reeves2014-07-071-1/+3
| | | | | | Related: #304. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] implement global --verify optionBryn M. Reeves2014-07-072-0/+22
| | | | | | | | | | | | | Introduce a mechanism to allow plugins selective access to global command line options via the standard Plugin.get_option() method. Use this to implement a global --verify that plugins can test to determine whether or not to execute potentially costly verify operations. Related: #304. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] remove debug code from Plugin.get_description()Bryn M. Reeves2014-07-071-3/+2
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>