| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
The gluster plugin has a pile of fragmented add_copy_spec() calls.
Consolidate them into as few add_copy_specs() calls as possible
and remove the cargo-cult positioning of logs at the end.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
FirewallD looks for config files for icmptypes, zones, and services in /etc/firewalld/ and if none are found, falls back to /usr/lib/firewalld/. This way, changes made on the system are stored under /etc which overrides the default.
|
|
|
|
|
|
|
|
|
| |
There were a ton of violations as far as pep8 is concerned. Corrected all of
these in this particular file. There were even a few incorrect comparison
syntax within the checking of particular plugin options that were corrected as
well.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
| |
This is part of an effort to cleanup syntax throughout the entire python
codebase.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The initial rpm verify timeout was set to 3600s (one hour). This
is insane; if a verify has not completed in that time then it's
unlikely that it ever will. With the current set of verify
patterns the total time taken in rpm (including both the verify
and all other runs, e.g. policy initialisation) is under 60s on
all my test hosts (bare metal and virtual).
Allow a factor of three over this figure and set the timeout to
180s.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
There's no need to take a fork to retrieve the system host name.
Use the socket.gethostname() function instead (plugins also have
no businness importing things from sos.utilities directly - all
the useful functions in there have wrapper methods in the Plugin
class, e.g. call_ext_prog(), check_ext_prog() etc.).
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
Update README.md for the new repository URL and add links to a
couple of new wiki pages.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
The UbuntuGeneral plugin just collects '/etc/os-release' which is
not specific to Ubuntu distributions. Move it to the General class
itself and delete the child class.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
Failing to send a signal to the gluster daemons will happen on
any system with gluster installed but not running; don't log it
at warning level.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Rewrite MCollective passwords and be a bit more flexible with
white space around =.
Also provide examples of strings for the string substitutions.
Related: #323.
Signed-off-by: Pep Turró Mauri <pep@redhat.com>
|
|
|
|
|
|
| |
Reduce glob based collection and aim at more specific paths.
Signed-off-by: Pep Turró Mauri <pep@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement a global '--log-size' option that causes all plugins
implementing log size limiting (via add_copy_spec_limit()) to
apply the specified value as the size limit.
Convert the auditd, cups, logs, nscd, rabbitmq, squid, and
upstart plugins to use the new option.
Fixes #306.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement a global '--all-logs' option that causes all active
plugins to attempt to collect all logs present regardles of
rotation or size limiting. This replaces the numerous per-plugin
'all_logs' options and avoids the need for clumsy command lines
like:
-k audit.all_logs,cron.all_logs,logs.all_logs,pcp.all_logs,...
The audit, cron, cups, libvirt, logs, mysql, and pcp plugins have
been converted to use the new option.
Fixes #305.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Although it's a 'verification' this is just a simple configuration
test of the environment; it typically completes in <1s.
Related: #304.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
| |
Related: #304.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
| |
Related: #304.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a mechanism to allow plugins selective access to global
command line options via the standard Plugin.get_option() method.
Use this to implement a global --verify that plugins can test to
determine whether or not to execute potentially costly verify
operations.
Related: #304.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|