| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
Move all the syslog collection from the general plug-in to a new
logs plug-in and factor out the all_logs support from the
RedHatLogs class into the Logs superclass.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The kernel ring buffer is certainly more 'kernel' than 'general'.
Put it where it belongs and remove the duplicate dmesg call and
'dmesg_now' suggested filename (there's no need as it's in a
separate directory to the saved version at var/log/dmesg and the
normal action of dmesg is to print the current content).
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
The hardware plug-in has been split up into separate ata, block,
pci, scsi, and usb plug-ins remove the data collected for these
subsystems from the hardware module.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
Add a new plug-in, processor, to capture CPU related information
and separate out all the CPU data from the old hardware plug-in.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
| |
Separate out the scsi data from the hardware plug-in.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
Separate the PCI related data into its own plug-in and remove it
from the hardware plug-in.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
Separate the ATA and IDE code from the hardware god-object and
put them in a separate plug-in that is activated by the presence
of hdparm or smartmontools.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
Collect /proc/partitions in the block plug-in where it belongs
(not in the cluster or file system plug-ins where it has hidden
in the past!).
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existing initrd plug-in is default-disabled so it rarely
collects anything useful. The command used to extract the init
script from the initramfs image is also broken for modern systems
as the pattern ("initrd*") does not match and the file /init on
systems using systemd is actually a symbolic link to the systemd
binary.
Replace the collection of this file with a listing of the current
initramfs image (via lsinitrd). Optionally collect a listing from
each non-kdmump image present in /boot.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
This partially reverts commit fbbb6ac. Renaming the module was a
mistake; internationalization is just too long.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Add a new grub2 plug-in and separate the grub and lilo support
from the bootloader module which now collects legacy and special
purpose or arch bootloader configuration and a directory listing
of /boot.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The filesys module has long had a lot of (very weird) code for
detecting and processing a list of whole-disk devices in the
system. Apart from being garbage this doesn't really belong in
the file systems module - move it to block and replace the
hokey /proc-and-hdparm-or-regex thing with the existing directory
walk over /sys/block.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
Disk partition data does not belong in the cluster code (or the
file systems module for that matter but that's a topic for the
next commit). Remove it.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The abrt plug-in's check_enabled() just checks for one package and
one file; add .packages and .files members to the plug-in class
and delete the method.
Also tidies up some long lines and string formatting.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|\
| |
| | |
Remove methods related to java and internationalization.
|
|/
|
|
|
|
|
| |
- Old methods not needed anymore, set_i18n and _get_classloader both only
useful if we were still supporting jython.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
| |
The anacron plugin falsely declares itself to be named 'anaconda'
(it started life as a copy of it). Fix it.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
The squid plug-in can potentially collect large volumes of logs.
Limit it to 15M to be consistent with similar modules.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|\
| |
| | |
Patch improve makefile debian
|
| |
| |
| |
| | |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
| |
| |
| |
| |
| |
| | |
reflect the new build task name for debian builds.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Since removing the jboss/application server bits we no longer need
those build tasks in the Makefile.
- Remove building gpgkeys entirely since it is not referenced anywhere in
the code.
- Update the creation of tarballs to exclude-vcs directories such as .git, .bzr,
etc.
- Move build tasks from deb-unsign to deb because its less to type and still
properly explains what the task is.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
| |
| |
| |
| |
| |
| |
| | |
The Red Hat and Debian/Ubuntu system plug-ins are identical. Get
rid of them and have a comon System class.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
| |
| |
| |
| |
| |
| | |
Ntp information belongs in the ntp plug-in.. Duh. Move the few
files collected in the system module to ntp.py.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The cron data does not belong in the system plug-in and it seems
pointless to have a separate module just for crontabs (but not
for cron!). Move the cron logs and tabs into a new plug-in named
cron.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It's unwise to collect user crontabs (especially "for all accounts
with a directory in /home"..) since they could contain
confidential information. The icky shell call-out also has not
worked in some time - remove it all.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
| |
| |
| |
| | |
The system plug-in is a dumping ground of all sorts of random
bits and pieces. Move the anacron stuff to its own file.
|
| |
| |
| |
| | |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The 'printing' plug-in is almost entirely cups-specific (the
lpstat invocations would work with another lp implementation but
that's fairly unlikely..). Add a check for the package and rename
the module to cups.py.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
| |
| |
| |
| |
| |
| | |
The default log size limit is 15M for most plug-ins. The printing
plug-in uses 50M. Set it to 15M to avoid very large reports.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
| |
| |
| | |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The '-a' option is an undocumented option to nfsstat that only
reports that ACL data is not yet implemented.
The options should be '-o all' to retrieve all available NFS
stats.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
| |
| |
| |
| | |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|/
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
| |
Netdump has not been shipped since RHEL4 and is a Red Hatism.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
Subsystem plug-ins have no business collecting general performance
data. Remove the top output collection and topOutput command line
option.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code to collect dumpe2fs output does not work on modern
systems due to changes in the output of the mount command.
Have the plug-in use /proc/mounts instead and simplify and improve
the regex used to find devices containing ext[234] file systems
and switch to 'dumpe2fs -h' collection rather than getting the
full group lists.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
| |
The filesys plugin has the "option_list defined twice" bug. Fix
it and ensure that both the 'lsof' and 'dumpe2fs' options are
usable.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Plugin.do_cmd_output_sub() assumes that the list of executed
commands is non-empty if the list of commands requested is
non-empty. This can be false (e.g. when a command is run
speculatively and the binary is not present) leading to an
unbound variable exception as the code never sets the variable
used as the return value:
Traceback (most recent call last):
File "/usr/sbin/sosreport", line 23, in <module>
main(sys.argv[1:])
File "/usr/lib/python2.7/dist-packages/sos/sosreport.py", line 1154, in main
sos.execute()
UnboundLocalError: local variable 'replacements' referenced before assignment
> /usr/lib/python2.7/dist-packages/sos/plugins/__init__.py(197)do_cmd_output_sub()
-> return replacements
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up some plug-ins with non-conforming or undescriptive names,
set plugin_name in all base plug-in classes to avoid <dist><plug>
names appearing in reports and remove the obsolete amd plug-in.
Rename several plug-ins:
- rhn -> satellite (also spacewalk)
- i18n -> internationalization
- qpidd -> qpid
- ftp -> vsftpd
Enforce pep8 style class names for all plug-in classes.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
Nothing current ships the amd automounter any more. Remove the
plug-in from the tree.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
The hardware.py script is no longer executable. Run it via the
python interpreter.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The cpu frequency reporting on modern systems has moved from
cpufrequtils and the cpufreq command to kernel-tools and the
cpupower command.
Check for the respective packages and run the correct command.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Break the device-mapper plug-in up into separate plugins for dm
itself and each of the current device-mapper applications:
- devicemapper.py
- dmraid.py
- block.py
- lvm2.py
- md.py
The data collection for each subsystem is largely unchanged other
than to fix bugs and remove obsolete items:
- support for multipath bindings in /var dropped
(only relevant to RHEL5 and earlier)
- collect multipath -l separately from -ll
- fix 'udevinfo' -> 'udevadm info'
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|