aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [i18n] list style fixesBryn M. Reeves2014-07-081-1/+4
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [foreman] string building style fixesBryn M. Reeves2014-07-081-2/+3
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [emc] list style fixesBryn M. Reeves2014-07-081-3/+6
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [ds] list style fixesBryn M. Reeves2014-07-081-2/+4
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [dmraid] option_list style fixesBryn M. Reeves2014-07-081-3/+3
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [dhcp] style fixesBryn M. Reeves2014-07-081-1/+2
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [cs] list style fixesBryn M. Reeves2014-07-081-14/+20
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [cluster] list and function style fixesBryn M. Reeves2014-07-081-20/+36
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [ceph] option_list style fixesBryn M. Reeves2014-07-081-7/+11
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [boot] option_list style fixesBryn M. Reeves2014-07-081-3/+3
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [azure] list style fixesBryn M. Reeves2014-07-081-5/+7
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [autofs] make package verification depend on --verifyBryn M. Reeves2014-07-081-1/+2
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [auditd] style fixesBryn M. Reeves2014-07-081-0/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [apt] list style fixesBryn M. Reeves2014-07-081-1/+3
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [apache] option_list style fixesBryn M. Reeves2014-07-081-3/+7
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [anaconda] list style fixesBryn M. Reeves2014-07-081-6/+10
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [abrt] option_list style fixesBryn M. Reeves2014-07-081-2/+3
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [systemd] add journalctl --list-boots outputBryn M. Reeves2014-07-081-0/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [gluster] log killall failures at info levelBryn M. Reeves2014-07-081-1/+1
| | | | | | | | Failing to send a signal to the gluster daemons will happen on any system with gluster installed but not running; don't log it at warning level. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [openshift] Improve password obfuscationPep Turro Mauri2014-07-081-8/+19
| | | | | | | | | | | Rewrite MCollective passwords and be a bit more flexible with white space around =. Also provide examples of strings for the string substitutions. Related: #323. Signed-off-by: Pep Turró Mauri <pep@redhat.com>
* [openshift] Don't collect all of /etc/openshiftPep Turro Mauri2014-07-081-6/+10
| | | | | | Reduce glob based collection and aim at more specific paths. Signed-off-by: Pep Turró Mauri <pep@redhat.com>
* [sosreport] improve description of --buildBryn M. Reeves2014-07-081-1/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] implement global --log-size optionBryn M. Reeves2014-07-089-35/+28
| | | | | | | | | | | | | Implement a global '--log-size' option that causes all plugins implementing log size limiting (via add_copy_spec_limit()) to apply the specified value as the size limit. Convert the auditd, cups, logs, nscd, rabbitmq, squid, and upstart plugins to use the new option. Fixes #306. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] implement global --all-logs optionBryn M. Reeves2014-07-089-20/+32
| | | | | | | | | | | | | | | | | Implement a global '--all-logs' option that causes all active plugins to attempt to collect all logs present regardles of rotation or size limiting. This replaces the numerous per-plugin 'all_logs' options and avoids the need for clumsy command lines like: -k audit.all_logs,cron.all_logs,logs.all_logs,pcp.all_logs,... The audit, cron, cups, libvirt, logs, mysql, and pcp plugins have been converted to use the new option. Fixes #305. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [openswan] document that 'ipsec verify' is not costlyBryn M. Reeves2014-07-071-0/+3
| | | | | | | | | Although it's a 'verification' this is just a simple configuration test of the environment; it typically completes in <1s. Related: #304. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [rpm] do not perform rpm -V unless --verify is givenBryn M. Reeves2014-07-071-12/+14
| | | | | | Related: #304. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [systemd] do not verify journal unless --verify is givenBryn M. Reeves2014-07-071-1/+3
| | | | | | Related: #304. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] implement global --verify optionBryn M. Reeves2014-07-072-0/+22
| | | | | | | | | | | | | Introduce a mechanism to allow plugins selective access to global command line options via the standard Plugin.get_option() method. Use this to implement a global --verify that plugins can test to determine whether or not to execute potentially costly verify operations. Related: #304. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] remove debug code from Plugin.get_description()Bryn M. Reeves2014-07-071-3/+2
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive] make archive debug logging depend on --debugBryn M. Reeves2014-07-072-1/+8
| | | | | | | | | | This significantly reduces log noise at maximum verbosity. Users needing the interactive debugger can either use less verbosity (-v) or put up with the flood of messages. Fixes #319. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] Use superclass __doc__ if not defined in derived classBryn M. Reeves2014-07-071-3/+6
| | | | | | Fixes #320. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [openshift] remove cgroups collectionBryn M. Reeves2014-07-071-1/+0
| | | | | | | | The openshift plugin used an obsolete cgroups path ("/cgroups"). Since the cgroups plugin now collects full information on all configured cgroups remove this from the openshift plugin. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [global] clean up formatting and remove obsolete pylint pragmasBryn M. Reeves2014-07-075-59/+23
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] kill Plugin.option_enabled()Bryn M. Reeves2014-07-076-12/+8
| | | | | | | Has been deprecated for years. Kill it and replace the remaining uses with Plugin.get_option(). Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] add simple collect() profilingBryn M. Reeves2014-07-071-0/+3
| | | | | | | | | | | | | Similar to commit fd68a0c; add support for outputing messages indicating the time taken to call collect() for each plugin: [...] [plugin:systemtap] collected plugin 'systemtap' in 16.8759040833 [plugin:systemd] collected plugin 'systemd' in 19.5138418674 [plugin:block] collected plugin 'block' in 40.066119194 [plugin:yum] collected plugin 'yum' in 101.271748066 Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [archive, plugin] handle special file system nodesBryn M. Reeves2014-07-042-4/+36
| | | | | | | | | | Historically sos has ignored all types of file system node that are not regular files or directories. Add support for collecting block, character, fifo and socket special nodes by creating matching nodes in the archive and propagating permissions from the host file system. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] log directory contents added via Plugin.copy_dir()Bryn M. Reeves2014-07-021-2/+4
| | | | | | | | | | | | | | | | | We're currently very verbose about the copyspecs and path lists we process during setup() and collect() but right now we do not log the same level of information for artefacts that are included in the archive as a consequence of Plugin.do_copy_path() calling copy_dir() on the result of copyspec expansion. Log these explicitly and promote logging of copyspec expansion to match that used for command logging. This makes us very chatty at high verbosity but allows a clean view of exactly what the tree walking code is doing (which my sanity desperately needs). Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [megacli] new plugin for LSI MegaRAID based adaptersJon Magrini2014-07-021-0/+39
| | | | | | | | | | The MegaCLI utility is a proprietary utility provided by LSI which can perform reporting and management functions for MegaRAID SAS|SCSI adapters. If the MegaCLI is detected, the plugin will collect basic information such as adapter status, firmware rev, battery status, and raid config. Signed-off-by: Jon Magrini <jmagrini@redhat.com>
* [plugin] python3 exception lists must be tuplesBryn M. Reeves2014-07-021-1/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] handle lstat exceptions in do_copy_path()Bryn M. Reeves2014-07-011-1/+5
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [libvirt] add missing os importBryn M. Reeves2014-07-011-0/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* Use lstat() in do_copy_path and check for char and block devicesBryn M. Reeves2014-07-011-15/+16
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [libvirt] restrict configuration and log collectionBryn M. Reeves2014-07-011-2/+31
| | | | | | | | Collect specific libvirt configuration and log files by glob instead of scoopting up whole directories from /etc and /var and add blacklisting for the libvirt SASL authentication databases. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [s390] remove "find /sys" from pluginBryn M. Reeves2014-07-011-1/+0
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [s390,kernel] move /proc/misc collection to kernel pluginBryn M. Reeves2014-07-012-1/+1
| | | | Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] fix unicode vs. byte array handling in string IOBryn M. Reeves2014-06-301-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Causes a nosetests failure on python3: ====================================================================== ERROR: test_glob_file_over_limit (plugin_tests.AddCopySpecTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/breeves/src/git/sos/tests/plugin_tests.py", line 269, in test_glob_file_over_limit self.mp.add_copy_spec_limit("/tmp/tmp*", 1) File "/home/breeves/src/git/sos/sos/plugins/__init__.py", line 414, in add_copy_spec_limit self.add_string_as_file(tail(_file, sizelimit), strfile) File "/home/breeves/src/git/sos/sos/plugins/__init__.py", line 520, in add_string_as_file content = "..." + content.splitlines()[0] TypeError: Can't convert 'bytes' object to str implicitly ====================================================================== ERROR: test_single_file_over_limit (plugin_tests.AddCopySpecTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/breeves/src/git/sos/tests/plugin_tests.py", line 253, in test_single_file_over_limit self.mp.add_copy_spec_limit(fn, 1) File "/home/breeves/src/git/sos/sos/plugins/__init__.py", line 414, in add_copy_spec_limit self.add_string_as_file(tail(_file, sizelimit), strfile) File "/home/breeves/src/git/sos/sos/plugins/__init__.py", line 520, in add_string_as_file content = "..." + content.splitlines()[0] TypeError: Can't convert 'bytes' object to str implicitly ---------------------------------------------------------------------- Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [plugin] only print a summary of strings added to the archiveBryn M. Reeves2014-06-301-1/+2
| | | | | | | | | | When we're using add_string_as_file() to add tailed file contents to the archive the string may contain many thousands of lines. Only print a summary snippet showing the last line to avoid spamming entire log files to the terminal in -vv mode. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [sar] fix directory list variable nameBryn M. Reeves2014-06-301-1/+1
| | | | | | | | | | | | | | | | One dirList was missed in commit d4ebd07: Traceback (most recent call last): File "/usr/sbin/sosreport", line 23, in <module> main(sys.argv[1:]) File "/usr/lib/python2.7/site-packages/sos/sosreport.py", line 1229, in main sos.execute() NameError: global name 'dirList' is not defined > /usr/lib/python2.7/site-packages/sos/plugins/sar.py(67)setup() -> if sar_filename not in dirList: Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
* [powerpc] collect selected file instead of entire directoryBryn M. Reeves2014-06-301-2/+3
| | | | | | | | | | | | | | | | We are collecting powerpc dir from debugfs which is causing some issues.. Also we don't need that dir data for debugging purpose... Hence removing that file. Also collecting selected files from /proc/ppc64 directory instead of collecting entire directory. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Bryn M. Reeves <bmr@redhat.com> --- sos/plugins/powerpc.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
* [openshift] Get SELinux labels and add verbosityPep Turro Mauri2014-06-261-2/+2
| | | | Signed-off-by: Pep Turró Mauri <pep@redhat.com>