| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The 'pep8' tool has been renamed to 'pycodestyle' to avoid confusion
with pep8 the document. pep8 (the tool) will no longer be updated and as
such we should transition to the new pycodestyle.
This commit fixes a number of PEP8 issues with the new pycodestyle
linter that has tests for new additions to PEP8 that the pep8 tool did
not include. Most of these are exception handling fixes like:
sos/plugins/logs.py:96:13: E722 do not use bare 'except'
Which are relatively straight forward to address, by instead catching
just the applicable exceptions, e.g. IOError, ValueError, etc... In
cases where there were many possible exceptions or where the "bare
'except'" was a final catch-all, we now use 'except Exception' to catch
anything from the base exception class.
Another frequent correction was for escape sequencing, such as:
sos/plugins/logs.py:48:15: W605 invalid escape sequence '\S'
The solution for this is to mark these regex strings as raw strings,
which is preferred by `re` as future releases of that module may/will
become more strict in its parsing of regex strings.
Resolves: #1344
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
|
|
| |
* Updated instructions in README to install Python dependencies
* Added an example to create HTML docs
* Added instruction to optionally run 'make test' before sending a PR
* Relavant changes made in .travis.yml to test requirements
Signed-off-by: Sachin Patil <sacpatil@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bumps requirement for CI to work on Python 3.5, 3.6, 3.7-dev.
To enable sudo we bump the release to trusty.
Dropped the depth to 5 as we aren't doing git commands.
Running --help and -l at the moment (but that should have found
issue 938)
Also running with --batch to test basic running.
Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
| |
Expand the test coverage for Python 3.5 and
nightly build runtimes.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
| |
Utilize their container based build system for faster runs. Update
test version matrix.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
| |
To ensure proper code formatting and syntax is being done this enables
travis-ci to continually check pep8 compliance. This is useful as it will tend
to spot a lot of syntax errors that the unittests may not pick up.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
| |
now that travis-ci supports python 3.4 we make the unittests pass on that
version a requirement.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
| |
Looks like python 3.4 is not ready available on travis-ci.org. We'll make
3.4 unit testing a requirement once travis-ci makes python 3.4 an available
environment.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
|
|
|
|
|
|
|
| |
Remove allow failures for python 3.3 as all tests should now pass going
forward. Also install six via pip for unittests on travis-ci
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
|
|
|
|
|
|
| |
- We are planning on moving to python distutils for future packaging
however, we still want to keep our current build infrastructure around
until we are able to test the builds overtime. For now distutils will
live alongside the current build process and slowly replace the Makefiles
once deemed fit.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
|
|
| |
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|
|
- In our unittest we defined 'is_installed' to be a bool when in fact we wanted
to verify if a package is installed via the _method_ is is_installed. Since
overriding that method with our variable definition we basically removed
any functionality of 'is_installed' method in Plugin class.
- Initializing a fake plugin to test was failing due to our global
logger not being initialized. Put a simple check in the library to
make sure the logger is defined no matter what the calling state does.
- Make import selinux conditional
- Add travis-ci support
- Rename README to utilize travis-ci build status and other markdown supported
features
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
|