diff options
author | Bryn M. Reeves <bmr@redhat.com> | 2013-04-23 17:54:58 +0100 |
---|---|---|
committer | Bryn M. Reeves <bmr@redhat.com> | 2013-04-23 17:54:58 +0100 |
commit | 624034ec2184ca6f6a719f45f7b0addaa4718dac (patch) | |
tree | 5338946f7e844702a4a2d1f8dfc13405c9417d4e /tests/test_exe.py | |
parent | 5e7346542ac1d11d73e9cbf84cecce910c5c823d (diff) | |
download | sos-624034ec2184ca6f6a719f45f7b0addaa4718dac.tar.gz |
Clean up SoSReport.execute()
Reorganise the SoSReport object's execute() method to facilitate
separation of the command line and report generation logic:
- Rename ensure_plugins() as verify_plugins() and have it return
a boolean to the execute() method.
- Push logging down from execute into the individual action
methods that carry out the tasks being logged.
- Have execute() return a boolean indicating whether the
requested operation completed successfully or not.
Longer term it may be better to define an enumeration class for
sos return statuses. This would allow more expression than simple
'pass' or 'fail' and would help the move toward an API.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Diffstat (limited to 'tests/test_exe.py')
0 files changed, 0 insertions, 0 deletions