aboutsummaryrefslogtreecommitdiffstats
path: root/LICENSE
diff options
context:
space:
mode:
authorBryn M. Reeves <bmr@redhat.com>2012-12-10 17:59:44 +0000
committerBryn M. Reeves <bmr@redhat.com>2012-12-10 17:59:44 +0000
commitbc908179c200a73f032e188409384a4f8ed47c3b (patch)
tree0a481c332454a1a49259eae59cdf0bf9e47a8e55 /LICENSE
parent656ceaf1e503c0d7ca9b3bc0b1291e0d52e97a45 (diff)
downloadsos-bc908179c200a73f032e188409384a4f8ed47c3b.tar.gz
Do not attempt to store SELinux context for /proc and /sys
Storing a (correct) SELinux context for files in procfs and sysfs leads to tonnes of ugly spew when the tarball is unpacked as these contexts are not permitted on "normal" file systems: tar: sosreport-rhel7-vm1-20121210145629/proc/sys/vm: Cannot setfilecon: Permission denied tar: sosreport-rhel7-vm1-20121210145629/proc/sys/vm/percpu_pagelist_fraction: Cannot setfilecon: Permission denied tar: sosreport-rhel7-vm1-20121210145629/proc/sys/vm: Cannot setfilecon: Permission denied tar: sosreport-rhel7-vm1-20121210145629/proc/sys/vm/scan_unevictable_pages: Cannot setfilecon: Permission denied Etc. Check for these path prefixes in TarFileArchive.add_file() and skip generating a pax header for them. This isn't a perfect fix; it may be better to move this up to a higer layer (i.e. within the Plugin class's file handling routines) and also to filter by context rather than path (since SELinux contexts are a property of an inode not a path and a user could mount these file systems at other locations). This partially fixes Issue #79 but I'll keep it open for the time being to track these improvements.
Diffstat (limited to 'LICENSE')
0 files changed, 0 insertions, 0 deletions