aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBryn M. Reeves <bmr@redhat.com>2013-11-18 13:02:19 +0000
committerBryn M. Reeves <bmr@redhat.com>2013-11-18 13:02:19 +0000
commit442e727de62ba8ba5efd808f0f22f7409132e35b (patch)
tree586abc2ec0c7285155188f22ed3b97a6d33b850b
parent71bf206a73e62cedd923445abb0f90ffe1909773 (diff)
downloadsos-442e727de62ba8ba5efd808f0f22f7409132e35b.tar.gz
Reclasify 'error' messages as 'warning'
Several log messages used the 'error' level when reporting an event that is not necessarily an error (and does not prevent sos from continuing). Reclassify these to the 'warning' log level instead. Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
-rw-r--r--sos/plugins/kernel.py2
-rw-r--r--sos/plugins/sar.py2
-rw-r--r--sos/sosreport.py4
3 files changed, 4 insertions, 4 deletions
diff --git a/sos/plugins/kernel.py b/sos/plugins/kernel.py
index 1afe9dff..f96fe6ce 100644
--- a/sos/plugins/kernel.py
+++ b/sos/plugins/kernel.py
@@ -32,7 +32,7 @@ class Kernel(Plugin, RedHatPlugin, DebianPlugin, UbuntuPlugin):
modules = os.listdir(self.sys_module)
self.add_cmd_output("modinfo " + " ".join(modules))
except OSError:
- self.soslog.error("could not list %s" % self.sys_module)
+ self.soslog.warning("could not list %s" % self.sys_module)
self.add_cmd_output("dmesg")
self.add_cmd_output("sysctl -a")
diff --git a/sos/plugins/sar.py b/sos/plugins/sar.py
index 570262a4..10862083 100644
--- a/sos/plugins/sar.py
+++ b/sos/plugins/sar.py
@@ -47,7 +47,7 @@ class Sar(Plugin,):
try:
dirList = os.listdir(self.sa_path)
except:
- self.soslog.error("sar: could not list /var/log/sa")
+ self.soslog.warning("sar: could not list /var/log/sa")
return
# find all the sa file that don't have an existing sar file
for fname in dirList:
diff --git a/sos/sosreport.py b/sos/sosreport.py
index 060168cb..b97dde91 100644
--- a/sos/sosreport.py
+++ b/sos/sosreport.py
@@ -780,13 +780,13 @@ class SoSReport(object):
for plugin_class in plugin_classes:
if not self.policy.validatePlugin(plugin_class):
- self.soslog.debug(_("plugin %s does not validate, skipping") % plug)
+ self.soslog.warning(_("plugin %s does not validate, skipping") % plug)
if self.opts.verbosity > 0:
self._skip(plugin_class, _("does not validate"))
continue
if plugin_class.requires_root and not self._is_root:
- self.soslog.debug(_("plugin %s requires root permissions to execute, skipping") % plug)
+ self.soslog.info(_("plugin %s requires root permissions to execute, skipping") % plug)
self._skip(plugin_class, _("requires root"))
continue