diff options
| author | Nijin Ashok <nashok@redhat.com> | 2018-09-06 11:43:52 +0530 |
|---|---|---|
| committer | Bryn M. Reeves <bmr@redhat.com> | 2019-03-18 10:15:08 +0000 |
| commit | ca6c0a3bc6b9eef9355b28fdc9bf12a0b13c6cd4 (patch) | |
| tree | 5dc5d396b337391b3e9b88f11285db88b148d428 | |
| parent | 20b4c4f4301410bddc35b7b55b4319cf6f45b5a6 (diff) | |
| download | sos-ca6c0a3bc6b9eef9355b28fdc9bf12a0b13c6cd4.tar.gz | |
[ovirt] Collect engine heap dump only if it's specified
Currently the java heap dump of engine process is collected from
"/var/log/ovirt-engine/dump" by default. The size of these dumps are
very large which will increase the size of collected sosreport
significantly. The dumps are not required for most of the cases
and hence collect it only if it's specified using -k ovirt.heapdump
Resolves: #1415
Signed-off-by: Nijin Ashok <nashok@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
| -rw-r--r-- | sos/plugins/ovirt.py | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/sos/plugins/ovirt.py b/sos/plugins/ovirt.py index ea01fd07..9802ef52 100644 --- a/sos/plugins/ovirt.py +++ b/sos/plugins/ovirt.py @@ -57,7 +57,9 @@ class Ovirt(Plugin, RedHatPlugin): ('jbosstrace', 'Enable oVirt Engine JBoss stack trace collection', '', True), ('sensitive_keys', 'Sensitive keys to be masked', - '', DEFAULT_SENSITIVE_KEYS) + '', DEFAULT_SENSITIVE_KEYS), + ('heapdump', 'Collect heap dumps from /var/log/ovirt-engine/dump/', + '', False) ] def setup(self): @@ -81,6 +83,10 @@ class Ovirt(Plugin, RedHatPlugin): '/etc/rhevm/.pgpass' ]) + if not self.get_option('heapdump'): + self.add_forbidden_path('/var/log/ovirt-engine/dump') + self.add_cmd_output('ls -l /var/log/ovirt-engine/dump/') + # Copy all engine tunables and domain information self.add_cmd_output("engine-config --all") |