diff options
| author | Bryn M. Reeves <bmr@redhat.com> | 2013-06-06 15:41:35 +0100 |
|---|---|---|
| committer | Bryn M. Reeves <bmr@redhat.com> | 2013-06-06 15:41:35 +0100 |
| commit | c8f9edbfd8b7f1c6c343e809b003188d91475475 (patch) | |
| tree | 896629e227dfaded2fa80c5cd5b17dc09c650545 | |
| parent | 7304ea8e1e7251232ff555468097dacf6fd58fe0 (diff) | |
| download | sos-c8f9edbfd8b7f1c6c343e809b003188d91475475.tar.gz | |
Fix incorrect use of add_copy_specs() in system plug-in
The system plug-in tries to pass a naked string to add_copy_specs().
This causes each character of the string to be passed down to an
invocation of add_copy_spec():
add_copy_specs(copyspecs=/proc/sys, sub=None)
add_copy_spec(copyspec=/, sub=None)
add_copy_spec(copyspec=p, sub=None)
add_copy_spec(copyspec=r, sub=None)
[...]
Collecting '/' is clearly a bad idea (see Issue #141).
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
| -rw-r--r-- | sos/plugins/system.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sos/plugins/system.py b/sos/plugins/system.py index 73c51c32..a7e3eda1 100644 --- a/sos/plugins/system.py +++ b/sos/plugins/system.py @@ -21,7 +21,7 @@ class System(Plugin, RedHatPlugin, DebianPlugin, UbuntuPlugin): plugin_name = "system" def setup(self): - self.add_copy_specs("/proc/sys") + self.add_copy_spec("/proc/sys") self.add_forbidden_path( "/proc/sys/net/ipv6/neigh/*/retrans_time") self.add_forbidden_path( |