aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Perina <mperina@redhat.com>2019-08-21 11:17:44 +0200
committerPavel Moravec <pmoravec@redhat.com>2019-08-25 12:47:48 +0200
commit0c83c8245ffab2ff3f568078651553f59ef475bb (patch)
treebbe3bc186d049daa359282b376a90c08f67678b9
parent3240475c54af3fde9857434c936a64debbdf90c2 (diff)
downloadsos-0c83c8245ffab2ff3f568078651553f59ef475bb.tar.gz
[vdsm]: Fix executing shell commands
During review process of [1] it was suggested to replace '/bin/sh' with just 'sh', but unfortunately this change caused an error to not include information about VDSM mount points as described in [2]. This fix restores previous state and add full path to shell executions. [1] https://github.com/sosreport/sos/pull/1205 [2] https://bugzilla.redhat.com/1743304 Resolves: #1761 Signed-off-by: Martin Perina <mperina@redhat.com> Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
-rw-r--r--sos/plugins/vdsm.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/sos/plugins/vdsm.py b/sos/plugins/vdsm.py
index 35eec509..c4e2af5f 100644
--- a/sos/plugins/vdsm.py
+++ b/sos/plugins/vdsm.py
@@ -93,8 +93,8 @@ class Vdsm(Plugin, RedHatPlugin):
])
self.add_cmd_output([
"ls -ldZ /etc/vdsm",
- "su vdsm -s sh -c 'tree -l /rhev/data-center'",
- "su vdsm -s sh -c 'ls -lR /rhev/data-center'"
+ "su vdsm -s /bin/sh -c 'tree -l /rhev/data-center'",
+ "su vdsm -s /bin/sh -c 'ls -lR /rhev/data-center'"
])
self.add_cmd_output([
"lvm vgs -v -o +tags --config \'%s\'" % LVM_CONFIG,