| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Add support for lzip-compressed archives (*.tar.lz) and patches.
This closes bug #54570:
https://savannah.nongnu.org/bugs/?54570
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The compatibility getopt script allows only digit parameters to be
embedded in short options. Util-linux's getopt implementation does
not have such a restriction and allows any parameter to be embedded
in short options. As a consequence, using the compatibility getopt
script would choke for example on "-pab", which is a legal option
of the "quilt refresh" command.
Remove the limitation on digits so that the compatibility getopt
script allows what util-linux allows. This fixes the second half
of bug #54772:
https://savannah.nongnu.org/bugs/index.php?54772
As a side note, this feature of the compatibility script was broken
anyway, as it would output the digits in reverse order.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
getopt can be passed 2 '--' separators. The first one tells that
getopt options are over and target program options start. The second
one tells that the target program's options are over and following
arguments should be treated as non-options even if they look like
options.
This second separator was not handled, causing the compatibility
getopt script to treat the following arguments as options, eventually
failing one way or another.
Properly detect and handle the second separator. This fixes the first
half of bug #54772:
https://savannah.nongnu.org/bugs/index.php?54772
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
| |
When a patch doesn't exist, complain about that instead of complaining
that no subject header can be extracted.
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Content-Disposition headers quilt has been adding since 2015 are
causing problems with Thunderbird and Gmail, which display patches as
attachments instead of text if this header is present and includes a
filename. This breaks email-based patch reviewing and isn't likely to
get fixed on the email client side, so stop adding those headers.
Recipients of patches via email already need a mechanism to construct
filenames for messages coming from anything but quilt, so this change is
unlikely to cause major problems for existing users.
|
|
|
|
|
|
|
|
|
|
|
| |
Improve overall consistency even if mail headers are case-insensitive.
(The mail threading broken by commit 1d659beb "quilt/mail: Remove
procmail dependency" was already fixed by commit 360b85e1 "mail: Fix
patch set threading".)
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Passing --unified to patch by default prevents using other patch
formats. Out of curiosity, I checked if it helped with performance
but was not able to measure any improvement. So stop passing
--unified by default.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
| |
Most people don't know about the guards helper which can be used
to generate series files. Mentioning it in the quilt manual page
should help raise the awareness.
|
|
|
|
|
|
|
| |
If the user hits Ctrl+C while a test is running, don't leave our
working directory behind.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
| |
Being a little more verbose when mkdir or chdir fails, can't hurt.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One user reported the following issue as bug #51977:
Lisp error: (wrong-type-argument stringp nil)
file-name-nondirectory(nil)
(let ((p (file-name-nondirectory (quilt-top-patch)))) (if (not p) "none" (let ((p2 (file-name-sans-extension p))) (if (< (length p2) 10) p2 (concat (substring p2 0 8) "..")))))
quilt-short-patchname()
(concat " Q:" (quilt-short-patchname))
(setq quilt-mode-line (concat " Q:" (quilt-short-patchname)))
quilt-update-modeline()
This change should fix it.
https://savannah.nongnu.org/bugs/?51977
|
|
|
|
|
| |
Increase the code path coverage of test case space-in-work-dir by
running one command from a subdirectory.
|
|
|
|
| |
Fixes change into a basedir with spaces in the name.
|
| |
|
|
|
|
|
| |
Fixes: 402f78e4b693 ("configure: md5sum is optional")
Fixes: f0b63c5b7533 ("setup: Add basic support for p7zip (.7z) archives")
|
|
|
|
| |
Fixes: 24dc4930b645 ("Translation updates...")
|
|
|
|
|
|
|
|
|
| |
Don't choke if the series file name contains a space or any other
special character. "$SERIES" was already quoted in various places, do
it consistently so that quilt will work in this situation. And add a
basic test case to verify that it actually works.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
| |
When using an alternative QUILT_PATCHES value, we can't use %{P} in
the test case, because P is set in the Makefile before the test case
has a chance to redefine QUILT_PATCHES. Instead we have to make the
prefix optional in the output of the quilt commands, so that the test
will succeed regardless of QUILT_PATCHES_PREFIX being set or not.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
|
| |
There is no point in defining P and _P in the Makefile to allow for
QUILT_PATCHES_PREFIX to be set or unset if we do not use these
variables consistently in the test suite. Replace hardcoded
"patches/" with %{P} or %{_P} throughout the test suite wherever
relevant so that unsetting QUILT_PATCHES_PREFIX in test.quiltrc
actually works.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
| |
%{P} only makes sense when checking the output of a quilt command.
The value of QUILT_PATCHES_PREFIX can obviously not affect what the
user is writing on the command line, nor the output of other
commands.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unsetting QUILT_PATCHES_PREFIX in test/test.quiltrc would trigger a
syntax error on "make check":
/bin/bash: -c: line 3: syntax error near unexpected token `;'
/bin/bash: -c: line 3: `; \'
Makefile:410: recipe for target 'test/.add-filename-check.ok' failed
make: *** [test/.add-filename-check.ok] Error 1
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
| |
The basename call in function diff_file would fail if any component
of the path has a space in its name.
This fixes bug #50862:
https://savannah.nongnu.org/bugs/?50862
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
| |
When editing a patch header with certain editors, it is possible that
no trailing newline character is present on the last line. In such
case, the patch would be corrupted. Prevent that by ensuring that a
newline character is always present.
This fixes bug #50841:
https://savannah.nongnu.org/bugs/?50841
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
| |
If any change is made to the test environment, we want to run the checks
again, to catch any problem early.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
| |
/bin/sh may not include a line number in its error messages, fix the
filtering when it does not.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
| |
Curly braces in perl regex are supposed to be escaped, recent
versions of perl complain when they aren't:
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/%{ <-- HERE (\w+)}/ at ./run line 114.
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/%{ <-- HERE \?}/ at ./run line 290.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
| |
If any change is made to the tester script, we want to run the checks
again, to catch any problem early.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
| |
patch name
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Add an option to keep the working directory after a test has failed.
Also include the test name in the working directory name to make it
easier to figure out which test failed later.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let patches reference the introduction message so that the patch set
is properly threaded by MUA. This used to work but was broken by
accident.
This fixes bug #50775:
https://savannah.nongnu.org/bugs/index.php?50775
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 1d659bebaf3d ("quilt/mail: Remove procmail dependency")
Tested-by: Okash Khawaja <okash.khawaja@gmail.com>
Acked-by: Kent R. Spillner <kspillner@acm.org>
|
|
|
|
|
| |
We only need md5sum for the setup command, like rpmbuild and 7z. So
treat it as optional.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should work in the most basic case (no option used.) This only
covers the case of archives being compressed with 7z, not patches.
This should fix bug #49754:
http://savannah.nongnu.org/bugs/?49754
Remaining issues:
* 7z could also be used to compress patches, although nobody sane
would do that.
* 7z is very verbose, and doesn't offer any option to be silent or
even just quieter.
|
|
|
|
|
|
|
|
|
| |
When operating on an rpm package, create links to the rpm sources and
build directories and make patch names relative to these links. This is
more convenient than using ugly absolute paths.
This patch has been in the SUSE quilt package since February 2006, it
seems to be about time to get it upstream.
|
|
|
|
|
|
| |
Add a target "updatepo" which translators can run to update the
translation files. Then they can look for strings to translate and
send us a patch or the updated translation file(s).
|
|
|
|
|
| |
For consistency, the guards manual page should be generated under
doc/, not bin/.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Some options need a parameter, invite the user to provide it.
|
|
|
|
| |
Command "new" accepts options now, add support for them.
|