| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Don't choke if the series file name contains a space or any other
special character. "$SERIES" was already quoted in various places, do
it consistently so that quilt will work in this situation. And add a
basic test case to verify that it actually works.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
| |
When using an alternative QUILT_PATCHES value, we can't use %{P} in
the test case, because P is set in the Makefile before the test case
has a chance to redefine QUILT_PATCHES. Instead we have to make the
prefix optional in the output of the quilt commands, so that the test
will succeed regardless of QUILT_PATCHES_PREFIX being set or not.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
|
| |
There is no point in defining P and _P in the Makefile to allow for
QUILT_PATCHES_PREFIX to be set or unset if we do not use these
variables consistently in the test suite. Replace hardcoded
"patches/" with %{P} or %{_P} throughout the test suite wherever
relevant so that unsetting QUILT_PATCHES_PREFIX in test.quiltrc
actually works.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
| |
%{P} only makes sense when checking the output of a quilt command.
The value of QUILT_PATCHES_PREFIX can obviously not affect what the
user is writing on the command line, nor the output of other
commands.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unsetting QUILT_PATCHES_PREFIX in test/test.quiltrc would trigger a
syntax error on "make check":
/bin/bash: -c: line 3: syntax error near unexpected token `;'
/bin/bash: -c: line 3: `; \'
Makefile:410: recipe for target 'test/.add-filename-check.ok' failed
make: *** [test/.add-filename-check.ok] Error 1
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
| |
The basename call in function diff_file would fail if any component
of the path has a space in its name.
This fixes bug #50862:
https://savannah.nongnu.org/bugs/?50862
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
| |
When editing a patch header with certain editors, it is possible that
no trailing newline character is present on the last line. In such
case, the patch would be corrupted. Prevent that by ensuring that a
newline character is always present.
This fixes bug #50841:
https://savannah.nongnu.org/bugs/?50841
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
| |
If any change is made to the test environment, we want to run the checks
again, to catch any problem early.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
| |
/bin/sh may not include a line number in its error messages, fix the
filtering when it does not.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
| |
Curly braces in perl regex are supposed to be escaped, recent
versions of perl complain when they aren't:
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/%{ <-- HERE (\w+)}/ at ./run line 114.
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/%{ <-- HERE \?}/ at ./run line 290.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
| |
If any change is made to the tester script, we want to run the checks
again, to catch any problem early.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
| |
patch name
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Add an option to keep the working directory after a test has failed.
Also include the test name in the working directory name to make it
easier to figure out which test failed later.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let patches reference the introduction message so that the patch set
is properly threaded by MUA. This used to work but was broken by
accident.
This fixes bug #50775:
https://savannah.nongnu.org/bugs/index.php?50775
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 1d659bebaf3d ("quilt/mail: Remove procmail dependency")
Tested-by: Okash Khawaja <okash.khawaja@gmail.com>
Acked-by: Kent R. Spillner <kspillner@acm.org>
|
|
|
|
|
| |
We only need md5sum for the setup command, like rpmbuild and 7z. So
treat it as optional.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should work in the most basic case (no option used.) This only
covers the case of archives being compressed with 7z, not patches.
This should fix bug #49754:
http://savannah.nongnu.org/bugs/?49754
Remaining issues:
* 7z could also be used to compress patches, although nobody sane
would do that.
* 7z is very verbose, and doesn't offer any option to be silent or
even just quieter.
|
|
|
|
|
|
|
|
|
| |
When operating on an rpm package, create links to the rpm sources and
build directories and make patch names relative to these links. This is
more convenient than using ugly absolute paths.
This patch has been in the SUSE quilt package since February 2006, it
seems to be about time to get it upstream.
|
|
|
|
|
|
| |
Add a target "updatepo" which translators can run to update the
translation files. Then they can look for strings to translate and
send us a patch or the updated translation file(s).
|
|
|
|
|
| |
For consistency, the guards manual page should be generated under
doc/, not bin/.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Some options need a parameter, invite the user to provide it.
|
|
|
|
| |
Command "new" accepts options now, add support for them.
|
|
|
|
| |
Some options need a parameter, invite the user to provide it.
|
|
|
|
|
| |
Enable completion with the new options of commands diff, fold, import,
mail, patches, pop, push, refresh, series and setup.
|
|
|
|
| |
Command "upgrade" was missing.
|
|
|
|
| |
Add missing options -m and --fuzz to the synopsis.
|
|
|
|
|
| |
Add options --charset and --signature to the synopsis, and describe
the --charset option.
|
|
|
|
|
|
| |
Drop the check for quilt being present. No other completion file has
such a check, because it's useless. If the program isn't installed
then its completion file isn't installed either.
|
|
|
|
|
|
|
|
|
|
| |
Completing long options of the grep command is not a fundamental
feature. I can't remember ever needing it. The most useful grep
options are short ones by design. Additionally, our internal
implementation of _longopt is broken as far as I can tell.
So drop our implementations of _expand, _filedir and _longopt, and
only call _longopt if it is already available from bash-completion.
|
|
|
|
|
| |
Add support for directories to _quilt_comfile, and use that for the
setup command. The drops the last direct dependency to _filedir.
|
|
|
|
|
| |
All other commands use _quilt_comfile so do the same for diff for
consistency.
|
|
|
|
|
|
|
|
| |
Set IFS in _quilt_comfile so that file names containing spaces are
properly handled. Also quote ${COMPREPLY[@]} everywhere so that such
file names are preserved.
This closes Debian bug #640551.
|
|
|
|
|
|
|
|
|
|
| |
You can't change the caller's environment from the right hand side of
a pipe. So that code was doing nothing, which means we can just
delete it.
What the code was supposedly doing, is actually implemented by
complete's option "filenames". So move the comment to where this
option is set, to clear the confusion.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Fix a race condition where we may check the return status of diff
before the command has actually terminated. Make sure that we read
all of diff's output to ensure this can't happen.
|
|
|
|
|
| |
"quilt refresh" reports diff failures to the user. "quilt diff"
should do the same.
|