diff options
| author | Jean Delvare <jdelvare@suse.de> | 2011-12-15 14:22:57 +0100 |
|---|---|---|
| committer | Jean Delvare <jdelvare@suse.de> | 2011-12-15 14:22:57 +0100 |
| commit | b850ecea0cf22fd3222cf68d600b86866b08b109 (patch) | |
| tree | db3a53f5b3013bf596dcb45f9a83b0179b96b1e1 | |
| parent | a8eae6b84f446e9cda14977acba88ead040a4600 (diff) | |
| download | quilt-b850ecea0cf22fd3222cf68d600b86866b08b109.tar.gz | |
Don't let TMPDIR take over /var/tmp
TMPDIR is set to /tmp by default on some systems [1], in this case
letting it take over /var/tmp voids the point of using /var/tmp for
data size reasons in the first place [2]. I'd rather hardcode
/var/tmp. But in case someone really wants to control this, we can
check if VARTMPDIR is set and use that if it is set.
[1] I tried to track down how it was happening and I am far from
certain that this is on purpose. I've seen it happen only on local
graphical login, not on text console login nor remote login. This
suggests a leak from some piece of the graphical desktop stack. And
I've seen it on both KDE and Gnome, but not Xfce. Go figure.
[2] This is the reason given in commit
d4074d26276b9a2d452563dbf57ed497afa7b710 for using /var/tmp.
| -rw-r--r-- | quilt.changes | 5 | ||||
| -rw-r--r-- | quilt/scripts/inspect.in | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/quilt.changes b/quilt.changes index 5ce7d32..01adacf 100644 --- a/quilt.changes +++ b/quilt.changes @@ -1,4 +1,9 @@ ------------------------------------------------------------------- +Thu Dec 15 14:20:04 CET 2011 - jdelvare@suse.de + +- scripts/inspect.in: Don't let TMPDIR take over /var/tmp. + +------------------------------------------------------------------- Thu Dec 15 13:53:35 CET 2011 - jdelvare@suse.de - scripts/inspect.in: Fix quilt setup. A file name of "-" means diff --git a/quilt/scripts/inspect.in b/quilt/scripts/inspect.in index 8d5f229..63d8ba4 100644 --- a/quilt/scripts/inspect.in +++ b/quilt/scripts/inspect.in @@ -61,7 +61,7 @@ else specdir=$PWD fi -tmpdir="$(gen_tempfile -d ${TMPDIR:-/var/tmp}/${0##*/})" +tmpdir="$(gen_tempfile -d ${VARTMPDIR:-/var/tmp}/${0##*/})" mkdir -p $tmpdir || exit 1 add_exit_handler "rm -rf $tmpdir" mkdir -p $tmpdir/build |