From c40fcefddec1d07fb5a06c2173b409f37f7409d1 Mon Sep 17 00:00:00 2001 From: Vadim Markovtsev Date: Mon, 11 Feb 2019 21:13:44 +0100 Subject: Remove Unicode normalization in difftree Fixes #1057 Signed-off-by: Vadim Markovtsev --- utils/merkletrie/noder/path.go | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'utils/merkletrie/noder/path.go') diff --git a/utils/merkletrie/noder/path.go b/utils/merkletrie/noder/path.go index e9c905c..1c7ef54 100644 --- a/utils/merkletrie/noder/path.go +++ b/utils/merkletrie/noder/path.go @@ -3,8 +3,6 @@ package noder import ( "bytes" "strings" - - "golang.org/x/text/unicode/norm" ) // Path values represent a noder and its ancestors. The root goes first @@ -80,11 +78,9 @@ func (p Path) Compare(other Path) int { case i == len(p): return -1 default: - form := norm.Form(norm.NFC) - this := form.String(p[i].Name()) - that := form.String(other[i].Name()) - - cmp := strings.Compare(this, that) + // We do *not* normalize Unicode here. CGit doesn't. + // https://github.com/src-d/go-git/issues/1057 + cmp := strings.Compare(p[i].Name(), other[i].Name()) if cmp != 0 { return cmp } -- cgit