From 172a0d8a0e1e05d0bc47df09d50fb8ef49529f5f Mon Sep 17 00:00:00 2001 From: Christian Muehlhaeuser Date: Sun, 21 Jul 2019 06:05:19 +0200 Subject: *: added missing error checks in tests When we assign a value to err, make sure to also check for it being nil afterwards. If those were intentionally unchecked, we should remove the assignment in the first place. Those checks certainly never harm, but please review thoroughly and let me know. Signed-off-by: Christian Muehlhaeuser (cherry picked from commit 19d6f42a4d814a50bd262fbb69a9b670db9756a2) --- storage/filesystem/dotgit/dotgit_test.go | 1 + 1 file changed, 1 insertion(+) (limited to 'storage') diff --git a/storage/filesystem/dotgit/dotgit_test.go b/storage/filesystem/dotgit/dotgit_test.go index 73b0291..31c6fe0 100644 --- a/storage/filesystem/dotgit/dotgit_test.go +++ b/storage/filesystem/dotgit/dotgit_test.go @@ -226,6 +226,7 @@ func (s *SuiteDotGit) TestRemoveRefFromReferenceFileAndPackedRefs(c *C) { "refs/remotes/origin/branch", "e8d3ffab552895c19b9fcf7aa264d277cde33881", ), nil) + c.Assert(err, IsNil) // Make sure it only appears once in the refs list. refs, err := dir.Refs() -- cgit