From 4b5849db76905830e0124b6b9f4294ee13308e0f Mon Sep 17 00:00:00 2001
From: "Santiago M. Mola" <santi@mola.io>
Date: Tue, 6 Dec 2016 11:36:38 +0100
Subject: transport/internal: error handling fixes and clean up (#160)

* protocol/packp: remove redundant isFlush check on AdvRefs.
* protocol/packp: improve AdvRefs documentation.
* transport: improve error handling for non-existing repos.
* protocol/packp: AdvRefs Decode now returns different errors for
  empty, but syntactically correct, AdvRefs message (ErrEmptyAdvRefs)
  and empty input (ErrEmptyInput).
* transport/internal/common: read stderr only when needed (ErrEmptyInput).
  Close the client gracefully.
* transport/internal/common: missing stderr on non existing repository
  does not block.
* transport/internal/common: buffer error messages.
* transport/file: fix changing binary name, add tests.
* transport/file: support changing git-upload-pack and git-receive-pack
  binary names.
* transport/file: add tests for misbehaving servers.
* transport/internal/common: remove Stderr field.
* transport/internal/common: do not close twice.
---
 plumbing/transport/file/fetch_pack_test.go | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

(limited to 'plumbing/transport/file/fetch_pack_test.go')

diff --git a/plumbing/transport/file/fetch_pack_test.go b/plumbing/transport/file/fetch_pack_test.go
index 80f11ee..7a23285 100644
--- a/plumbing/transport/file/fetch_pack_test.go
+++ b/plumbing/transport/file/fetch_pack_test.go
@@ -2,6 +2,7 @@ package file
 
 import (
 	"fmt"
+	"os"
 	"os/exec"
 
 	"gopkg.in/src-d/go-git.v4/fixtures"
@@ -46,3 +47,32 @@ func (s *FetchPackSuite) SetUpSuite(c *C) {
 	c.Assert(err, IsNil)
 	s.NonExistentEndpoint = ep
 }
+
+// TODO: fix test
+func (s *FetchPackSuite) TestCommandNoOutput(c *C) {
+	c.Skip("failing test")
+
+	if _, err := os.Stat("/bin/true"); os.IsNotExist(err) {
+		c.Skip("/bin/true not found")
+	}
+
+	client := NewClient("true", "true")
+	session, err := client.NewFetchPackSession(s.Endpoint)
+	c.Assert(err, IsNil)
+	ar, err := session.AdvertisedReferences()
+	c.Assert(err, IsNil)
+	c.Assert(ar, IsNil)
+}
+
+func (s *FetchPackSuite) TestMalformedInputNoErrors(c *C) {
+	if _, err := os.Stat("/usr/bin/yes"); os.IsNotExist(err) {
+		c.Skip("/usr/bin/yes not found")
+	}
+
+	client := NewClient("yes", "yes")
+	session, err := client.NewFetchPackSession(s.Endpoint)
+	c.Assert(err, IsNil)
+	ar, err := session.AdvertisedReferences()
+	c.Assert(err, NotNil)
+	c.Assert(ar, IsNil)
+}
-- 
cgit