From 4b5849db76905830e0124b6b9f4294ee13308e0f Mon Sep 17 00:00:00 2001 From: "Santiago M. Mola" Date: Tue, 6 Dec 2016 11:36:38 +0100 Subject: transport/internal: error handling fixes and clean up (#160) * protocol/packp: remove redundant isFlush check on AdvRefs. * protocol/packp: improve AdvRefs documentation. * transport: improve error handling for non-existing repos. * protocol/packp: AdvRefs Decode now returns different errors for empty, but syntactically correct, AdvRefs message (ErrEmptyAdvRefs) and empty input (ErrEmptyInput). * transport/internal/common: read stderr only when needed (ErrEmptyInput). Close the client gracefully. * transport/internal/common: missing stderr on non existing repository does not block. * transport/internal/common: buffer error messages. * transport/file: fix changing binary name, add tests. * transport/file: support changing git-upload-pack and git-receive-pack binary names. * transport/file: add tests for misbehaving servers. * transport/internal/common: remove Stderr field. * transport/internal/common: do not close twice. --- plumbing/protocol/packp/advrefs_decode_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'plumbing/protocol/packp/advrefs_decode_test.go') diff --git a/plumbing/protocol/packp/advrefs_decode_test.go b/plumbing/protocol/packp/advrefs_decode_test.go index f807f15..2cc2568 100644 --- a/plumbing/protocol/packp/advrefs_decode_test.go +++ b/plumbing/protocol/packp/advrefs_decode_test.go @@ -19,7 +19,7 @@ var _ = Suite(&AdvRefsDecodeSuite{}) func (s *AdvRefsDecodeSuite) TestEmpty(c *C) { var buf bytes.Buffer ar := NewAdvRefs() - c.Assert(ar.Decode(&buf), Equals, ErrEmptyAdvRefs) + c.Assert(ar.Decode(&buf), Equals, ErrEmptyInput) } func (s *AdvRefsDecodeSuite) TestEmptyFlush(c *C) { -- cgit