From 0d999e1db6cd8736ab697de8ce848fa3a5274b9f Mon Sep 17 00:00:00 2001 From: Joshua Sjoding Date: Wed, 24 Feb 2016 22:40:30 -0800 Subject: Refactor to use core.ObjectReader and core.ObjectWriter * New function signatures provide the necessary interface to stream data from disk when using filesystem-based storage in the future * New function signatures provide proper error handling * ObjectReader and ObjectWriter interfaces added to avoid future refactoring, currently are type aliases for io.ReadCloser and io.WriteCloser respectively * Object.Reader now returns (ObjectReader, error) * Object.Writer now returns (ObjectWriter, error) * File.Contents now returns (string, error) * File.Lines now returns ([]string, error) * Blob.Reader now returns (core.ObjectReader, error) * Added internal close helper function for deferred calls to Close that need to check the return value --- objects.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'objects.go') diff --git a/objects.go b/objects.go index c43348f..961502a 100644 --- a/objects.go +++ b/objects.go @@ -4,7 +4,6 @@ import ( "bytes" "errors" "fmt" - "io" "strconv" "time" @@ -35,7 +34,7 @@ func (b *Blob) Decode(o core.Object) error { } // Reader returns a reader allow the access to the content of the blob -func (b *Blob) Reader() io.Reader { +func (b *Blob) Reader() (core.ObjectReader, error) { return b.obj.Reader() } -- cgit