aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* plumbing: format: pktline, Accept oversized pkt-lines up to 65524 bytesJoseph Vusich2018-04-023-2/+19
| | | | | | | | | | | | | | | | | | | | | | | | | The canonical Git client successfully decodes sideband packets up to 65524 bytes in length (4-byte header + 65520-byte payload). The Git protocol documentation was updated in August 2016 to reduce the maximum payload size to 65516 bytes, however old implementations still exist in the wild emitting 65520-byte payloads. As there is no technical difficulty with accepting (not emitting) larger payload sizes, this change adjusts the limit check to allow successful decoding of packets up to 65524 bytes. This change increases compatibility with the current canonical Git implementation. Doc changes from August 2016: https://github.com/git/git/commit/7841c4801ce51f1f62d376d164372e8677c6bc94#diff-52695c8fe91b78b70cea44562ae28297L67 Current packet buffer size is still LARGE_PACKET_MAX (+1 null): https://github.com/git/git/blob/468165c1d8a442994a825f3684528361727cd8c0/sideband.c#L24 https://github.com/git/git/blob/468165c1d8a442994a825f3684528361727cd8c0/sideband.c#L36 LARGE_PACKET_MAX definition: https://github.com/git/git/blob/468165c1d8a442994a825f3684528361727cd8c0/pkt-line.h#L100 Signed-off-by: Joseph Vusich <jvusich@amazon.com>
* Merge pull request #792 from ajnavarro/fix/support-no-symref-capabilityMáximo Cuadros2018-04-022-9/+172
|\ | | | | Resolve HEAD if symRefs capability is not supported
| * Resolve HEAD if symRefs capability is not supportedAntonio Jesus Navarro Perez2018-03-262-9/+172
| | | | | | | | Signed-off-by: Antonio Jesus Navarro Perez <antnavper@gmail.com>
* | Merge pull request #795 from shanedasilva/add_commit_hash_to_blame_resultMáximo Cuadros2018-04-022-2/+10
|\ \ | | | | | | Add commit hash to blame result
| * | Add commit hash to blame resultShane Da Silva2018-03-272-2/+10
| |/ | | | | | | Signed-off-by: Shane Da Silva <shanemichaeldasilva@gmail.com>
* | Merge pull request #794 from jfontan/fix/checkcloseMáximo Cuadros2018-04-0216-39/+59
|\ \ | |/ |/| Use CheckClose with named returns and fix tests
| * storage: filesystem/dotgit, fix typo in return paramJavi Fontan2018-03-281-1/+1
| | | | | | | | Signed-off-by: Javi Fontan <jfontan@gmail.com>
| * plumbing: transport, make target repo writeable in testsJavi Fontan2018-03-271-0/+21
| | | | | | | | | | | | | | | | | | Some tests write to an already existent repository retrieved from fixtures. The permissions of these files are read only and make receive pack fail. This was shadowed before as close errors were lost. Signed-off-by: Javi Fontan <jfontan@gmail.com>
| * *: Use CheckClose with named returnsJavi Fontan2018-03-2715-39/+38
|/ | | | | | | | Previously some close errors were losts. This is specially problematic in go-git as lots of work is done here like generating indexes and moving packfiles. Signed-off-by: Javi Fontan <jfontan@gmail.com>
* Merge pull request #786 from mcuadros/test-shortMáximo Cuadros2018-03-224-0/+48
|\ | | | | *: skip time consuming tests
| * *: skip time consuming testsMáximo Cuadros2018-03-214-0/+48
|/ | | | Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
* Merge pull request #783 from maguro/refspec-srcOri Rawlings2018-03-142-1/+26
|\ | | | | Fix RefSpec.Src()
| * Add more unit tests for RefSpecAlan Cabrera2018-03-141-0/+13
| | | | | | | | | | | | Need this to get better code coverage of the bug fix. Signed-off-by: Alan Cabrera <adc@toolazydogs.com>
| * Fix RefSpec.Src()Alan Cabrera2018-03-142-1/+13
| | | | | | | | | | | | | | | | | | Previously, the Src() function was assuming there are no “+” characters in the refspec src and erroneously used the strings.Index() function to compute the start index of src in the refspec. This change now uses the IsForceUpdate() method to decide how to elide the force update token. Signed-off-by: Alan Cabrera <adc@toolazydogs.com>
* | Merge pull request #778 from konsorten/fix-windows-symlink3Máximo Cuadros2018-03-124-0/+39
|\ \ | | | | | | Worktree.Checkout: handling of symlink on Windows
| * | Added support for non-symlink checkouts on Windows when elevated rights are ↵Felix Kollmann2018-03-124-0/+39
|/ / | | | | | | | | | | missing This implementation mimicks the behavior of Git on Windows Signed-off-by: Felix Kollmann <mail@fkollmann.de>
* | Merge pull request #771 from ilius/PR-log-orderv4.2.0Máximo Cuadros2018-03-126-3/+329
|\ \ | |/ |/| repository.Log: add alternatives for commit traversal order
| * add tests for NewCommitIterCTime and NewCommitIterBSFSaeed Rasooli2018-03-061-0/+96
| | | | | | | | Signed-off-by: Saeed Rasooli <saeed.gnu@gmail.com>
| * Fix "too few values in struct initializer" in repository_test.goSaeed Rasooli2018-03-051-2/+2
| | | | | | | | Signed-off-by: Saeed Rasooli <saeed.gnu@gmail.com>
| * add LogOrder, LogOptions.Order, implement Order=LogOrderCommitterTime and ↵Saeed Rasooli2018-03-054-1/+231
| | | | | | | | | | | | Order=LogOrderBSF Signed-off-by: Saeed Rasooli <saeed.gnu@gmail.com>
* | Merge pull request #769 from dennwc/optimize-1Máximo Cuadros2018-03-051-22/+61
|\ \ | |/ |/| storage/filesystem: optimize packfile iterator
| * storage/filesystem: optimize packfile iteratorDenys Smirnov2018-03-031-22/+61
|/ | | | | | | | * do not store extra bool values in the seen map * open packfile iterators lazily Signed-off-by: Denys Smirnov <denys@sourced.tech>
* Merge pull request #762 from zkry/escape-basic-auth-user-pswdMáximo Cuadros2018-03-012-2/+12
|\ | | | | plubming: transport, Escape the user and pswd for endpoint. Fixes #723
| * plubming: transport, Escape the user and password for endpoint. Fixes #723Zachary Romero2018-02-282-2/+12
| | | | | | | | Signed-off-by: Zachary Romero <zacromero3@gmail.com>
* | Merge pull request #766 from mvdan/patchesMáximo Cuadros2018-03-017-83/+14
|\ \ | | | | | | Unused params, unused code, make Go tip's vet happy
| * | all: make the upcoming Go 1.11's vet happyDaniel Martí2018-03-011-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | vet in 1.10 and earlier was buggy in how its "composite literal uses unkeyed fields" check had false negatives when it encountered a slice of pointer types that omitted each element's type. This has been fixed in tip, so adapt to that fix. Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
| * | all: remove some unused codeDaniel Martí2018-03-015-65/+0
| | | | | | | | | | | | Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
| * | remove unused result parameter from objectsToPushDaniel Martí2018-03-011-7/+3
| |/ | | | | | | | | | | It always returns a nil error. Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
* | Merge pull request #739 from mcuadros/addMáximo Cuadros2018-02-286-38/+779
|\ \ | | | | | | new methods Worktree.[AddGlob|RemoveBlob] and recursive Worktree.[Add|Remove]
| * | new methods Worktree.[AddGlob|RemoveBlob] and recursive Worktree.[Add|Remove]Máximo Cuadros2018-02-262-77/+254
| | | | | | | | | | | | Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
| * | plumbing: format index, Index.Add and Index.Glob methodsMáximo Cuadros2018-02-263-0/+255
| | | | | | | | | | | | Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
| * | new methods Worktree.[AddGlob|AddDirectory]Máximo Cuadros2018-02-013-35/+344
| | | | | | | | | | | | Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
* | | Merge pull request #759 from mdelillo/invalid-ssh-keyMáximo Cuadros2018-02-252-0/+9
|\ \ \ | | | | | | | | plumbing: ssh, return error when creating public keys from invalid PEM
| * | | Return error when creating public keys from invalid PEMMark DeLillo2018-02-252-0/+9
| | |/ | |/| | | | | | | | | | | | | * pem.Decode will return nil in this case, and passing that to x509.IsEncryptedBlock will cause it to panic Signed-off-by: Mark DeLillo <github.med@delillo.org>
* | | Merge pull request #754 from shanedasilva/add_blame_line_dataMáximo Cuadros2018-02-212-2/+7
|\ \ \ | | | | | | | | blame: Add blame line data
| * | | blame.go: Add blame line dataShane Da Silva2018-02-192-2/+7
|/ / / | | | | | | | | | Signed-off-by: Shane Da Silva <shanemichaeldasilva@gmail.com>
* / / .travis: add 1.10Máximo Cuadros2018-02-181-0/+1
|/ / | | | | | | | | | | https://github.com/travis-ci/gimme/issues/132 Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
* | Merge pull request #749 from irias/masterv4.1.1Máximo Cuadros2018-02-172-2/+43
|\ \ | | | | | | plumbing: diff, fix crash when a small ending equal-chunk
| * | add test for crashing diffMechiel Lukkien2018-02-161-0/+37
| | | | | | | | | | | | | | | | | | | | | this reuses an existing patch, setting context to 6 triggers the bug, becuase of a 5-line trailing equals chunk. Signed-off-by: Mechiel Lukkien <mechiel@ueber.net>
| * | fix crash when generating a unified diff with a small ending equal-chunkMechiel Lukkien2018-02-141-2/+6
| | | | | | | | | | | | Signed-off-by: Mechiel Lukkien <mechiel@ueber.net>
* | | Merge pull request #751 from mcuadros/redirectMáximo Cuadros2018-02-154-10/+56
|\ \ \ | |/ / |/| | transport: http, fix services redirecting only info/refs
| * | transport: http, fix services redirecting only info/refsMáximo Cuadros2018-02-144-10/+56
| |/ | | | | | | Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
* | Merge pull request #744 from ↵Máximo Cuadros2018-02-133-8/+18
|\ \ | | | | | | | | | | | | jfontan/fix/make-sure-original-data-is-saved-before-creanup plumbing: format/packfile, fix panic retrieving object hash.
| * | plumbing: format/packfile, add SaveOriginalMetadata functionJavi Fontan2018-02-092-5/+9
| | | | | | | | | | | | Signed-off-by: Javi Fontan <jfontan@gmail.com>
| * | plumbing: format/packfile, fix panic retrieving object hash.Javi Fontan2018-02-093-4/+10
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some cases the original data is not saved before it is cleaned and forces a panic when it's needed. The change adds ObjectToPack.CleanOriginal to be used to clean original object instead of: object.Original = nil Now when the Original data is freed because it's no longer in the pack window a SetOriginal call is done to make sure that Size, Hash and Size data is not lost. Signed-off-by: Javi Fontan <jfontan@gmail.com>
* | Merge pull request #742 from Labutin/patch-1Máximo Cuadros2018-02-081-2/+2
|\ \ | | | | | | Fix mistyping
| * | Fix mistypingDmitry Labutin2018-02-071-2/+2
|/ / | | | | | | Signed-off-by: Dmitry Labutin <dmitry@labutin.com>
* | Merge pull request #740 from ferhatelmas/shallow-storage-errMáximo Cuadros2018-02-021-1/+1
|\ \ | |/ |/| storage/filesystem/shallow: fix error checking
| * storage/filesystem/shallow: fix error checkingferhat elmas2018-02-011-1/+1
|/ | | | Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
* Merge pull request #731 from jfontan/fix/crash-with-delta-cyclesMáximo Cuadros2018-01-264-2/+56
|\ | | | | plumbing: format/packfile, fix crash with cycle deltas
generated by cgit (git 2.34.1) at 2024-11-15 07:31:04 +0000