diff options
author | Máximo Cuadros <mcuadros@gmail.com> | 2016-01-21 13:20:40 +0100 |
---|---|---|
committer | Máximo Cuadros <mcuadros@gmail.com> | 2016-01-21 13:20:40 +0100 |
commit | 050fb78d77b30014acd0b6eefc88ec8a49c20371 (patch) | |
tree | a568723447dd0e15b45462494f55e944805fc5c3 /tree.go | |
parent | abe470a3c1b9fae99161ee5531d18d0e3168fdfa (diff) | |
parent | fec62175e8de8ca8daa40683359706c926d9dc2e (diff) | |
download | go-git-050fb78d77b30014acd0b6eefc88ec8a49c20371.tar.gz |
Merge pull request #15 from alcortesm/performance-increase-for-big-repos
Performance increase for big repos
Diffstat (limited to 'tree.go')
-rw-r--r-- | tree.go | 20 |
1 files changed, 11 insertions, 9 deletions
@@ -15,7 +15,7 @@ import ( // Tree is basically like a directory - it references a bunch of other trees // and/or blobs (i.e. files and sub-directories) type Tree struct { - Entries []TreeEntry + Entries map[string]TreeEntry Hash core.Hash r *Repository @@ -99,13 +99,12 @@ func (t *Tree) dir(baseName string) (*Tree, error) { var errEntryNotFound = errors.New("entry not found") func (t *Tree) entry(baseName string) (*TreeEntry, error) { - for _, entry := range t.Entries { - if entry.Name == baseName { - return &entry, nil - } + entry, ok := t.Entries[baseName] + if !ok { + return nil, errEntryNotFound } - return nil, errEntryNotFound + return &entry, nil } func (t *Tree) Files() chan *File { @@ -147,6 +146,8 @@ func (t *Tree) Decode(o core.Object) error { return nil } + t.Entries = make(map[string]TreeEntry) + r := bufio.NewReader(o.Reader()) for { mode, err := r.ReadString(' ') @@ -174,11 +175,12 @@ func (t *Tree) Decode(o core.Object) error { return err } - t.Entries = append(t.Entries, TreeEntry{ + baseName := name[:len(name)-1] + t.Entries[baseName] = TreeEntry{ Hash: hash, Mode: os.FileMode(fm), - Name: name[:len(name)-1], - }) + Name: baseName, + } } return nil |