storage: transactional, new storage with transactional capabilities

Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>

13 files changed, 675 insertions, 5 deletions

diff --git a/storage/transactional/config.go b/storage/transactional/config.go
index 2fc6583..fec1f28 100644
--- a/storage/transactional/config.go
+++ b/storage/transactional/config.go
@@ -22,6 +22,14 @@ func (c *ConfigStorage) SetConfig(cfg *config.Config) error {
 	return nil
 }
 
+func (c *ConfigStorage) Config() (*config.Config, error) {
+	if !c.set {
+		return c.ConfigStorer.Config()
+	}
+
+	return c.temporal.Config()
+}
+
 func (c *ConfigStorage) Commit() error {
 	if !c.set {
 		return nil
diff --git a/storage/transactional/config_test.go b/storage/transactional/config_test.go
index c178bec..5d1e019 100644
--- a/storage/transactional/config_test.go
+++ b/storage/transactional/config_test.go
@@ -1,20 +1,32 @@
 package transactional
 
 import (
-	"testing"
-
 	. "gopkg.in/check.v1"
 	"gopkg.in/src-d/go-git.v4/config"
 	"gopkg.in/src-d/go-git.v4/storage/memory"
 )
 
-func Test(t *testing.T) { TestingT(t) }
-
 var _ = Suite(&ConfigSuite{})
 
 type ConfigSuite struct{}
 
-func (s *ConfigSuite) TestSetConfig(c *C) {
+func (s *ConfigSuite) TestSetConfigBase(c *C) {
+	cfg := config.NewConfig()
+	cfg.Core.Worktree = "foo"
+
+	base := memory.NewStorage()
+	err := base.SetConfig(cfg)
+	c.Assert(err, IsNil)
+
+	temporal := memory.NewStorage()
+	cs := NewConfigStorage(base, temporal)
+
+	cfg, err = cs.Config()
+	c.Assert(err, IsNil)
+	c.Assert(cfg.Core.Worktree, Equals, "foo")
+}
+
+func (s *ConfigSuite) TestSetConfigTemporal(c *C) {
 	cfg := config.NewConfig()
 	cfg.Core.Worktree = "foo"
 
diff --git a/storage/transactional/index.go b/storage/transactional/index.go
new file mode 100644
index 0000000..26042d6
--- /dev/null
+++ b/storage/transactional/index.go
@@ -0,0 +1,50 @@
+package transactional
+
+import (
+	"gopkg.in/src-d/go-git.v4/plumbing/format/index"
+	"gopkg.in/src-d/go-git.v4/plumbing/storer"
+)
+
+type IndexStorage struct {
+	storer.IndexStorer
+	temporal storer.IndexStorer
+
+	set bool
+}
+
+func NewIndexStorage(s, temporal storer.IndexStorer) *IndexStorage {
+	return &IndexStorage{
+		IndexStorer: s,
+		temporal:    temporal,
+	}
+}
+
+func (s *IndexStorage) SetIndex(idx *index.Index) (err error) {
+	if err := s.temporal.SetIndex(idx); err != nil {
+		return err
+	}
+
+	s.set = true
+	return nil
+}
+
+func (s *IndexStorage) Index() (*index.Index, error) {
+	if !s.set {
+		return s.IndexStorer.Index()
+	}
+
+	return s.temporal.Index()
+}
+
+func (c *IndexStorage) Commit() error {
+	if !c.set {
+		return nil
+	}
+
+	idx, err := c.temporal.Index()
+	if err != nil {
+		return err
+	}
+
+	return c.IndexStorer.SetIndex(idx)
+}
diff --git a/storage/transactional/index_test.go b/storage/transactional/index_test.go
new file mode 100644
index 0000000..e1c571a
--- /dev/null
+++ b/storage/transactional/index_test.go
@@ -0,0 +1,52 @@
+package transactional
+
+import (
+	. "gopkg.in/check.v1"
+	"gopkg.in/src-d/go-git.v4/plumbing/format/index"
+	"gopkg.in/src-d/go-git.v4/storage/memory"
+)
+
+var _ = Suite(&IndexSuite{})
+
+type IndexSuite struct{}
+
+func (s *IndexSuite) TestSetIndexBase(c *C) {
+	idx := &index.Index{}
+	idx.Version = 2
+
+	base := memory.NewStorage()
+	err := base.SetIndex(idx)
+	c.Assert(err, IsNil)
+
+	temporal := memory.NewStorage()
+	cs := NewIndexStorage(base, temporal)
+
+	idx, err = cs.Index()
+	c.Assert(err, IsNil)
+	c.Assert(idx.Version, Equals, uint32(2))
+}
+
+func (s *IndexSuite) TestCommit(c *C) {
+	idx := &index.Index{}
+	idx.Version = 2
+
+	base := memory.NewStorage()
+	err := base.SetIndex(idx)
+	c.Assert(err, IsNil)
+
+	temporal := memory.NewStorage()
+
+	idx = &index.Index{}
+	idx.Version = 3
+
+	is := NewIndexStorage(base, temporal)
+	err = is.SetIndex(idx)
+	c.Assert(err, IsNil)
+
+	err = is.Commit()
+	c.Assert(err, IsNil)
+
+	baseIndex, err := base.Index()
+	c.Assert(err, IsNil)
+	c.Assert(baseIndex.Version, Equals, uint32(3))
+}
diff --git a/storage/transactional/module.go b/storage/transactional/module.go
new file mode 100644
index 0000000..d5f5a24
--- /dev/null
+++ b/storage/transactional/module.go
@@ -0,0 +1 @@
+package transactional
diff --git a/storage/transactional/object.go b/storage/transactional/object.go
index 2a46d3c..21490b7 100644
--- a/storage/transactional/object.go
+++ b/storage/transactional/object.go
@@ -61,3 +61,15 @@ func (o *ObjectStorage) IterEncodedObjects(t plumbing.ObjectType) (storer.Encode
 		temporalIter,
 	}), nil
 }
+
+func (o *ObjectStorage) Commit() error {
+	iter, err := o.temporal.IterEncodedObjects(plumbing.AnyObject)
+	if err != nil {
+		return err
+	}
+
+	return iter.ForEach(func(obj plumbing.EncodedObject) error {
+		_, err := o.EncodedObjectStorer.SetEncodedObject(obj)
+		return err
+	})
+}
diff --git a/storage/transactional/object_test.go b/storage/transactional/object_test.go
index ff8cd4e..10b6318 100644
--- a/storage/transactional/object_test.go
+++ b/storage/transactional/object_test.go
@@ -117,3 +117,37 @@ func (s *ObjectSuite) TestIterEncodedObjects(c *C) {
 	c.Assert(hashes[0], Equals, ch)
 	c.Assert(hashes[1], Equals, th)
 }
+
+func (s *ObjectSuite) TestCommit(c *C) {
+	base := memory.NewStorage()
+	temporal := memory.NewStorage()
+
+	os := NewObjectStorage(base, temporal)
+
+	commit := base.NewEncodedObject()
+	commit.SetType(plumbing.CommitObject)
+
+	_, err := os.SetEncodedObject(commit)
+	c.Assert(err, IsNil)
+
+	tree := base.NewEncodedObject()
+	tree.SetType(plumbing.TreeObject)
+
+	_, err = os.SetEncodedObject(tree)
+	c.Assert(err, IsNil)
+
+	err = os.Commit()
+	c.Assert(err, IsNil)
+
+	iter, err := base.IterEncodedObjects(plumbing.AnyObject)
+	c.Assert(err, IsNil)
+
+	var hashes []plumbing.Hash
+	err = iter.ForEach(func(obj plumbing.EncodedObject) error {
+		hashes = append(hashes, obj.Hash())
+		return nil
+	})
+
+	c.Assert(err, IsNil)
+	c.Assert(hashes, HasLen, 2)
+}
diff --git a/storage/transactional/reference.go b/storage/transactional/reference.go
new file mode 100644
index 0000000..2efefd2
--- /dev/null
+++ b/storage/transactional/reference.go
@@ -0,0 +1,126 @@
+package transactional
+
+import (
+	"gopkg.in/src-d/go-git.v4/plumbing"
+	"gopkg.in/src-d/go-git.v4/plumbing/storer"
+	"gopkg.in/src-d/go-git.v4/storage"
+)
+
+type ReferenceStorage struct {
+	storer.ReferenceStorer
+	temporal storer.ReferenceStorer
+
+	// deleted, remaining references at this maps are going to be deleted when
+	// commit is requested, the entries are added when RemoveReference is called
+	// and deleted if SetReference is called.
+	deleted map[plumbing.ReferenceName]struct{}
+	// packRefs if true PackRefs is going to be called in the based storer when
+	// commit is called.
+	packRefs bool
+}
+
+func NewReferenceStorage(s, temporal storer.ReferenceStorer) *ReferenceStorage {
+	return &ReferenceStorage{
+		ReferenceStorer: s,
+		temporal:        temporal,
+
+		deleted: make(map[plumbing.ReferenceName]struct{}, 0),
+	}
+}
+
+func (r *ReferenceStorage) SetReference(ref *plumbing.Reference) error {
+	delete(r.deleted, ref.Name())
+	return r.temporal.SetReference(ref)
+}
+
+func (r *ReferenceStorage) CheckAndSetReference(ref, old *plumbing.Reference) error {
+	if old == nil {
+		return r.SetReference(ref)
+	}
+
+	tmp, err := r.temporal.Reference(old.Name())
+	if err == plumbing.ErrReferenceNotFound {
+		tmp, err = r.ReferenceStorer.Reference(old.Name())
+	}
+
+	if err != nil {
+		return err
+	}
+
+	if tmp.Hash() != old.Hash() {
+		return storage.ErrReferenceHasChanged
+	}
+
+	return r.SetReference(ref)
+}
+
+func (r ReferenceStorage) Reference(n plumbing.ReferenceName) (*plumbing.Reference, error) {
+	if _, deleted := r.deleted[n]; deleted {
+		return nil, plumbing.ErrReferenceNotFound
+	}
+
+	ref, err := r.temporal.Reference(n)
+	if err == plumbing.ErrReferenceNotFound {
+		return r.ReferenceStorer.Reference(n)
+	}
+
+	return ref, err
+}
+
+func (r ReferenceStorage) IterReferences() (storer.ReferenceIter, error) {
+	baseIter, err := r.ReferenceStorer.IterReferences()
+	if err != nil {
+		return nil, err
+	}
+
+	temporalIter, err := r.temporal.IterReferences()
+	if err != nil {
+		return nil, err
+	}
+
+	return storer.NewMultiReferenceIter([]storer.ReferenceIter{
+		baseIter,
+		temporalIter,
+	}), nil
+}
+
+func (r ReferenceStorage) CountLooseRefs() (int, error) {
+	tc, err := r.temporal.CountLooseRefs()
+	if err != nil {
+		return -1, err
+	}
+
+	bc, err := r.ReferenceStorer.CountLooseRefs()
+	if err != nil {
+		return -1, err
+	}
+
+	return tc + bc, nil
+}
+
+func (r ReferenceStorage) PackRefs() error {
+	r.packRefs = true
+	return nil
+}
+
+func (r ReferenceStorage) RemoveReference(n plumbing.ReferenceName) error {
+	r.deleted[n] = struct{}{}
+	return r.temporal.RemoveReference(n)
+}
+
+func (r ReferenceStorage) Commit() error {
+	for name := range r.deleted {
+		if err := r.ReferenceStorer.RemoveReference(name); err != nil {
+			return err
+		}
+	}
+
+	iter, err := r.temporal.IterReferences()
+	if err != nil {
+		return err
+	}
+
+	return iter.ForEach(func(ref *plumbing.Reference) error {
+		return r.ReferenceStorer.SetReference(ref)
+	})
+}
diff --git a/storage/transactional/reference_test.go b/storage/transactional/reference_test.go
new file mode 100644
index 0000000..5793549
--- /dev/null
+++ b/storage/transactional/reference_test.go
@@ -0,0 +1,157 @@
+package transactional
+
+import (
+	. "gopkg.in/check.v1"
+	"gopkg.in/src-d/go-git.v4/plumbing"
+	"gopkg.in/src-d/go-git.v4/storage/memory"
+)
+
+var _ = Suite(&ReferenceSuite{})
+
+type ReferenceSuite struct{}
+
+func (s *ReferenceSuite) TestReference(c *C) {
+	base := memory.NewStorage()
+	temporal := memory.NewStorage()
+
+	rs := NewReferenceStorage(base, temporal)
+
+	refA := plumbing.NewReferenceFromStrings("refs/a", "bc9968d75e48de59f0870ffb71f5e160bbbdcf52")
+	refB := plumbing.NewReferenceFromStrings("refs/b", "bc9968d75e48de59f0870ffb71f5e160bbbdcf52")
+
+	err := base.SetReference(refA)
+	c.Assert(err, IsNil)
+
+	err = rs.SetReference(refB)
+	c.Assert(err, IsNil)
+
+	_, err = rs.Reference("refs/a")
+	c.Assert(err, IsNil)
+
+	_, err = rs.Reference("refs/b")
+	c.Assert(err, IsNil)
+
+	_, err = base.Reference("refs/b")
+	c.Assert(err, Equals, plumbing.ErrReferenceNotFound)
+}
+
+func (s *ReferenceSuite) TestRemoveReferenceTemporal(c *C) {
+	base := memory.NewStorage()
+	temporal := memory.NewStorage()
+
+	ref := plumbing.NewReferenceFromStrings("refs/a", "bc9968d75e48de59f0870ffb71f5e160bbbdcf52")
+
+	rs := NewReferenceStorage(base, temporal)
+	err := rs.SetReference(ref)
+	c.Assert(err, IsNil)
+
+	err = rs.RemoveReference("refs/a")
+	c.Assert(err, IsNil)
+
+	_, err = rs.Reference("refs/a")
+	c.Assert(err, Equals, plumbing.ErrReferenceNotFound)
+}
+
+func (s *ReferenceSuite) TestRemoveReferenceBase(c *C) {
+	base := memory.NewStorage()
+	temporal := memory.NewStorage()
+
+	ref := plumbing.NewReferenceFromStrings("refs/a", "bc9968d75e48de59f0870ffb71f5e160bbbdcf52")
+
+	rs := NewReferenceStorage(base, temporal)
+	err := base.SetReference(ref)
+	c.Assert(err, IsNil)
+
+	err = rs.RemoveReference("refs/a")
+	c.Assert(err, IsNil)
+
+	_, err = rs.Reference("refs/a")
+	c.Assert(err, Equals, plumbing.ErrReferenceNotFound)
+}
+
+func (s *ReferenceSuite) TestCheckAndSetReferenceInBase(c *C) {
+	base := memory.NewStorage()
+	temporal := memory.NewStorage()
+	rs := NewReferenceStorage(base, temporal)
+
+	err := base.SetReference(
+		plumbing.NewReferenceFromStrings("foo", "482e0eada5de4039e6f216b45b3c9b683b83bfa"),
+	)
+	c.Assert(err, IsNil)
+
+	err = rs.CheckAndSetReference(
+		plumbing.NewReferenceFromStrings("foo", "bc9968d75e48de59f0870ffb71f5e160bbbdcf52"),
+		plumbing.NewReferenceFromStrings("foo", "482e0eada5de4039e6f216b45b3c9b683b83bfa"),
+	)
+	c.Assert(err, IsNil)
+
+	e, err := rs.Reference(plumbing.ReferenceName("foo"))
+	c.Assert(err, IsNil)
+	c.Assert(e.Hash().String(), Equals, "bc9968d75e48de59f0870ffb71f5e160bbbdcf52")
+}
+
+func (s *ReferenceSuite) TestCommit(c *C) {
+	base := memory.NewStorage()
+	temporal := memory.NewStorage()
+
+	refA := plumbing.NewReferenceFromStrings("refs/a", "bc9968d75e48de59f0870ffb71f5e160bbbdcf52")
+	refB := plumbing.NewReferenceFromStrings("refs/b", "b66c08ba28aa1f81eb06a1127aa3936ff77e5e2c")
+	refC := plumbing.NewReferenceFromStrings("refs/c", "c3f4688a08fd86f1bf8e055724c84b7a40a09733")
+
+	rs := NewReferenceStorage(base, temporal)
+	c.Assert(rs.SetReference(refA), IsNil)
+	c.Assert(rs.SetReference(refB), IsNil)
+	c.Assert(rs.SetReference(refC), IsNil)
+
+	err := rs.Commit()
+	c.Assert(err, IsNil)
+
+	iter, err := base.IterReferences()
+	c.Assert(err, IsNil)
+
+	var count int
+	iter.ForEach(func(ref *plumbing.Reference) error {
+		count++
+		return nil
+	})
+
+	c.Assert(count, Equals, 3)
+}
+
+func (s *ReferenceSuite) TestCommitDelete(c *C) {
+	base := memory.NewStorage()
+	temporal := memory.NewStorage()
+
+	refA := plumbing.NewReferenceFromStrings("refs/a", "bc9968d75e48de59f0870ffb71f5e160bbbdcf52")
+	refB := plumbing.NewReferenceFromStrings("refs/b", "b66c08ba28aa1f81eb06a1127aa3936ff77e5e2c")
+	refC := plumbing.NewReferenceFromStrings("refs/c", "c3f4688a08fd86f1bf8e055724c84b7a40a09733")
+
+	rs := NewReferenceStorage(base, temporal)
+	c.Assert(base.SetReference(refA), IsNil)
+	c.Assert(base.SetReference(refB), IsNil)
+	c.Assert(base.SetReference(refC), IsNil)
+
+	c.Assert(rs.RemoveReference(refA.Name()), IsNil)
+	c.Assert(rs.RemoveReference(refB.Name()), IsNil)
+	c.Assert(rs.RemoveReference(refC.Name()), IsNil)
+	c.Assert(rs.SetReference(refC), IsNil)
+
+	err := rs.Commit()
+	c.Assert(err, IsNil)
+
+	iter, err := base.IterReferences()
+	c.Assert(err, IsNil)
+
+	var count int
+	iter.ForEach(func(ref *plumbing.Reference) error {
+		count++
+		return nil
+	})
+
+	c.Assert(count, Equals, 1)
+
+	ref, err := rs.Reference(refC.Name())
+	c.Assert(err, IsNil)
+	c.Assert(ref.Hash().String(), Equals, "c3f4688a08fd86f1bf8e055724c84b7a40a09733")
+
+}
diff --git a/storage/transactional/shallow.go b/storage/transactional/shallow.go
new file mode 100644
index 0000000..07663d4
--- /dev/null
+++ b/storage/transactional/shallow.go
@@ -0,0 +1,44 @@
+package transactional
+
+import (
+	"gopkg.in/src-d/go-git.v4/plumbing"
+	"gopkg.in/src-d/go-git.v4/plumbing/storer"
+)
+
+type ShallowStorage struct {
+	storer.ShallowStorer
+	temporal storer.ShallowStorer
+}
+
+func NewShallowStorage(s, temporal storer.ShallowStorer) *ShallowStorage {
+	return &ShallowStorage{
+		ShallowStorer: s,
+		temporal:      temporal,
+	}
+}
+
+func (s *ShallowStorage) SetShallow(commits []plumbing.Hash) error {
+	return s.temporal.SetShallow(commits)
+}
+
+func (s *ShallowStorage) Shallow() ([]plumbing.Hash, error) {
+	shallow, err := s.temporal.Shallow()
+	if err != nil {
+		return nil, err
+	}
+
+	if len(shallow) != 0 {
+		return shallow, nil
+	}
+
+	return s.ShallowStorer.Shallow()
+}
+
+func (s *ShallowStorage) Commit() error {
+	commits, err := s.temporal.Shallow()
+	if err != nil || len(commits) == 0 {
+		return err
+	}
+
+	return s.ShallowStorer.SetShallow(commits)
+}
diff --git a/storage/transactional/shallow_test.go b/storage/transactional/shallow_test.go
new file mode 100644
index 0000000..5141782
--- /dev/null
+++ b/storage/transactional/shallow_test.go
@@ -0,0 +1,62 @@
+package transactional
+
+import (
+	. "gopkg.in/check.v1"
+	"gopkg.in/src-d/go-git.v4/plumbing"
+	"gopkg.in/src-d/go-git.v4/storage/memory"
+)
+
+var _ = Suite(&ShallowSuite{})
+
+type ShallowSuite struct{}
+
+func (s *ShallowSuite) TestShallow(c *C) {
+	base := memory.NewStorage()
+	temporal := memory.NewStorage()
+
+	rs := NewShallowStorage(base, temporal)
+
+	commitA := plumbing.NewHash("bc9968d75e48de59f0870ffb71f5e160bbbdcf52")
+	commitB := plumbing.NewHash("aa9968d75e48de59f0870ffb71f5e160bbbdcf52")
+
+	err := base.SetShallow([]plumbing.Hash{commitA})
+	c.Assert(err, IsNil)
+
+	err = rs.SetShallow([]plumbing.Hash{commitB})
+	c.Assert(err, IsNil)
+
+	commits, err := rs.Shallow()
+	c.Assert(err, IsNil)
+	c.Assert(commits, HasLen, 1)
+	c.Assert(commits[0], Equals, commitB)
+
+	commits, err = base.Shallow()
+	c.Assert(err, IsNil)
+	c.Assert(commits, HasLen, 1)
+	c.Assert(commits[0], Equals, commitA)
+}
+
+func (s *ShallowSuite) TestCommit(c *C) {
+	base := memory.NewStorage()
+	temporal := memory.NewStorage()
+
+	rs := NewShallowStorage(base, temporal)
+
+	commitA := plumbing.NewHash("bc9968d75e48de59f0870ffb71f5e160bbbdcf52")
+	commitB := plumbing.NewHash("aa9968d75e48de59f0870ffb71f5e160bbbdcf52")
+
+	c.Assert(base.SetShallow([]plumbing.Hash{commitA}), IsNil)
+	c.Assert(rs.SetShallow([]plumbing.Hash{commitB}), IsNil)
+
+	c.Assert(rs.Commit(), IsNil)
+
+	commits, err := rs.Shallow()
+	c.Assert(err, IsNil)
+	c.Assert(commits, HasLen, 1)
+	c.Assert(commits[0], Equals, commitB)
+
+	commits, err = base.Shallow()
+	c.Assert(err, IsNil)
+	c.Assert(commits, HasLen, 1)
+	c.Assert(commits[0], Equals, commitB)
+}
diff --git a/storage/transactional/storage.go b/storage/transactional/storage.go
index d5f5a24..6611a43 100644
--- a/storage/transactional/storage.go
+++ b/storage/transactional/storage.go
@@ -1 +1,61 @@
 package transactional
+
+import (
+	"gopkg.in/src-d/go-git.v4/storage"
+)
+
+// Storage is an implementation of git.Storer that stores data on disk in the
+// standard git format (this is, the .git directory). Zero values of this type
+// are not safe to use, see the NewStorage function below.
+type Storage struct {
+	s, temporal storage.Storer
+
+	*ObjectStorage
+	*ReferenceStorage
+	*IndexStorage
+	*ShallowStorage
+	*ConfigStorage
+}
+
+func NewStorage(s, temporal storage.Storer) *Storage {
+	return &Storage{
+		s:        s,
+		temporal: temporal,
+
+		ObjectStorage:    NewObjectStorage(s, temporal),
+		ReferenceStorage: NewReferenceStorage(s, temporal),
+		IndexStorage:     NewIndexStorage(s, temporal),
+		ShallowStorage:   NewShallowStorage(s, temporal),
+		ConfigStorage:    NewConfigStorage(s, temporal),
+	}
+}
+
+func (s *Storage) Module(name string) (storage.Storer, error) {
+	base, err := s.s.Module(name)
+	if err != nil {
+		return nil, err
+	}
+
+	temporal, err := s.temporal.Module(name)
+	if err != nil {
+		return nil, err
+	}
+
+	return NewStorage(base, temporal), nil
+}
+
+func (s *Storage) Commit() error {
+	for _, c := range []interface{ Commit() error }{
+		s.ObjectStorage,
+		s.ReferenceStorage,
+		s.IndexStorage,
+		s.ShallowStorage,
+		s.ConfigStorage,
+	} {
+		if err := c.Commit(); err != nil {
+			return err
+		}
+	}
+
+	return nil
+}
diff --git a/storage/transactional/storage_test.go b/storage/transactional/storage_test.go
new file mode 100644
index 0000000..6aaea0d
--- /dev/null
+++ b/storage/transactional/storage_test.go
@@ -0,0 +1,52 @@
+package transactional
+
+import (
+	"testing"
+
+	. "gopkg.in/check.v1"
+	"gopkg.in/src-d/go-git.v4/plumbing"
+	"gopkg.in/src-d/go-git.v4/storage/memory"
+	"gopkg.in/src-d/go-git.v4/storage/test"
+)
+
+func Test(t *testing.T) { TestingT(t) }
+
+type StorageSuite struct {
+	test.BaseStorageSuite
+}
+
+var _ = Suite(&StorageSuite{})
+
+func (s *StorageSuite) SetUpTest(c *C) {
+	base := memory.NewStorage()
+	temporal := memory.NewStorage()
+
+	s.BaseStorageSuite = test.NewBaseStorageSuite(NewStorage(base, temporal))
+	s.BaseStorageSuite.SetUpTest(c)
+}
+
+func (s *StorageSuite) TestCommit(c *C) {
+	base := memory.NewStorage()
+	temporal := memory.NewStorage()
+	st := NewStorage(base, temporal)
+
+	commit := base.NewEncodedObject()
+	commit.SetType(plumbing.CommitObject)
+
+	_, err := st.SetEncodedObject(commit)
+	c.Assert(err, IsNil)
+
+	ref := plumbing.NewHashReference("refs/a", commit.Hash())
+	c.Assert(st.SetReference(ref), IsNil)
+
+	err = st.Commit()
+	c.Assert(err, IsNil)
+
+	ref, err = base.Reference(ref.Name())
+	c.Assert(err, IsNil)
+	c.Assert(ref.Hash(), Equals, commit.Hash())
+
+	obj, err := base.EncodedObject(plumbing.AnyObject, commit.Hash())
+	c.Assert(err, IsNil)
+	c.Assert(obj.Hash(), Equals, commit.Hash())
+}