diff options
| author | zeripath <art27@cantab.net> | 2021-05-12 21:42:07 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-12 22:42:07 +0200 |
| commit | 720c192831a890d0a36b4c6720b60411fa4a0159 (patch) | |
| tree | 9f3020c074fe9b113e22d6f2c601e8a36bf0ac49 /storage/filesystem/object.go | |
| parent | e6e23391e4d044cc85e09b4420a2533715e7312d (diff) | |
| download | go-git-720c192831a890d0a36b4c6720b60411fa4a0159.tar.gz | |
plumbing: format/packfile, prevent large objects from being read into memory completely (#303)v5.4.0
This PR adds code to prevent large objects from being read into memory from packfiles or the filesystem.
Objects greater than 1Mb are now no longer directly stored in the cache
or read completely into memory.
Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'storage/filesystem/object.go')
| -rw-r--r-- | storage/filesystem/object.go | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/storage/filesystem/object.go b/storage/filesystem/object.go index 0c25dad..4862362 100644 --- a/storage/filesystem/object.go +++ b/storage/filesystem/object.go @@ -389,7 +389,6 @@ func (s *ObjectStorage) getFromUnpacked(h plumbing.Hash) (obj plumbing.EncodedOb return cacheObj, nil } - obj = s.NewEncodedObject() r, err := objfile.NewReader(f) if err != nil { return nil, err @@ -402,6 +401,14 @@ func (s *ObjectStorage) getFromUnpacked(h plumbing.Hash) (obj plumbing.EncodedOb return nil, err } + if size > packfile.LargeObjectThreshold { + obj = dotgit.NewEncodedObject(s.dir, h, t, size) + s.objectCache.Put(obj) + return obj, nil + } + + obj = s.NewEncodedObject() + obj.SetType(t) obj.SetSize(size) w, err := obj.Writer() |