aboutsummaryrefslogtreecommitdiffstats
path: root/storage/filesystem/dotgit/dotgit_test.go
diff options
context:
space:
mode:
authorKyle Evans <kevans@FreeBSD.org>2020-04-23 17:47:05 -0500
committerKyle Evans <kevans@FreeBSD.org>2020-04-23 18:19:22 -0500
commit63967abe62ecba22a792e728f1af509f3604881f (patch)
tree2046075da6803e110c9d6272d0f49f9f7020d7d3 /storage/filesystem/dotgit/dotgit_test.go
parent9c7d576132a760645e3a6b3ebdf51c4aef532794 (diff)
downloadgo-git-63967abe62ecba22a792e728f1af509f3604881f.tar.gz
storage/filesystem: dotgit, sanity check provided reference path
On some operating systems, read() of a directory fd may actually succeed and return garbage resembling on-disk contents. As a result, dotgit may return successful from readReferenceFile() when it should in-fact not. This fixes readReferenceFile() on FreeBSD. Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
Diffstat (limited to 'storage/filesystem/dotgit/dotgit_test.go')
-rw-r--r--storage/filesystem/dotgit/dotgit_test.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/storage/filesystem/dotgit/dotgit_test.go b/storage/filesystem/dotgit/dotgit_test.go
index 403f5ff..519f601 100644
--- a/storage/filesystem/dotgit/dotgit_test.go
+++ b/storage/filesystem/dotgit/dotgit_test.go
@@ -118,7 +118,7 @@ func testSetRefs(c *C, dir *DotGit) {
c.Assert(err, IsNil)
_, err = dir.readReferenceFile(".", "refs/heads/feature")
- c.Assert(err, NotNil)
+ c.Assert(err, Equals, ErrIsDir)
ref, err = dir.Ref("refs/heads/foo")
c.Assert(err, IsNil)