Repository.Clone and Remote.Fetch tests and improvements

1 files changed, 71 insertions, 11 deletions

diff --git a/remote_test.go b/remote_test.go
index df93b59..798d75d 100644
--- a/remote_test.go
+++ b/remote_test.go
@@ -3,6 +3,7 @@ package git
 import (
 	"gopkg.in/src-d/go-git.v4/clients/http"
 	"gopkg.in/src-d/go-git.v4/core"
+	"gopkg.in/src-d/go-git.v4/storage/memory"
 
 	. "gopkg.in/check.v1"
 )
@@ -13,10 +14,29 @@ type RemoteSuite struct {
 
 var _ = Suite(&RemoteSuite{})
 
+func (s *RemoteSuite) TestNewRemote(c *C) {
+	r, err := NewRemote(RepositoryFixture)
+	c.Assert(err, IsNil)
+	c.Assert(r.Endpoint.String(), Equals, RepositoryFixture)
+}
+
+func (s *RemoteSuite) TestNewRemoteInvalidEndpoint(c *C) {
+	r, err := NewRemote("qux")
+	c.Assert(err, NotNil)
+	c.Assert(r, IsNil)
+}
+
+func (s *RemoteSuite) TestNewRemoteInvalidSchemaEndpoint(c *C) {
+	r, err := NewRemote("qux://foo")
+	c.Assert(err, NotNil)
+	c.Assert(r, IsNil)
+}
+
 func (s *RemoteSuite) TestNewAuthenticatedRemote(c *C) {
 	a := &http.BasicAuth{}
 	r, err := NewAuthenticatedRemote(RepositoryFixture, a)
 	c.Assert(err, IsNil)
+	c.Assert(r.Endpoint.String(), Equals, RepositoryFixture)
 	c.Assert(r.Auth, Equals, a)
 }
 
@@ -26,6 +46,15 @@ func (s *RemoteSuite) TestConnect(c *C) {
 	c.Assert(r.Connect(), IsNil)
 }
 
+func (s *RemoteSuite) TestInfo(c *C) {
+	r, err := NewRemote(RepositoryFixture)
+	c.Assert(err, IsNil)
+	c.Assert(r.Info(), IsNil)
+	c.Assert(r.Connect(), IsNil)
+	c.Assert(r.Info(), NotNil)
+	c.Assert(r.Info().Capabilities.Get("ofs-delta"), NotNil)
+}
+
 func (s *RemoteSuite) TestDefaultBranch(c *C) {
 	r, err := NewRemote(RepositoryFixture)
 	r.upSrv = &MockGitUploadPackService{}
@@ -44,7 +73,6 @@ func (s *RemoteSuite) TestCapabilities(c *C) {
 	c.Assert(r.Capabilities().Get("agent").Values, HasLen, 1)
 }
 
-/*
 func (s *RemoteSuite) TestFetch(c *C) {
 	r, err := NewRemote(RepositoryFixture)
 	r.upSrv = &MockGitUploadPackService{}
@@ -52,31 +80,63 @@ func (s *RemoteSuite) TestFetch(c *C) {
 	c.Assert(err, IsNil)
 	c.Assert(r.Connect(), IsNil)
 
-	req := &common.GitUploadPackRequest{}
-	req.Want(r.Head().Hash())
+	sto := memory.NewObjectStorage()
+	err = r.Fetch(sto, &FetchOptions{
+		ReferenceName: core.HEAD,
+	})
 
-	reader, err := r.Fetch(req)
 	c.Assert(err, IsNil)
+	c.Assert(sto.Objects, HasLen, 28)
+}
 
-	packfileReader := packfile.NewStream(reader)
-	d := packfile.NewDecoder(packfileReader)
+func (s *RemoteSuite) TestFetchInvalidBranch(c *C) {
+	r, err := NewRemote(RepositoryFixture)
+	r.upSrv = &MockGitUploadPackService{}
 
-	sto := memory.NewObjectStorage()
-	err = d.Decode(sto)
 	c.Assert(err, IsNil)
-	c.Assert(sto.Objects, HasLen, 28)
+	c.Assert(r.Connect(), IsNil)
+
+	sto := memory.NewObjectStorage()
+	err = r.Fetch(sto, &FetchOptions{
+		ReferenceName: core.ReferenceName("qux"),
+	})
+
+	c.Assert(err, NotNil)
 }
-*/
 
 func (s *RemoteSuite) TestHead(c *C) {
 	r, err := NewRemote(RepositoryFixture)
 	r.upSrv = &MockGitUploadPackService{}
+	c.Assert(err, IsNil)
 
+	err = r.Connect()
+	c.Assert(err, IsNil)
+	c.Assert(r.Head().Hash(), Equals, core.NewHash("6ecf0ef2c2dffb796033e5a02219af86ec6584e5"))
+}
+
+func (s *RemoteSuite) TestRef(c *C) {
+	r, err := NewRemote(RepositoryFixture)
+	r.upSrv = &MockGitUploadPackService{}
 	c.Assert(err, IsNil)
 
 	err = r.Connect()
 	c.Assert(err, IsNil)
 
+	ref, err := r.Ref(core.HEAD, false)
 	c.Assert(err, IsNil)
-	c.Assert(r.Head().Hash(), Equals, core.NewHash("6ecf0ef2c2dffb796033e5a02219af86ec6584e5"))
+	c.Assert(ref.Name(), Equals, core.HEAD)
+
+	ref, err = r.Ref(core.HEAD, true)
+	c.Assert(err, IsNil)
+	c.Assert(ref.Name(), Equals, core.ReferenceName("refs/heads/master"))
+}
+
+func (s *RemoteSuite) TestRefs(c *C) {
+	r, err := NewRemote(RepositoryFixture)
+	r.upSrv = &MockGitUploadPackService{}
+	c.Assert(err, IsNil)
+
+	err = r.Connect()
+	c.Assert(err, IsNil)
+	c.Assert(r.Refs(), NotNil)
 }