aboutsummaryrefslogtreecommitdiffstats
path: root/plumbing
diff options
context:
space:
mode:
authorSantiago M. Mola <santi@mola.io>2017-03-01 12:49:19 +0100
committerGitHub <noreply@github.com>2017-03-01 12:49:19 +0100
commitf0affc5579ec907c3092b125ff35b0359b8c4e49 (patch)
treea1c0ff7078075d57fe0fc5986ad2ef721402c507 /plumbing
parentab6f224e98d876beb8c146497c60717b4fe56b2a (diff)
parent9251df17028a86cb0a0d486a3cd7e0b3eb2947f6 (diff)
downloadgo-git-f0affc5579ec907c3092b125ff35b0359b8c4e49.tar.gz
Merge pull request #294 from ajnavarro/improvement/todos-documentation
Remove TODOs from documentation
Diffstat (limited to 'plumbing')
-rw-r--r--plumbing/protocol/packp/srvresp.go2
-rw-r--r--plumbing/protocol/packp/updreq.go2
-rw-r--r--plumbing/transport/internal/common/common.go10
-rw-r--r--plumbing/transport/server/server.go2
4 files changed, 8 insertions, 8 deletions
diff --git a/plumbing/protocol/packp/srvresp.go b/plumbing/protocol/packp/srvresp.go
index 95e1e57..4c1d6db 100644
--- a/plumbing/protocol/packp/srvresp.go
+++ b/plumbing/protocol/packp/srvresp.go
@@ -14,13 +14,13 @@ const ackLineLen = 44
// ServerResponse object acknowledgement from upload-pack service
type ServerResponse struct {
- // TODO: implement support for multi_ack or multi_ack_detailed responses
ACKs []plumbing.Hash
}
// Decode decodes the response into the struct, isMultiACK should be true, if
// the request was done with multi_ack or multi_ack_detailed capabilities
func (r *ServerResponse) Decode(reader io.Reader, isMultiACK bool) error {
+ // TODO: implement support for multi_ack or multi_ack_detailed responses
if isMultiACK {
return errors.New("multi_ack and multi_ack_detailed are not supported")
}
diff --git a/plumbing/protocol/packp/updreq.go b/plumbing/protocol/packp/updreq.go
index 4337ace..0f6a65a 100644
--- a/plumbing/protocol/packp/updreq.go
+++ b/plumbing/protocol/packp/updreq.go
@@ -16,7 +16,6 @@ var (
// ReferenceUpdateRequest values represent reference upload requests.
// Values from this type are not zero-value safe, use the New function instead.
type ReferenceUpdateRequest struct {
- // TODO: Add support for push-cert
Capabilities *capability.List
Commands []*Command
Shallow *plumbing.Hash
@@ -27,6 +26,7 @@ type ReferenceUpdateRequest struct {
// New returns a pointer to a new ReferenceUpdateRequest value.
func NewReferenceUpdateRequest() *ReferenceUpdateRequest {
return &ReferenceUpdateRequest{
+ // TODO: Add support for push-cert
Capabilities: capability.NewList(),
Commands: nil,
}
diff --git a/plumbing/transport/internal/common/common.go b/plumbing/transport/internal/common/common.go
index ab62a32..d089978 100644
--- a/plumbing/transport/internal/common/common.go
+++ b/plumbing/transport/internal/common/common.go
@@ -361,12 +361,12 @@ var (
)
// uploadPack implements the git-upload-pack protocol.
-//
-// TODO support multi_ack mode
-// TODO support multi_ack_detailed mode
-// TODO support acks for common objects
-// TODO build a proper state machine for all these processing options
func uploadPack(w io.WriteCloser, r io.Reader, req *packp.UploadPackRequest) error {
+ // TODO support multi_ack mode
+ // TODO support multi_ack_detailed mode
+ // TODO support acks for common objects
+ // TODO build a proper state machine for all these processing options
+
if err := req.UploadRequest.Encode(w); err != nil {
return fmt.Errorf("sending upload-req message: %s", err)
}
diff --git a/plumbing/transport/server/server.go b/plumbing/transport/server/server.go
index 457240f..c670d19 100644
--- a/plumbing/transport/server/server.go
+++ b/plumbing/transport/server/server.go
@@ -406,8 +406,8 @@ func setHEAD(s storer.Storer, ar *packp.AdvRefs) error {
return nil
}
-//TODO: add peeled references.
func setReferences(s storer.Storer, ar *packp.AdvRefs) error {
+ //TODO: add peeled references.
iter, err := s.IterReferences()
if err != nil {
return err