plumbing: transport/common, Improve handling of remote errors

Instead of simply returning the first line that the remote returned,
go-git now actively searches all of stderr for lines that may contain
a more actionable error message and returns that.

In addition, this change adds a case to map the GitLab-specific error
message to an ErrRepositoryNotFound error.

Signed-off-by: Max Jonas Werner <mail@makk.es>

1 files changed, 46 insertions, 0 deletions

diff --git a/plumbing/transport/internal/common/mocks.go b/plumbing/transport/internal/common/mocks.go
new file mode 100644
index 0000000..bc18b27
--- /dev/null
+++ b/plumbing/transport/internal/common/mocks.go
@@ -0,0 +1,46 @@
+package common
+
+import (
+	"bytes"
+	"io"
+
+	gogitioutil "github.com/go-git/go-git/v5/utils/ioutil"
+
+	"github.com/go-git/go-git/v5/plumbing/transport"
+)
+
+type MockCommand struct {
+	stdin  bytes.Buffer
+	stdout bytes.Buffer
+	stderr bytes.Buffer
+}
+
+func (c MockCommand) StderrPipe() (io.Reader, error) {
+	return &c.stderr, nil
+}
+
+func (c MockCommand) StdinPipe() (io.WriteCloser, error) {
+	return gogitioutil.WriteNopCloser(&c.stdin), nil
+}
+
+func (c MockCommand) StdoutPipe() (io.Reader, error) {
+	return &c.stdout, nil
+}
+
+func (c MockCommand) Start() error {
+	return nil
+}
+
+func (c MockCommand) Close() error {
+	panic("not implemented")
+}
+
+type MockCommander struct {
+	stderr string
+}
+
+func (c MockCommander) Command(cmd string, ep *transport.Endpoint, auth transport.AuthMethod) (Command, error) {
+	return &MockCommand{
+		stderr: *bytes.NewBufferString(c.stderr),
+	}, nil
+}