diff options
| author | Javi Fontan <jfontan@gmail.com> | 2018-03-26 23:18:54 +0200 |
|---|---|---|
| committer | Javi Fontan <jfontan@gmail.com> | 2018-03-27 17:32:59 +0200 |
| commit | 05c414a169a75ca933402e5be19a5c4304aa4f00 (patch) | |
| tree | 19dcd85c5d221cf41fa06c200423d5cc236f9f31 /plumbing/transport/http | |
| parent | 160e6d5b654fbbaf0d9264f226c56a03f0e27d30 (diff) | |
| download | go-git-05c414a169a75ca933402e5be19a5c4304aa4f00.tar.gz | |
*: Use CheckClose with named returns
Previously some close errors were losts. This is specially problematic
in go-git as lots of work is done here like generating indexes and
moving packfiles.
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Diffstat (limited to 'plumbing/transport/http')
| -rw-r--r-- | plumbing/transport/http/common.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/plumbing/transport/http/common.go b/plumbing/transport/http/common.go index 24e63a4..2c337b7 100644 --- a/plumbing/transport/http/common.go +++ b/plumbing/transport/http/common.go @@ -31,7 +31,7 @@ func applyHeadersToRequest(req *http.Request, content *bytes.Buffer, host string const infoRefsPath = "/info/refs" -func advertisedReferences(s *session, serviceName string) (*packp.AdvRefs, error) { +func advertisedReferences(s *session, serviceName string) (ref *packp.AdvRefs, err error) { url := fmt.Sprintf( "%s%s?service=%s", s.endpoint.String(), infoRefsPath, serviceName, @@ -52,12 +52,12 @@ func advertisedReferences(s *session, serviceName string) (*packp.AdvRefs, error s.ModifyEndpointIfRedirect(res) defer ioutil.CheckClose(res.Body, &err) - if err := NewErr(res); err != nil { + if err = NewErr(res); err != nil { return nil, err } ar := packp.NewAdvRefs() - if err := ar.Decode(res.Body); err != nil { + if err = ar.Decode(res.Body); err != nil { if err == packp.ErrEmptyAdvRefs { err = transport.ErrEmptyRemoteRepository } |