diff options
| author | matej.risek <matej.risek@hashicorp.com> | 2023-07-12 14:40:09 +0200 |
|---|---|---|
| committer | matej.risek <matej.risek@hashicorp.com> | 2023-09-05 17:09:59 +0200 |
| commit | 5ad72db3bd60351da9ab42727952654e3ad5bcb2 (patch) | |
| tree | 35179f19c30d4cc31c8c9a0d5957e66c11e98dd5 /plumbing/transport/http/common_test.go | |
| parent | cd3a21c619126288123c32f4a714181f9e1a68f8 (diff) | |
| download | go-git-5ad72db3bd60351da9ab42727952654e3ad5bcb2.tar.gz | |
plumbing: Do not swallow http message coming from VCS providers.
For diagnostics reasons we want to surface error messages coming from VCS providers.
That's why we introduce the reason field to Err struct in http package.
This field can be used by an end user of the library in order to better understand failures.
Diffstat (limited to 'plumbing/transport/http/common_test.go')
| -rw-r--r-- | plumbing/transport/http/common_test.go | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/plumbing/transport/http/common_test.go b/plumbing/transport/http/common_test.go index 1517228..6bd018b 100644 --- a/plumbing/transport/http/common_test.go +++ b/plumbing/transport/http/common_test.go @@ -3,6 +3,7 @@ package http import ( "crypto/tls" "fmt" + "io" "log" "net" "net/http" @@ -14,6 +15,7 @@ import ( "strings" "testing" + "github.com/go-git/go-git/v5/plumbing" "github.com/go-git/go-git/v5/plumbing/transport" fixtures "github.com/go-git/go-git-fixtures/v4" @@ -90,6 +92,23 @@ func (s *ClientSuite) TestNewHTTPError40x(c *C) { "unexpected client error.*") } +func (s *ClientSuite) TestNewUnexpectedError(c *C) { + res := &http.Response{ + StatusCode: 500, + Body: io.NopCloser(strings.NewReader("Unexpected error")), + } + + err := NewErr(res) + c.Assert(err, NotNil) + c.Assert(err, FitsTypeOf, &plumbing.UnexpectedError{}) + + unexpectedError, _ := err.(*plumbing.UnexpectedError) + c.Assert(unexpectedError.Err, FitsTypeOf, &Err{}) + + httpError, _ := unexpectedError.Err.(*Err) + c.Assert(httpError.Reason, Equals, "Unexpected error") +} + func (s *ClientSuite) Test_newSession(c *C) { cl := NewClientWithOptions(nil, &ClientOptions{ CacheMaxEntries: 2, |