diff options
| author | Santiago M. Mola <santi@mola.io> | 2016-11-25 09:25:49 +0100 |
|---|---|---|
| committer | Máximo Cuadros <mcuadros@gmail.com> | 2016-11-25 09:25:49 +0100 |
| commit | 9e34f68d980de57631c588aaa910c9ea95ed7c2e (patch) | |
| tree | b1bd9f867b757ca46ada2f349d122723dde3529c /plumbing/transport/fetch_pack_test.go | |
| parent | 8966c042795509ed17730e50d352ad69901c3da8 (diff) | |
| download | go-git-9e34f68d980de57631c588aaa910c9ea95ed7c2e.tar.gz | |
plumbing/transport: add common tests and fixes. (#136)
* plumbing/transport: add common tests and fixes.
* add common test suite for different transport implementations.
* fix different behaviour on error handling for ssh and http.
fixes issue #123.
* support detecting unexisting repositories with SSH + GitHub/Bitbucket
(apparently, there is no standard for all SSH servers).
* remove ssh.NewClient (only DefaultClient makes sense at the moment).
* make ssh.Client and http.Client private.
* utils/ioutil: utilities to work with io interfaces.
* * transport: test actual objects fetched, not just packfile size.
* * fix doc typo.
* * improve UploadPackRequest.IsEmpty
Diffstat (limited to 'plumbing/transport/fetch_pack_test.go')
| -rw-r--r-- | plumbing/transport/fetch_pack_test.go | 25 |
1 files changed, 24 insertions, 1 deletions
diff --git a/plumbing/transport/fetch_pack_test.go b/plumbing/transport/fetch_pack_test.go index 7a7f86f..16112a9 100644 --- a/plumbing/transport/fetch_pack_test.go +++ b/plumbing/transport/fetch_pack_test.go @@ -5,6 +5,7 @@ import ( "encoding/base64" "gopkg.in/src-d/go-git.v4/plumbing" + "gopkg.in/src-d/go-git.v4/plumbing/format/packp/advrefs" . "gopkg.in/check.v1" ) @@ -58,7 +59,7 @@ func (s *UploadPackSuite) TestUploadPackInfoEmpty(c *C) { i := NewUploadPackInfo() err := i.Decode(b) - c.Assert(err, ErrorMatches, "permanent.*empty.*") + c.Assert(err, Equals, advrefs.ErrEmpty) } func (s *UploadPackSuite) TestUploadPackEncode(c *C) { @@ -94,3 +95,25 @@ func (s *UploadPackSuite) TestUploadPackRequest(c *C) { "0009done\n", ) } + +func (s *UploadPackSuite) TestUploadPackRequest_IsEmpty(c *C) { + r := &UploadPackRequest{} + r.Want(plumbing.NewHash("d82f291cde9987322c8a0c81a325e1ba6159684c")) + r.Want(plumbing.NewHash("2b41ef280fdb67a9b250678686a0c3e03b0a9989")) + r.Have(plumbing.NewHash("6ecf0ef2c2dffb796033e5a02219af86ec6584e5")) + + c.Assert(r.IsEmpty(), Equals, false) + + r = &UploadPackRequest{} + r.Want(plumbing.NewHash("d82f291cde9987322c8a0c81a325e1ba6159684c")) + r.Want(plumbing.NewHash("2b41ef280fdb67a9b250678686a0c3e03b0a9989")) + r.Have(plumbing.NewHash("d82f291cde9987322c8a0c81a325e1ba6159684c")) + + c.Assert(r.IsEmpty(), Equals, false) + + r = &UploadPackRequest{} + r.Want(plumbing.NewHash("d82f291cde9987322c8a0c81a325e1ba6159684c")) + r.Have(plumbing.NewHash("d82f291cde9987322c8a0c81a325e1ba6159684c")) + + c.Assert(r.IsEmpty(), Equals, true) +} |