diff options
| author | Paulo Gomes <pjbgf@linux.com> | 2023-12-01 09:21:30 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-12-01 09:21:30 +0000 |
| commit | cc1895b905ebadb09504d88444ff05932fa6e928 (patch) | |
| tree | 4407dac9eb1960679355ded29df421cf533d2140 /plumbing/reference_test.go | |
| parent | d87110b492c94d99ebdaea732b23a54b7efba94b (diff) | |
| parent | de1d5a5978b9599ca3dacd58bbf699e4bb4cf6bd (diff) | |
| download | go-git-cc1895b905ebadb09504d88444ff05932fa6e928.tar.gz | |
Merge pull request #950 from aymanbagabas/validate-ref
git: validate reference names (#929)
Diffstat (limited to 'plumbing/reference_test.go')
| -rw-r--r-- | plumbing/reference_test.go | 59 |
1 files changed, 59 insertions, 0 deletions
diff --git a/plumbing/reference_test.go b/plumbing/reference_test.go index 04dfef9..ce57075 100644 --- a/plumbing/reference_test.go +++ b/plumbing/reference_test.go @@ -103,6 +103,65 @@ func (s *ReferenceSuite) TestIsTag(c *C) { c.Assert(r.IsTag(), Equals, true) } +func (s *ReferenceSuite) TestValidReferenceNames(c *C) { + valid := []ReferenceName{ + "refs/heads/master", + "refs/notes/commits", + "refs/remotes/origin/master", + "HEAD", + "refs/tags/v3.1.1", + "refs/pulls/1/head", + "refs/pulls/1/merge", + "refs/pulls/1/abc.123", + "refs/pulls", + "refs/-", // should this be allowed? + } + for _, v := range valid { + c.Assert(v.Validate(), IsNil) + } + + invalid := []ReferenceName{ + "refs", + "refs/", + "refs//", + "refs/heads/\\", + "refs/heads/\\foo", + "refs/heads/\\foo/bar", + "abc", + "", + "refs/heads/ ", + "refs/heads/ /", + "refs/heads/ /foo", + "refs/heads/.", + "refs/heads/..", + "refs/heads/foo..", + "refs/heads/foo.lock", + "refs/heads/foo@{bar}", + "refs/heads/foo[", + "refs/heads/foo~", + "refs/heads/foo^", + "refs/heads/foo:", + "refs/heads/foo?", + "refs/heads/foo*", + "refs/heads/foo[bar", + "refs/heads/foo\t", + "refs/heads/@", + "refs/heads/@{bar}", + "refs/heads/\n", + "refs/heads/-foo", + "refs/heads/foo..bar", + "refs/heads/-", + "refs/tags/-", + "refs/tags/-foo", + } + + for i, v := range invalid { + comment := Commentf("invalid reference name case %d: %s", i, v) + c.Assert(v.Validate(), NotNil, comment) + c.Assert(v.Validate(), ErrorMatches, "invalid reference name", comment) + } +} + func benchMarkReferenceString(r *Reference, b *testing.B) { for n := 0; n < b.N; n++ { _ = r.String() |