diff options
| author | Máximo Cuadros <mcuadros@gmail.com> | 2022-11-16 12:07:28 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-16 12:07:28 +0100 |
| commit | 71f6540e90b9a8cd3d4e3455b7d1d53c60a39d16 (patch) | |
| tree | ca3c69cd0b49501450e68dc196cd81403caeaf90 /plumbing/protocol/packp/uppackresp_test.go | |
| parent | 452df976faca7193b275bd31a0d76027a2a9df5c (diff) | |
| parent | 9c7d2df0f3b85745bea4d764e51ab9e811bf644d (diff) | |
| download | go-git-71f6540e90b9a8cd3d4e3455b7d1d53c60a39d16.tar.gz | |
Merge pull request #613 from fluxcd/unsupported
Allow unsupported `multi_ack` capability
Diffstat (limited to 'plumbing/protocol/packp/uppackresp_test.go')
| -rw-r--r-- | plumbing/protocol/packp/uppackresp_test.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/plumbing/protocol/packp/uppackresp_test.go b/plumbing/protocol/packp/uppackresp_test.go index 260dc57..3f87804 100644 --- a/plumbing/protocol/packp/uppackresp_test.go +++ b/plumbing/protocol/packp/uppackresp_test.go @@ -59,6 +59,10 @@ func (s *UploadPackResponseSuite) TestDecodeMalformed(c *C) { c.Assert(err, NotNil) } +// multi_ack isn't fully implemented, this ensures that Decode ignores that fact, +// as in some circumstances that's OK to assume so. +// +// TODO: Review as part of multi_ack implementation. func (s *UploadPackResponseSuite) TestDecodeMultiACK(c *C) { req := NewUploadPackRequest() req.Capabilities.Set(capability.MultiACK) @@ -67,7 +71,7 @@ func (s *UploadPackResponseSuite) TestDecodeMultiACK(c *C) { defer res.Close() err := res.Decode(ioutil.NopCloser(bytes.NewBuffer(nil))) - c.Assert(err, NotNil) + c.Assert(err, IsNil) } func (s *UploadPackResponseSuite) TestReadNoDecode(c *C) { |