diff options
| author | Javi Fontan <jfontan@gmail.com> | 2018-03-26 23:18:54 +0200 |
|---|---|---|
| committer | Javi Fontan <jfontan@gmail.com> | 2018-03-27 17:32:59 +0200 |
| commit | 05c414a169a75ca933402e5be19a5c4304aa4f00 (patch) | |
| tree | 19dcd85c5d221cf41fa06c200423d5cc236f9f31 /plumbing/object/tag.go | |
| parent | 160e6d5b654fbbaf0d9264f226c56a03f0e27d30 (diff) | |
| download | go-git-05c414a169a75ca933402e5be19a5c4304aa4f00.tar.gz | |
*: Use CheckClose with named returns
Previously some close errors were losts. This is specially problematic
in go-git as lots of work is done here like generating indexes and
moving packfiles.
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Diffstat (limited to 'plumbing/object/tag.go')
| -rw-r--r-- | plumbing/object/tag.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/plumbing/object/tag.go b/plumbing/object/tag.go index 19e55cf..905206b 100644 --- a/plumbing/object/tag.go +++ b/plumbing/object/tag.go @@ -95,7 +95,8 @@ func (t *Tag) Decode(o plumbing.EncodedObject) (err error) { r := bufio.NewReader(reader) for { - line, err := r.ReadBytes('\n') + var line []byte + line, err = r.ReadBytes('\n') if err != nil && err != io.EOF { return err } @@ -168,7 +169,7 @@ func (t *Tag) Encode(o plumbing.EncodedObject) error { return t.encode(o, true) } -func (t *Tag) encode(o plumbing.EncodedObject, includeSig bool) error { +func (t *Tag) encode(o plumbing.EncodedObject, includeSig bool) (err error) { o.SetType(plumbing.TagObject) w, err := o.Writer() if err != nil { |