diff options
author | Kyungmin Bae <kyungmin.bae@devsisters.com> | 2020-05-24 02:29:58 +0900 |
---|---|---|
committer | Kyungmin Bae <kyungmin.bae@devsisters.com> | 2020-05-24 02:29:58 +0900 |
commit | 10199949b9e5a71f72241c4bb23f3d733287065c (patch) | |
tree | 52b3efdb1944d9c833522d32a0af5c4b275a3ab6 /plumbing/format/packfile/diff_delta.go | |
parent | 6d8103df45ce09ffd5323b4ef46d26440400a54f (diff) | |
download | go-git-10199949b9e5a71f72241c4bb23f3d733287065c.tar.gz |
Close Reader & Writer of EncodedObject after use
Diffstat (limited to 'plumbing/format/packfile/diff_delta.go')
-rw-r--r-- | plumbing/format/packfile/diff_delta.go | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/plumbing/format/packfile/diff_delta.go b/plumbing/format/packfile/diff_delta.go index 1d4b384..1951b34 100644 --- a/plumbing/format/packfile/diff_delta.go +++ b/plumbing/format/packfile/diff_delta.go @@ -4,6 +4,7 @@ import ( "bytes" "github.com/go-git/go-git/v5/plumbing" + "github.com/go-git/go-git/v5/utils/ioutil" ) // See https://github.com/jelmer/dulwich/blob/master/dulwich/pack.py and @@ -27,17 +28,20 @@ func GetDelta(base, target plumbing.EncodedObject) (plumbing.EncodedObject, erro return getDelta(new(deltaIndex), base, target) } -func getDelta(index *deltaIndex, base, target plumbing.EncodedObject) (plumbing.EncodedObject, error) { +func getDelta(index *deltaIndex, base, target plumbing.EncodedObject) (o plumbing.EncodedObject, err error) { br, err := base.Reader() if err != nil { return nil, err } - defer br.Close() + + defer ioutil.CheckClose(br, &err) + tr, err := target.Reader() if err != nil { return nil, err } - defer tr.Close() + + defer ioutil.CheckClose(tr, &err) bb := bufPool.Get().(*bytes.Buffer) defer bufPool.Put(bb) |