clients: helpful error handling

1 files changed, 36 insertions, 0 deletions

diff --git a/clients/http/common_test.go b/clients/http/common_test.go
index b672801..7bd9708 100644
--- a/clients/http/common_test.go
+++ b/clients/http/common_test.go
@@ -1,9 +1,45 @@
 package http
 
 import (
+	"net/http"
 	"testing"
 
 	. "gopkg.in/check.v1"
 )
 
 func Test(t *testing.T) { TestingT(t) }
+
+type SuiteCommon struct{}
+
+var _ = Suite(&SuiteCommon{})
+
+func (s *SuiteCommon) TestNewHTTPError200(c *C) {
+	res := &http.Response{StatusCode: 200}
+	res.StatusCode = 200
+	err := NewHTTPError(res)
+	c.Assert(err, IsNil)
+}
+
+func (s *SuiteCommon) TestNewHTTPError401(c *C) {
+	s.testNewHTTPError(c, 401, "permanent client error.*not found.*")
+}
+
+func (s *SuiteCommon) TestNewHTTPError404(c *C) {
+	s.testNewHTTPError(c, 404, "permanent client error.*not found.*")
+}
+
+func (s *SuiteCommon) TestNewHTTPError40x(c *C) {
+	s.testNewHTTPError(c, 402, "unexpected client error.*")
+}
+
+func (s *SuiteCommon) testNewHTTPError(c *C, code int, msg string) {
+	req, _ := http.NewRequest("GET", "foo", nil)
+	res := &http.Response{
+		StatusCode: code,
+		Request:    req,
+	}
+
+	err := NewHTTPError(res)
+	c.Assert(err, NotNil)
+	c.Assert(err, ErrorMatches, msg)
+}