diff options
author | ferhat elmas <elmas.ferhat@gmail.com> | 2017-11-29 02:24:31 +0100 |
---|---|---|
committer | ferhat elmas <elmas.ferhat@gmail.com> | 2017-11-29 13:01:32 +0100 |
commit | 18e6f9daa3899318d36b525b068837f49bc2c1cf (patch) | |
tree | a797b79d0a750972ba9809eb52691cb09f9b6383 /blame.go | |
parent | c07c778ed043429427533e2fd7549a3d54b903f1 (diff) | |
download | go-git-18e6f9daa3899318d36b525b068837f49bc2c1cf.tar.gz |
all: simplification
- no length for map initialization
- don't check for boolean/error return
- don't format string
- use string method of bytes buffer instead of converting bytes to
string
- use `strings.Contains` instead of `strings.Index`
- use `bytes.Equal` instead of `bytes.Compare`
Diffstat (limited to 'blame.go')
-rw-r--r-- | blame.go | 7 |
1 files changed, 2 insertions, 5 deletions
@@ -147,10 +147,7 @@ func (b *blame) fillRevs() error { var err error b.revs, err = references(b.fRev, b.path) - if err != nil { - return err - } - return nil + return err } // build graph of a file from its revision history @@ -244,7 +241,7 @@ func (b *blame) GoString() string { lines := strings.Split(contents, "\n") // max line number length - mlnl := len(fmt.Sprintf("%s", strconv.Itoa(len(lines)))) + mlnl := len(strconv.Itoa(len(lines))) // max author length mal := b.maxAuthorLength() format := fmt.Sprintf("%%s (%%-%ds %%%dd) %%s\n", |