From 88ad7e606f1cbf9e47b968a208e3510f7f9a81c5 Mon Sep 17 00:00:00 2001 From: Michael Muré Date: Tue, 23 Jun 2020 18:02:54 +0200 Subject: repository: remove tie to Bug, improved and reusable testing - allow the creation of arbitrary Lamport clocks, freeing the way to new entities and removing Bug specific (upper layer) code. - generalize the memory-only and persisted Lamport clocks behind a common interface - rework the tests to provide reusable testing code for a Repo, a Clock, a Config, opening a path to add a new Repo implementation more easily - test previously untested components with those new tests Note: one problem found during this endeavor is that `identity.Version` also need to store one time + Lamport time for each other Entity (Bug, config, PR ...). This could possibly done without breaking change but it would be much easier to wait for https://github.com/MichaelMure/git-bug-migration to happen. --- tests/read_bugs_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tests/read_bugs_test.go') diff --git a/tests/read_bugs_test.go b/tests/read_bugs_test.go index c510fdbe..4fd3943a 100644 --- a/tests/read_bugs_test.go +++ b/tests/read_bugs_test.go @@ -10,7 +10,7 @@ import ( func TestReadBugs(t *testing.T) { repo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repo) + defer repository.CleanupTestRepos(repo) random_bugs.FillRepoWithSeed(repo, 15, 42) @@ -24,7 +24,7 @@ func TestReadBugs(t *testing.T) { func benchmarkReadBugs(bugNumber int, t *testing.B) { repo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repo) + defer repository.CleanupTestRepos(repo) random_bugs.FillRepoWithSeed(repo, bugNumber, 42) t.ResetTimer() -- cgit